You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/03/13 03:46:02 UTC
Review Request 32019: HIVE-9950 fix rehash in CuckooSetBytes and
CuckooSetLong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32019/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Gopal V, Sergey Shelukhin, and Vikram Dixit Kumaraswamy.
Bugs: HIVE-9950
https://issues.apache.org/jira/browse/HIVE-9950
Repository: hive-git
Description
-------
HIVE-9950 fix rehash in CuckooSetBytes and CuckooSetLong
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java fe75ce3d3b14b84d023612c00554729e793dc677
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetDouble.java 5897c92a2022fea4e4453b2807fc7b3b364e2282
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3
Diff: https://reviews.apache.org/r/32019/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32019: HIVE-9950 fix rehash in CuckooSetBytes and
CuckooSetLong
Posted by Alexander Pivovarov <ap...@gmail.com>.
> On March 16, 2015, 9:02 p.m., Matt McCline wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java, line 209
> > <https://reviews.apache.org/r/32019/diff/1/?file=892731#file892731line209>
> >
> > At a "micro" level, this and the other change look good.
> >
> > Did you spot it in code reading?
> > Or, in the hash results being poor?
> > The research paper would take time to study.
> > How would one write tests for Cuckoo?
FindBugs software found this and other issues.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32019/#review76644
-----------------------------------------------------------
On March 13, 2015, 2:46 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32019/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 2:46 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan, Gopal V, Sergey Shelukhin, and Vikram Dixit Kumaraswamy.
>
>
> Bugs: HIVE-9950
> https://issues.apache.org/jira/browse/HIVE-9950
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9950 fix rehash in CuckooSetBytes and CuckooSetLong
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java fe75ce3d3b14b84d023612c00554729e793dc677
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetDouble.java 5897c92a2022fea4e4453b2807fc7b3b364e2282
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3
>
> Diff: https://reviews.apache.org/r/32019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 32019: HIVE-9950 fix rehash in CuckooSetBytes and
CuckooSetLong
Posted by Matt McCline <mm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32019/#review76644
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java
<https://reviews.apache.org/r/32019/#comment124228>
At a "micro" level, this and the other change look good.
Did you spot it in code reading?
Or, in the hash results being poor?
The research paper would take time to study.
How would one write tests for Cuckoo?
- Matt McCline
On March 13, 2015, 2:46 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32019/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 2:46 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan, Gopal V, Sergey Shelukhin, and Vikram Dixit Kumaraswamy.
>
>
> Bugs: HIVE-9950
> https://issues.apache.org/jira/browse/HIVE-9950
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9950 fix rehash in CuckooSetBytes and CuckooSetLong
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java fe75ce3d3b14b84d023612c00554729e793dc677
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetDouble.java 5897c92a2022fea4e4453b2807fc7b3b364e2282
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3
>
> Diff: https://reviews.apache.org/r/32019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>