[jira] [Commented] (AIRFLOW-4824) MySqlHook needs to override DbApiHook.get_uri to pull in extra for charset=utf-8 during create_engine

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995905#comment-16995905 ] 

ASF GitHub Bot commented on AIRFLOW-4824:
-----------------------------------------

zuku1985 commented on pull request #6816: [AIRFLOW-4824] Add charset handling for SqlAlchemy engine for MySqlHook
URL: https://github.com/apache/airflow/pull/6816
 
 
   Airflow should handle various charsets for connections with MySQL dbs.
   This change allows to set charset in extra field of a connection when
   using SqlAlchemy engine.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4824
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Airflow should handle various charsets for connections with MySQL dbs.
   This change allows to set charset in extra field of a connection when
   using SqlAlchemy engine.
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   test_get_uri in TestMySqlHookConn
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> MySqlHook needs to override DbApiHook.get_uri to pull in extra for charset=utf-8 during create_engine
> -----------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4824
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4824
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.10.3
>            Reporter: lolcode
>            Assignee: Tomasz Żukowski
>            Priority: Minor
>
> When using the engine from a MySQLHook in other code (such as Pandas) the engine returned from the create_engine function is missing the charset=utf-8 
> This issue was reported here: [https://stackoverflow.com/questions/46084744/how-to-explicitly-declare-charset-utf8-for-airflow-connections]
> {{{{conn = MySqlHook(mysql_conn_id='conn_id')
> }}}}{{{{engine = conn.get_sqlalchemy_engine()}}}}
> I can see that the code in function *get_uri* in dbapi_hook.py does not use the charset = utf8 information from the extra section and that mysql_hook.py does not override the function.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)