You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/11 15:19:24 UTC
[GitHub] [flink] RyanSkraba opened a new pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
RyanSkraba opened a new pull request #17451:
URL: https://github.com/apache/flink/pull/17451
## What is the purpose of the change
FLINK-24476 This pull request renames all documentation and code instances of ElasticSearch to Elasticsearch to align with their brand guidelines.
## Brief change log
- There are no file names with an internal S
- All documentation, javadoc and private methods were renamed without an internal S.
- [This commit](https://github.com/RyanSkraba/flink/commit/55bbb7e7f747599b91a2926e47af4ea299a728e4) changes a class name that is technically exposed as API, but not `@Public` and clearly documented in comments for internal use only.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
`grep -r lasticSearch .` returns no results after this commit.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728084582
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
Despite the comment surrounding this block, annotation-wise this is technically Public API. I'd still +1 to change it, but any committer merging this should be aware of this.
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
Since for now we're changing it, can you slap a `@Internal` on it? It's essentially just an oversight, so I would just make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 065fc086a4726947698c4b04dbd598685ab756e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 065fc086a4726947698c4b04dbd598685ab756e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155)
* d62928794769aaa1cfa3307cf6aa4026810d6eda Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 065fc086a4726947698c4b04dbd598685ab756e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155)
* d62928794769aaa1cfa3307cf6aa4026810d6eda UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728139691
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
Since for now we're changing it, can you slap a `@Internal` on it? It's essentially just an oversight, so I would just make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-990108902
(manually rebased on master to fix conflicts)
BTW, should I be squashing these commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-972972966
(manually rebased on master to fix conflicts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728132999
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
You are correct, thanks! I updated the PR description with a **yes** to that question.
A tool like Java API Compliance Checker (JAPICC) would report this as a compatibility issue. If getting a nice 100% is a priority we can just drop the last commit in this PR, no harm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55bbb7e7f747599b91a2926e47af4ea299a728e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55bbb7e7f747599b91a2926e47af4ea299a728e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
}, {
"hash" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d62928794769aaa1cfa3307cf6aa4026810d6eda Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711)
* 713275112a157cc96610d6c02daf4b66b5b94b57 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
}, {
"hash" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27805",
"triggerID" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 713275112a157cc96610d6c02daf4b66b5b94b57 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55bbb7e7f747599b91a2926e47af4ea299a728e4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728084582
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
Despite the comment surrounding this block, annotation-wise this is technically Public API. I'd still +1 to change it, but any committer merging this should be aware of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55bbb7e7f747599b91a2926e47af4ea299a728e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960)
* 065fc086a4726947698c4b04dbd598685ab756e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r730775316
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
I set the entire `Elasticsearch6DynamicSink` as `@Internal` -- this seems to be the case for other `DynamicTableSink` implementations, and consistent with `Elasticsearch7DynamicSink`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728132999
##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
You are correct, thanks! I updated the PR description with a **yes** to that question.
A tool like Java API Compliance Checker (JAPICC) would report this as a compatibility issue. If getting a nice 100% is a priority we can just drop the last commit in this PR, no harm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940127779
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 55bbb7e7f747599b91a2926e47af4ea299a728e4 (Mon Oct 11 15:22:59 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d62928794769aaa1cfa3307cf6aa4026810d6eda Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25155",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
}, {
"hash" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711",
"triggerID" : "d62928794769aaa1cfa3307cf6aa4026810d6eda",
"triggerType" : "PUSH"
}, {
"hash" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27805",
"triggerID" : "713275112a157cc96610d6c02daf4b66b5b94b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d62928794769aaa1cfa3307cf6aa4026810d6eda Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26711)
* 713275112a157cc96610d6c02daf4b66b5b94b57 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17451:
URL: https://github.com/apache/flink/pull/17451#issuecomment-940126969
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960",
"triggerID" : "55bbb7e7f747599b91a2926e47af4ea299a728e4",
"triggerType" : "PUSH"
}, {
"hash" : "065fc086a4726947698c4b04dbd598685ab756e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "065fc086a4726947698c4b04dbd598685ab756e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55bbb7e7f747599b91a2926e47af4ea299a728e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24960)
* 065fc086a4726947698c4b04dbd598685ab756e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org