[couchdb] 05/31: Port config.js tests

[ch...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

chewbranca pushed a commit to branch elixir-suite
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 3c4730e8f0e2d12e379267efaedd6069784a7a57
Author: Russell Branca <ch...@apache.org>
AuthorDate: Wed Dec 6 21:51:55 2017 +0000

    Port config.js tests
---
 elixir_suite/lib/couch.ex         |   6 ++
 elixir_suite/test/config_test.exs | 149 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 155 insertions(+)

diff --git a/elixir_suite/lib/couch.ex b/elixir_suite/lib/couch.ex
index aafe829..d879ecf 100644
--- a/elixir_suite/lib/couch.ex
+++ b/elixir_suite/lib/couch.ex
@@ -30,4 +30,10 @@ defmodule Couch do
   def process_response_body(body) do
     body |> IO.iodata_to_binary |> :jiffy.decode([:return_maps])
   end
+
+  def login(user, pass) do
+    resp = Couch.post("/_session", body: %{:username => user, :password => pass})
+    true = resp.body["ok"]
+    resp.body
+  end
 end
diff --git a/elixir_suite/test/config_test.exs b/elixir_suite/test/config_test.exs
new file mode 100644
index 0000000..f83f5a6
--- /dev/null
+++ b/elixir_suite/test/config_test.exs
@@ -0,0 +1,149 @@
+defmodule ConfigTest do
+  use CouchTestCase
+
+  @moduletag :config
+
+  @moduledoc """
+  Test CouchDB config API
+  This is a port of the config.js suite
+  """
+
+  setup do
+    # TODO: switch this to _local when that's landed
+    config_url = "/_node/node1@127.0.0.1/_config"
+    resp = Couch.get(config_url)
+    assert resp.status_code == 200
+    {:ok, config: resp.body, config_url: config_url}
+  end
+
+  def set_config(context, section, key, val) do
+    set_config(context, section, key, val, 200)
+  end
+
+  def set_config(context, section, key, val, status_assert) do
+    url = "#{context[:config_url]}/#{section}/#{key}"
+    headers = ["X-Couch-Persist": "false"]
+    resp = Couch.put(url, headers: headers, body: :jiffy.encode(val))
+    if status_assert do
+      assert resp.status_code == status_assert
+    end
+    resp.body
+  end
+
+  def get_config(context, section) do
+    get_config(context, section, nil, 200)
+  end
+
+  def get_config(context, section, key) do
+    get_config(context, section, key, 200)
+  end
+
+  def get_config(context, section, key, status_assert) do
+    url = if key do
+      "#{context[:config_url]}/#{section}/#{key}"
+    else
+      "#{context[:config_url]}/#{section}"
+    end
+    resp = Couch.get(url)
+    if status_assert do
+      assert resp.status_code == status_assert
+    end
+    resp.body
+  end
+
+  def delete_config(context, section, key) do
+    delete_config(context, section, key, 200)
+  end
+
+  def delete_config(context, section, key, status_assert) do
+    url = "#{context[:config_url]}/#{section}/#{key}"
+    resp = Couch.delete(url)
+    if status_assert do
+      assert resp.status_code == status_assert
+    end
+  end
+
+  # TODO: port sever_port tests from config.js
+  @tag :pending
+  test "CouchDB respects configured protocols"
+
+  test "Standard config options are present", context do
+    assert context[:config]["couchdb"]["database_dir"]
+    assert context[:config]["daemons"]["httpd"]
+    assert context[:config]["httpd_global_handlers"]["_config"]
+    assert context[:config]["log"]["level"]
+    assert context[:config]["query_servers"]["javascript"]
+  end
+
+  test "Settings can be altered with undefined whitelist allowing any change", context do
+    refute context["config"]["httpd"]["config_whitelist"], "Default whitelist is empty" 
+    set_config(context, "test", "foo", "bar")
+    assert get_config(context, "test")["foo"] == "bar"
+    assert get_config(context, "test", "foo") == "bar"
+  end
+
+  test "Server-side password hashing, and raw updates disabling that", context do
+    plain_pass = "s3cret"
+    set_config(context, "admins", "administrator", plain_pass)
+    assert Couch.login("administrator", plain_pass)["ok"]
+    hash_pass = get_config(context, "admins", "administrator")
+    assert Regex.match?(~r/^-pbkdf2-/, hash_pass) or Regex.match?(~r/^-hashed-/, hash_pass)
+    delete_config(context, "admins", "administrator")
+    assert Couch.delete("/_session").body["ok"]
+  end
+
+  @tag :pending
+  test "PORT `BUGGED` ?raw tests from config.js"
+
+  test "Non-term whitelist values allow further modification of the whitelist", context do
+    val = "!This is an invalid Erlang term!"
+    set_config(context, "httpd", "config_whitelist", val)
+    assert val == get_config(context, "httpd", "config_whitelist")
+    delete_config(context, "httpd", "config_whitelist")
+  end
+
+  test "Non-list whitelist values allow further modification of the whitelist", context do
+    val = "{[yes, a_valid_erlang_term, but_unfortunately, not_a_list]}"
+    set_config(context, "httpd", "config_whitelist", val)
+    assert val == get_config(context, "httpd", "config_whitelist")
+    delete_config(context, "httpd", "config_whitelist")
+  end
+
+  test "Keys not in the whitelist may not be modified", context do
+    val = "[{httpd,config_whitelist}, {test,foo}]"
+    set_config(context, "httpd", "config_whitelist", val)
+    assert val == get_config(context, "httpd", "config_whitelist")
+    set_config(context, "test", "foo", "PUT to whitelisted config variable")
+    delete_config(context, "test", "foo")
+  end
+
+  test "Non-2-tuples in the whitelist are ignored", context do
+    val = "[{httpd,config_whitelist}, these, {are}, {nOt, 2, tuples}, [so], [they, will], [all, become, noops], {test,foo}]"
+    set_config(context, "httpd", "config_whitelist", val)
+    assert val == get_config(context, "httpd", "config_whitelist")
+    set_config(context, "test", "foo", "PUT to whitelisted config variable")
+    delete_config(context, "test", "foo")
+  end
+
+  test "Atoms, binaries, and strings suffice as whitelist sections and keys.", context do
+    vals = ["{test,foo}", "{\"test\",\"foo\"}", "{<<\"test\">>,<<\"foo\">>}"]
+    Enum.each(vals, fn pair ->
+      set_config(context, "httpd", "config_whitelist", "[{httpd,config_whitelist}, #{pair}")
+      pair_format = case String.at(pair, 1) do
+        "t" -> "tuple"
+        "\"" -> "string"
+        "<" -> "binary"
+      end
+      set_config(context, "test", "foo", "PUT with #{pair_format}")
+      delete_config(context, "test", "foo")
+    end)
+    delete_config(context, "httpd", "config_whitelist")
+  end
+
+  test "Blacklist is functional", context do
+    sections = ["daemons", "external", "httpd_design_handlers", "httpd_db_handlers", "native_query_servers", "os_daemons", "query_servers"]
+    Enum.each(sections, fn section ->
+      set_config(context, section, "wohali", "rules", 403)
+    end)
+  end
+end