You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2020/12/23 20:06:30 UTC
[tinkerpop] branch master updated (44bbf76 -> 16266fa)
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.
from 44bbf76 Merge branch '3.4-dev'
new aa92509 Bumped to Groovy 2.5.14 CTR
new 8b20772 TINKERPOP-2447 Help users understand StackOverflowError
new b0ee5fa Merge branch '3.4-dev'
new 16266fa Bumped to Groovy 3.0.7 CTR
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGELOG.asciidoc | 3 ++-
docs/src/reference/gremlin-applications.asciidoc | 5 +++++
.../org/apache/tinkerpop/gremlin/console/Console.groovy | 13 +++++++++++++
pom.xml | 2 +-
4 files changed, 21 insertions(+), 2 deletions(-)
[tinkerpop] 04/04: Bumped to Groovy 3.0.7 CTR
Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 16266faf4e402d738298484bc299785976108f0f
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Wed Dec 23 15:06:02 2020 -0500
Bumped to Groovy 3.0.7 CTR
---
CHANGELOG.asciidoc | 2 +-
pom.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index f8ca995..985013a 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -57,7 +57,7 @@ This release also includes changes from <<release-3-4-3, 3.4.3>>.
* Bumped to tornado 6.1 for gremlinpython.
* Bumped to Neo4j 3.4.11.
* Bumped to Spark 3.0.0.
-* Bumped to Groovy 3.0.3.
+* Bumped to Groovy 3.0.x.
* Bumped to Jackson 2.11.x.
* Supported build for Java 11.
* Added a parameterized `TypeTranslator` for use with `GroovyTranslator` that should produce more cache hits.
diff --git a/pom.xml b/pom.xml
index 653c9ef..b983cd7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -149,7 +149,7 @@ limitations under the License.
<commons.configuration.version>2.6</commons.configuration.version>
<commons.lang.version>2.6</commons.lang.version>
<commons.lang3.version>3.11</commons.lang3.version>
- <groovy.version>3.0.3</groovy.version>
+ <groovy.version>3.0.7</groovy.version>
<hadoop.version>2.7.7</hadoop.version>
<java.tuples.version>1.2</java.tuples.version>
<javadoc-plugin.version>3.1.0</javadoc-plugin.version>
[tinkerpop] 01/04: Bumped to Groovy 2.5.14 CTR
Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit aa92509e116a13bd5ed89bee800efbd2b2e53a5b
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Wed Dec 23 13:51:08 2020 -0500
Bumped to Groovy 2.5.14 CTR
---
CHANGELOG.asciidoc | 1 +
pom.xml | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index e44d0c8..69e1be5 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -27,6 +27,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Fixed bug in `PythonTranslator` which was improperly translating `Lambda` scripts.
* Fixed bug in `GremlinDslProcessor` where certain return types in `TraversalSource` definitions were not generating code that would compile.
* Checked high limit before retrieving next traverser in `RangeGlobalStep`.
+* Bumped to Groovy 2.5.14.
[[release-3-4-9]]
=== TinkerPop 3.4.9 (Release Date: December 7, 2020)
diff --git a/pom.xml b/pom.xml
index f203308..4eaefe2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -149,7 +149,7 @@ limitations under the License.
<commons.configuration.version>1.10</commons.configuration.version>
<commons.lang.version>2.6</commons.lang.version>
<commons.lang3.version>3.11</commons.lang3.version>
- <groovy.version>2.5.11</groovy.version>
+ <groovy.version>2.5.14</groovy.version>
<hadoop.version>2.7.2</hadoop.version>
<java.tuples.version>1.2</java.tuples.version>
<javadoc-plugin.version>2.10.4</javadoc-plugin.version>
[tinkerpop] 03/04: Merge branch '3.4-dev'
Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit b0ee5fabf3cba5a9e67a8c71e5d1ecc64be390bf
Merge: 44bbf76 8b20772
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Wed Dec 23 14:43:05 2020 -0500
Merge branch '3.4-dev'
CHANGELOG.asciidoc | 1 +
docs/src/reference/gremlin-applications.asciidoc | 5 +++++
.../org/apache/tinkerpop/gremlin/console/Console.groovy | 13 +++++++++++++
3 files changed, 19 insertions(+)
[tinkerpop] 02/04: TINKERPOP-2447 Help users understand
StackOverflowError
Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 8b207721f46ad7837d95ba551ed528cb285d2b47
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Wed Dec 23 14:15:46 2020 -0500
TINKERPOP-2447 Help users understand StackOverflowError
For the Console present a detailed error message of what might be wrong and for the server add a "Tuning" bullet point that mentions -Xss. CTR
---
docs/src/reference/gremlin-applications.asciidoc | 5 +++++
.../org/apache/tinkerpop/gremlin/console/Console.groovy | 13 +++++++++++++
2 files changed, 18 insertions(+)
diff --git a/docs/src/reference/gremlin-applications.asciidoc b/docs/src/reference/gremlin-applications.asciidoc
index 1e2a037..d847140 100644
--- a/docs/src/reference/gremlin-applications.asciidoc
+++ b/docs/src/reference/gremlin-applications.asciidoc
@@ -1696,6 +1696,11 @@ image:gremlin-handdrawn.png[width=120,float=right] Tuning Gremlin Server for a p
* Gremlin Server defaults to a very modest maximum heap size. Consider increasing this value for non-trivial uses.
Maximum heap size (`-Xmx`) is defined with the `JAVA_OPTIONS` setting in `gremlin-server.conf`.
+* TinkerPop tends to discourage the use of link:https://tinkerpop.apache.org/docs/x.y.z/recipes/#long-traversals[long traversals]
+as they can introduce performance problems in some cases and in others simply fail with a `StackOverflowError`. Aside
+from restructuring the traversal into multiple commands or stream based inserts, it may sometimes make sense to simply
+increase the stack size of the JVM for Gremlin Server by configuring an `-Xss` setting in `JAVA_OPTIONS` of
+`gremlin-server.conf`.
* If Gremlin Server is processing scripts or lambdas in bytecode requests, consider fine tuning the JVM's handling of
the metaspace size. Consider modifying the `-XX:MetaspaceSize`,`-XX:MaxMetaspaceSize`, and related settings given the
expected workload. More discussion on this topic can be found in the <<parameterized-scripts,Parameterized Scripts>>
diff --git a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
index 3dd8e69..c47bbf3 100644
--- a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
+++ b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
@@ -354,6 +354,19 @@ class Console {
io.err.println(Colorizer.render(Preferences.errorColor,e))
}
+ // provide a hint in the case of a stackoverflow as it can be common when running large Gremlin
+ // scripts and it isn't immediately apparent what the error might mean in this context especially
+ // if the user isn't familiar with the JVM. it really can only be a hint since we can't be completely
+ // sure it arose as a result of a long Gremlin traversal.
+ if (err instanceof StackOverflowError) {
+ io.err.println(Colorizer.render(Preferences.errorColor,
+ "A StackOverflowError can indicate that the Gremlin traversal being executed is too long. If " +
+ "you have a single Gremlin statement that is \"long\", you may break it up into " +
+ "multiple separate commands, re-write the traversal to operate on a stream of " +
+ "input via inject() rather than literals, or attempt to increase the -Xss setting" +
+ "of the Gremlin Console by modifying gremlin.sh."));
+ }
+
if (interactive) {
io.err.println(Colorizer.render(Preferences.infoColor,"Type ':help' or ':h' for help."))
io.err.print(Colorizer.render(Preferences.errorColor, "Display stack trace? [yN]"))