You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/06/07 21:47:21 UTC
[jira] [Resolved] (OAK-4127) Cleanup creates new generation of tar
file without removing any segments
[ https://issues.apache.org/jira/browse/OAK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved OAK-4127.
--------------------------------
Resolution: Not A Problem
Resolving as not a problem as this has been most likely caused by OAK-4147
> Cleanup creates new generation of tar file without removing any segments
> -------------------------------------------------------------------------
>
> Key: OAK-4127
> URL: https://issues.apache.org/jira/browse/OAK-4127
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Reporter: Michael Dürig
> Priority: Minor
> Labels: cleanup, gc
> Fix For: 1.6
>
>
> On some deployments I have seen tar files with a quite hight generation post-fix (e.g. 'v'). From the log files I could deduce that this particular tar file was rewritten multiple times without actually any segment being removed.
> I assume this is caused by the 25% [gain threshold | https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/TarReader.java#L789] not taking the sizes contributed by the index and the graph entries into account.
> We should try to come up with a test case validating above hypothesis. A fix should then be relatively straight forward: either include the sizes of these two entries in the calculation or skip further clean cycles if a file size drops below a certain size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)