You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/14 13:13:14 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11938: ARROW-15077: [Python] Move Expression class from _dataset to _compute cython module

jorisvandenbossche commented on a change in pull request #11938:
URL: https://github.com/apache/arrow/pull/11938#discussion_r784831930



##########
File path: python/pyarrow/dataset.py
##########
@@ -47,6 +46,9 @@
     _get_partition_keys,
     _filesystemdataset_write,
 )
+# keep Expression functionality exposed here for backwards compatibility
+from pyarrow.compute import Expression, scalar, field  # noqa

Review comment:
       I would personally keep them. For simple cases where you just want to do a standard filter (like `ds.dataset(..).to_table(filter=ds.field("col") > 0)`), you only need `field`, and it is convenient you can do that with the same namespace, instead of also having to import `pyarrow.compute` just for `field`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org