[jira] [Commented] (KAFKA-5052) We shouldn't pass the underlying exception to RetriableCommitFailedException when an async offset commit fails.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963675#comment-15963675 ] 

ASF GitHub Bot commented on KAFKA-5052:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2838


> We shouldn't pass the underlying exception to RetriableCommitFailedException when an async offset commit fails.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5052
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5052
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Apurva Mehta
>            Assignee: Apurva Mehta
>             Fix For: 0.11.0.0
>
>
> This is a follow up to : https://issues.apache.org/jira/browse/KAFKA-3527
> We currently wrap retriable exceptions encountered during offset commits in a `RetriableOffsetCommitException`. The problem is that today we also pass the underlying internal exception on to the user. There isn't a really good reason to do this, since the user will not handle each individual exception differently: they will just retry anyway.
> We should not pass on the underlying internal exception. It makes the API simpler, and also allows us to change things underneath with more flexibility.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)