You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Barry Oglesby <bo...@pivotal.io> on 2016/05/09 22:08:26 UTC
Re: Review Request 46988: GEODE-1330: Set boolean so that internal
lucene regions aren't generated in xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46988/
-----------------------------------------------------------
(Updated May 9, 2016, 10:08 p.m.)
Review request for geode, anilkumar gingade and Dan Smith.
Repository: geode
Description (updated)
-------
GEODE-1330: Set boolean so that internal lucene regions aren't generated in xml
This is an update to the previous request for this bug with Anil's comments incorporated:
- added integration test
- refactored createRegion method up to LuceneIndexImpl
I also added a LuceneIntegrationTest bsae class that I thought integration tests could inherit from. Currently only LuceneIndexCreationIntegrationTest extends it. I think LuceneIndexXmlParserIntegrationJUnitTest and LuceneQueryImplIntegrationTest could also be modified to extend it pretty easily.
Diffs (updated)
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 28ff5437dda678ce2b71e3764011f675a66899f6
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java cd07672fc8a7b00a15b995eb73d46824adedb4d6
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 1158fd1d9cf64d29ede3d235f7a3dbb70fd93395
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationIntegrationTest.java PRE-CREATION
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java ff22f85550af615d9c3bd55de2898ced9b94a8a9
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIntegrationTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46988/diff/
Testing
-------
- lucene precheckin
Thanks,
Barry Oglesby
Re: Review Request 46988: GEODE-1330: Set boolean so that internal
lucene regions aren't generated in xml
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46988/#review132341
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 9, 2016, 10:08 p.m., Barry Oglesby wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46988/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 10:08 p.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1330: Set boolean so that internal lucene regions aren't generated in xml
>
> This is an update to the previous request for this bug with Anil's comments incorporated:
>
> - added integration test
> - refactored createRegion method up to LuceneIndexImpl
>
> I also added a LuceneIntegrationTest bsae class that I thought integration tests could inherit from. Currently only LuceneIndexCreationIntegrationTest extends it. I think LuceneIndexXmlParserIntegrationJUnitTest and LuceneQueryImplIntegrationTest could also be modified to extend it pretty easily.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 28ff5437dda678ce2b71e3764011f675a66899f6
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java cd07672fc8a7b00a15b995eb73d46824adedb4d6
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 1158fd1d9cf64d29ede3d235f7a3dbb70fd93395
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationIntegrationTest.java PRE-CREATION
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java ff22f85550af615d9c3bd55de2898ced9b94a8a9
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIntegrationTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46988/diff/
>
>
> Testing
> -------
>
> - lucene precheckin
>
>
> Thanks,
>
> Barry Oglesby
>
>