You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2014/05/01 14:14:14 UTC
svn commit: r1591631 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Author: tn
Date: Thu May 1 12:14:14 2014
New Revision: 1591631
URL: http://svn.apache.org/r1591631
Log:
Disable randomly failing unit test.
Modified:
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java?rev=1591631&r1=1591630&r2=1591631&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java Thu May 1 12:14:14 2014
@@ -17,21 +17,18 @@
package org.apache.commons.math3.ml.neuralnet;
-import java.io.ByteArrayOutputStream;
import java.io.ByteArrayInputStream;
-import java.io.ObjectOutputStream;
-import java.io.ObjectInputStream;
+import java.io.ByteArrayOutputStream;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.HashSet;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
import java.util.Collection;
import java.util.NoSuchElementException;
-import org.junit.Test;
+
+import org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
import org.junit.Assert;
import org.junit.Ignore;
-import org.apache.commons.math3.exception.NumberIsTooSmallException;
-import org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
-import org.apache.commons.math3.random.Well44497b;
+import org.junit.Test;
/**
* Tests for {@link Network}.
@@ -110,6 +107,7 @@ public class NetworkTest {
}
@Test
+ @Ignore // to be fixed, fails randomly
public void testIterationOrder() {
final FeatureInitializer[] initArray = { init };
final Network net = new NeuronSquareMesh2D(4, false,
Re: svn commit: r1591631 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Thomas Neidhart <th...@gmail.com>.
On 05/01/2014 02:55 PM, Gilles wrote:
> On Thu, 01 May 2014 12:14:14 -0000, tn@apache.org wrote:
>> Author: tn
>> Date: Thu May 1 12:14:14 2014
>> New Revision: 1591631
>>
>> URL: http://svn.apache.org/r1591631
>> Log:
>> Disable randomly failing unit test.
>>
>> Modified:
>>
>>
>> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
>>
>>
>> Modified:
>>
>> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
>>
>> URL:
>>
>> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java?rev=1591631&r1=1591630&r2=1591631&view=diff
>>
>>
>> ==============================================================================
>>
>> ---
>>
>> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
>>
>> (original)
>> +++
>>
>> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
>>
>> Thu May 1 12:14:14 2014
>> @@ -17,21 +17,18 @@
>>
>> package org.apache.commons.math3.ml.neuralnet;
>>
>> -import java.io.ByteArrayOutputStream;
>> import java.io.ByteArrayInputStream;
>> -import java.io.ObjectOutputStream;
>> -import java.io.ObjectInputStream;
>> +import java.io.ByteArrayOutputStream;
>> import java.io.IOException;
>> -import java.util.ArrayList;
>> -import java.util.HashSet;
>> +import java.io.ObjectInputStream;
>> +import java.io.ObjectOutputStream;
>> import java.util.Collection;
>> import java.util.NoSuchElementException;
>> -import org.junit.Test;
>> +
>> +import org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
>> import org.junit.Assert;
>> import org.junit.Ignore;
>> -import org.apache.commons.math3.exception.NumberIsTooSmallException;
>> -import org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
>> -import org.apache.commons.math3.random.Well44497b;
>> +import org.junit.Test;
>>
>> /**
>> * Tests for {@link Network}.
>> @@ -110,6 +107,7 @@ public class NetworkTest {
>> }
>>
>> @Test
>> + @Ignore // to be fixed, fails randomly
>> public void testIterationOrder() {
>> final FeatureInitializer[] initArray = { init };
>> final Network net = new NeuronSquareMesh2D(4, false,
>
> How does it fail? How often? On which archtecture?
> Here, I couldn't get a single failure out of more than 20 runs.
> Please provide a stack trace.
Failed with java 8.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/05/2014 22:44, Gilles a écrit :
> You are right.
> In revision 1591770, I've removed this part of the unit test.
Thank you. ConcurrentHashMap has been revamped in Java 8, that explains
the issue.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Gilles <gi...@harfang.homelinux.org>.
On Thu, 01 May 2014 18:25:46 +0200, Emmanuel Bourg wrote:
> Le 01/05/2014 15:28, Gilles a écrit :
>> On Thu, 01 May 2014 15:13:53 +0200, Emmanuel Bourg wrote:
>>
>> Thanks; could you please run it with the latest trunk (line numbers
>> are
>> wrong)?
>
> On the trunk it fails at line 131:
Thanks.
>
> Assert.assertTrue(isUnspecifiedOrder);
>
> (Adding error messages to the assertions would be a good idea)
You are right.
In revision 1591770, I've removed this part of the unit test.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/05/2014 15:28, Gilles a écrit :
> On Thu, 01 May 2014 15:13:53 +0200, Emmanuel Bourg wrote:
>
> Thanks; could you please run it with the latest trunk (line numbers are
> wrong)?
On the trunk it fails at line 131:
Assert.assertTrue(isUnspecifiedOrder);
(Adding error messages to the assertions would be a good idea)
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Gilles <gi...@harfang.homelinux.org>.
On Thu, 01 May 2014 15:13:53 +0200, Emmanuel Bourg wrote:
> Le 01/05/2014 14:55, Gilles a écrit :
>
>> Please provide a stack trace.
>
> Here it is (with Java 8 on Windows and OpenJDK 8 on Debian) :
>
>
> -------------------------------------------------------------------------------
> Test set: org.apache.commons.math3.ml.neuralnet.NetworkTest
>
> -------------------------------------------------------------------------------
> Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.001
> sec <<< FAILURE! - in
> org.apache.commons.math3.ml.neuralnet.NetworkTest
> testIterationOrder(org.apache.commons.math3.ml.neuralnet.NetworkTest)
> Time elapsed: 0.001 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
>
> org.apache.commons.math3.ml.neuralnet.NetworkTest.testIterationOrder(NetworkTest.java:133)
Thanks; could you please run it with the latest trunk (line numbers are
wrong)?
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/05/2014 14:55, Gilles a écrit :
> Please provide a stack trace.
Here it is (with Java 8 on Windows and OpenJDK 8 on Debian) :
-------------------------------------------------------------------------------
Test set: org.apache.commons.math3.ml.neuralnet.NetworkTest
-------------------------------------------------------------------------------
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec <<< FAILURE! - in org.apache.commons.math3.ml.neuralnet.NetworkTest
testIterationOrder(org.apache.commons.math3.ml.neuralnet.NetworkTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.commons.math3.ml.neuralnet.NetworkTest.testIterationOrder(NetworkTest.java:133)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1591631 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
Posted by Gilles <gi...@harfang.homelinux.org>.
On Thu, 01 May 2014 12:14:14 -0000, tn@apache.org wrote:
> Author: tn
> Date: Thu May 1 12:14:14 2014
> New Revision: 1591631
>
> URL: http://svn.apache.org/r1591631
> Log:
> Disable randomly failing unit test.
>
> Modified:
>
>
> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
>
> Modified:
>
> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
> URL:
>
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java?rev=1591631&r1=1591630&r2=1591631&view=diff
>
> ==============================================================================
> ---
>
> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
> (original)
> +++
>
> commons/proper/math/trunk/src/test/java/org/apache/commons/math3/ml/neuralnet/NetworkTest.java
> Thu May 1 12:14:14 2014
> @@ -17,21 +17,18 @@
>
> package org.apache.commons.math3.ml.neuralnet;
>
> -import java.io.ByteArrayOutputStream;
> import java.io.ByteArrayInputStream;
> -import java.io.ObjectOutputStream;
> -import java.io.ObjectInputStream;
> +import java.io.ByteArrayOutputStream;
> import java.io.IOException;
> -import java.util.ArrayList;
> -import java.util.HashSet;
> +import java.io.ObjectInputStream;
> +import java.io.ObjectOutputStream;
> import java.util.Collection;
> import java.util.NoSuchElementException;
> -import org.junit.Test;
> +
> +import
> org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
> import org.junit.Assert;
> import org.junit.Ignore;
> -import org.apache.commons.math3.exception.NumberIsTooSmallException;
> -import
> org.apache.commons.math3.ml.neuralnet.twod.NeuronSquareMesh2D;
> -import org.apache.commons.math3.random.Well44497b;
> +import org.junit.Test;
>
> /**
> * Tests for {@link Network}.
> @@ -110,6 +107,7 @@ public class NetworkTest {
> }
>
> @Test
> + @Ignore // to be fixed, fails randomly
> public void testIterationOrder() {
> final FeatureInitializer[] initArray = { init };
> final Network net = new NeuronSquareMesh2D(4, false,
How does it fail? How often? On which archtecture?
Here, I couldn't get a single failure out of more than 20 runs.
Please provide a stack trace.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org