[GitHub] heyile commented on a change in pull request #1013: [SCB-1047]microservice.yaml service_description.version support form…

[GitBox <gi...@apache.org>]

heyile commented on a change in pull request #1013: [SCB-1047]microservice.yaml  service_description.version support form…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r236951927
 
 

 ##########
 File path: core/src/test/java/org/apache/servicecomb/core/TestConfig.java
 ##########
 @@ -53,7 +53,7 @@ public void testConstants() {
     Assert.assertEquals("rest", Const.RESTFUL);
     Assert.assertEquals("", Const.ANY_TRANSPORT);
     Assert.assertEquals("latest", Const.VERSION_RULE_LATEST);
-    Assert.assertEquals("0.0.0+", Const.DEFAULT_VERSION_RULE);
+    Assert.assertEquals("0.0.0.0+", Const.DEFAULT_VERSION_RULE);
 
 Review comment:
   As the const DefinitionConst#VERSION_RULE_ALL  is changed from "0.0.0+" to "0.0.0.0+",
   I change the value of Const.DEFAULT_VERSION_RULE. you means that I shouldn't change the const 
   DefinitionConst#VERSION_RULE_ALL ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services