You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/11/21 14:25:45 UTC

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

JiajunBernoulli commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1028107022


##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##########
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
     return mq.getExpressionLineage(rel.getInput(), outputExpression);
   }
 
+  /**
+   * Expression lineage from Snapshot.
+   */

Review Comment:
   Thanks for your review, I added javadoc.
   If you think that they is reasonable, I can add for other methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org