You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2023/01/20 11:48:31 UTC
[GitHub] [nifi] simonbence opened a new pull request, #6870: NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes
simonbence opened a new pull request, #6870:
URL: https://github.com/apache/nifi/pull/6870
Comparison of the flows is used for multiple purposes, including synchronisation and to inform users. In some cases we want to include actual changes of the embedded versioned flows, in other cases we do not want to. In order to server every purpose properly, some differentiation was introduced. This shoud fix the issue mentioned in NIFI-10973 and also keep the benefits of NIFI-10939.
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #6870: NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #6870:
URL: https://github.com/apache/nifi/pull/6870#issuecomment-1410642871
Jira for the associated issue is NIFI-11118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #6870: NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #6870:
URL: https://github.com/apache/nifi/pull/6870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #6870: NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #6870:
URL: https://github.com/apache/nifi/pull/6870#issuecomment-1410641258
Thanks @simonbence I think this does address the issues called out. In testing, I also encountered another issue that was related around changing the version of the child group. But it appears to have a different root cause and is less critical. I'm a +1 will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org