You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wangchen61698 (via GitHub)" <gi...@apache.org> on 2024/10/31 06:06:18 UTC
[PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]
wangchen61698 opened a new pull request, #13033:
URL: https://github.com/apache/nuttx/pull/13033
## Summary
1.set NET_TCP_NPOLLWAITERS default value from 1 to 2
2. add warning of different events having same event bit
## Impact
TCP number of poll to the same fd
## Testing
Manual verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #13033:
URL: https://github.com/apache/nuttx/pull/13033#discussion_r1722710401
##########
net/tcp/Kconfig:
##########
@@ -93,7 +93,7 @@ config NET_TCP_MAX_CONNS
config NET_TCP_NPOLLWAITERS
int "Number of TCP poll waiters"
- default 1
+ default 2
Review Comment:
why?
##########
net/tcp/tcp_netpoll.c:
##########
@@ -228,6 +228,12 @@ int tcp_pollsetup(FAR struct socket *psock, FAR struct pollfd *fds)
info = conn->pollinfo;
while (info->conn != NULL)
{
+ if ((fds->events & info->fds->events) != 0)
Review Comment:
DEBUGASSERT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]
Posted by "wangchen61698 (via GitHub)" <gi...@apache.org>.
wangchen61698 closed pull request #13033: tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit
URL: https://github.com/apache/nuttx/pull/13033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #13033:
URL: https://github.com/apache/nuttx/pull/13033#discussion_r1824127813
##########
net/tcp/Kconfig:
##########
@@ -93,7 +93,7 @@ config NET_TCP_MAX_CONNS
config NET_TCP_NPOLLWAITERS
int "Number of TCP poll waiters"
- default 1
+ default 2
Review Comment:
since most drivers set the default value to 2, it's better to align with others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tcp:set NET_TCP_NPOLLWAITERS default value to 2 & add warning of different events having same event bit [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13033:
URL: https://github.com/apache/nuttx/pull/13033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org