You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by YolandaMDavis <gi...@git.apache.org> on 2017/04/26 14:42:05 UTC

[GitHub] nifi pull request #1697: NIFI-3695 - added proxy dn flag to support providin...

GitHub user YolandaMDavis opened a pull request:

    https://github.com/apache/nifi/pull/1697

    NIFI-3695 - added proxy dn flag to support providing authorized usern\u2026

    \u2026ame for secured environments
    
    An updated version of documentation, with usage of the proxy flag is attached:
    [Admin Toolkit for NiFi.docx](https://github.com/apache/nifi/files/958755/Admin.Toolkit.for.NiFi.docx)
    
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YolandaMDavis/nifi NIFI-3695-proxy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1697
    
----
commit 41e7ee738448613b4c7f0e1ccadfe89741b6befb
Author: Yolanda M. Davis <yo...@gmail.com>
Date:   2017-04-26T14:22:18Z

    NIFI-3695 - added proxy dn flag to support providing authorized username for secured environments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1697: NIFI-3695 - added proxy dn flag to support providin...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1697#discussion_r113531250
  
    --- Diff: nifi-toolkit/nifi-toolkit-admin/src/main/groovy/org/apache/nifi/toolkit/admin/nodemanager/NodeManagerTool.groovy ---
    @@ -75,6 +77,7 @@ public class NodeManagerTool extends AbstractAdminTool {
             final Options options = new Options()
             options.addOption(Option.builder("h").longOpt(HELP_ARG).desc("Print help info").build())
             options.addOption(Option.builder("v").longOpt(VERBOSE_ARG).desc("Set mode to verbose (default is false)").build())
    +        options.addOption(Option.builder("p").longOpt(PROXY_DN).hasArg().desc("User or Proxy DN that has permission to send a notification").build())
    --- End diff --
    
    This description should indicate permissions to manage a node (not send a notification). Maybe we should elaborate that they will need read/write to 'access the controller' since that's how the UI presents it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    @YolandaMDavis I've added another commit [1] to print the response body when possible. If your happy with this addition, I'll amend it to your PR. Thanks.
    
    [1] https://github.com/mcgilman/nifi/commit/549a50fe22c930ab9c3203376da51b266f82585a


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by YolandaMDavis <gi...@git.apache.org>.

Github user YolandaMDavis commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    @mcgilman and @brosander appreciate if you could take a look at this enhancement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by YolandaMDavis <gi...@git.apache.org>.

Github user YolandaMDavis commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    Looks good to me, thanks @mcgilman !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by brosander <gi...@git.apache.org>.

Github user brosander commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    +1 looks good to me, thoughts @mcgilman ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by YolandaMDavis <gi...@git.apache.org>.

Github user YolandaMDavis commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    @mcgilman understood. It does makes sense to have more polite messaging given this new case. I'll work on those changes and update.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    +1 as well. Thanks @YolandaMDavis. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1697
  
    @YolandaMDavis Code changes look good. However, one thing I noticed is that the error provided when the specified proxied user lacks sufficient permissions could be made a little more user-friendly. Currently, a stack trace reports a 403 response code. It might make sense to consume the response body when the response code is 4xx or 5xx as it should contain the reason for the failure. This may provide more details for correcting the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---