[GitHub] [shardingsphere] terrymanu commented on pull request #9133: Order by primary keys ascending if simple query sql without order by clause for MySQL

[GitBox <gi...@apache.org>]

terrymanu commented on pull request #9133:
URL: https://github.com/apache/shardingsphere/pull/9133#issuecomment-766746069


   > Blocked on integration test MySQL-Proxy, aggregation function with `DISTINCT` test failed on `Placeholder` mode, e.g.
   > 
   > ```
   > Error case: assertExecuteQuery[proxy: db -> MySQL -> Placeholder -> SELECT SUM(DISTINCT order_id) s FROM t_order WHERE order_id < 1100]
   > 
   > java.lang.AssertionError: Size of actual result set is different with size of expected dat set rows.
   > Expected: is <1>
   >      but: was <0>
   > 
   > 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   > 	at org.junit.Assert.assertThat(Assert.java:956)
   > 	at org.apache.shardingsphere.test.integration.engine.it.dql.BaseDQLIT.assertRows(BaseDQLIT.java:102)
   > 	at org.apache.shardingsphere.test.integration.engine.it.dql.BaseDQLIT.assertResultSet(BaseDQLIT.java:71)
   > 	at org.apache.shardingsphere.test.integration.engine.it.dql.GeneralDQLIT.assertExecuteQueryForPreparedStatement(GeneralDQLIT.java:81)
   > 	at org.apache.shardingsphere.test.integration.engine.it.dql.GeneralDQLIT.assertExecuteQuery(GeneralDQLIT.java:62)
   > ```
   
   We can ignore that case because it is known case, I will fix it soon


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org