You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/29 00:52:08 UTC

[GitHub] lovelle opened a new pull request #3467: Fix thread safety violation on ConsumerImpl

lovelle opened a new pull request #3467: Fix thread safety violation on ConsumerImpl
URL: https://github.com/apache/pulsar/pull/3467
 
 
   ### Motivation
   
   Using analysing tools on pulsar-client reported the following fixed thread
   safety issues:
   
   ### Modifications
   
     - Fix `startMessageId`, `lastDequeuedMessage` and `lastMessageIdInBroker`
       fields reads are performed without synchronization and potentially races
       with write method, turned them into volatile.
     - Fields `possibleSendToDeadLetterTopicMessages`, `deadLetterPolicy` and
       `msgCrypto` can be turned into final to prevent being modified after
       construction.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services