[GitHub] [beam] chamikaramj commented on a diff in pull request #24783: BigQuery Storage Write API SchemaTransform wrapper for Python SDK

["chamikaramj (via GitHub)" <gi...@apache.org>]

chamikaramj commented on code in PR #24783:
URL: https://github.com/apache/beam/pull/24783#discussion_r1093555982


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -691,6 +692,12 @@ public static Row toBeamRow(Schema rowSchema, TableSchema bqSchema, TableRow jso
       if (JSON_VALUE_PARSERS.containsKey(fieldType.getTypeName())) {
         return JSON_VALUE_PARSERS.get(fieldType.getTypeName()).apply(jsonBQString);
       } else if (fieldType.isLogicalType(SqlTypes.DATETIME.getIdentifier())) {
+        // Handle if datetime value is in micros

Review Comment:
   Thanks for the explanation.
   
   Sorry, by log, I meant a comment :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org