[GitHub] [helix] jiajunwang edited a comment on pull request #1209: Add Github actions to enable auto CI tests.

[GitBox <gi...@apache.org>]

jiajunwang edited a comment on pull request #1209:
URL: https://github.com/apache/helix/pull/1209#issuecomment-668159602


   > @jiajunwang
   > 
   > Please follow the pull request description guidelines. It's recommended that we use the following keywords:
   > 
   > close
   > closes
   > closed
   > fix
   > fixes
   > fixed
   > resolve
   > resolves
   > resolved
   > 
   > when referring to the issue number. This is clearly outlined in our guidelines so that when the PR gets closed, the issue gets linked and closed as well. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
   
   I think you just modified the guideline. But I didn't get any notification or discussion invitation. So let's have a talk about it. Since I read through the provided link, the keywords are a tool so that you can auto-link the issue with some assumptions, which I'm not sure if they help. Although I do agree to use the linked Issue feature.
   
   1. 
   > Only **manually** linked pull requests can be manually unlinked. To unlink an issue that you linked using a keyword, you must edit the pull request description to remove the keyword.
   
   Editing pull request description to unlink seems a bad idea. It might be easier just to manually link.
   
   2.
   > You can also use closing keywords in a commit message. The issue will be closed when you merge the commit into the default branch, but the pull request that contains the commit will not be listed as a linked pull request.
    
   "default branch" means master, I think. So if we are using a dev branch, then the ticket will not be closed. Moreover, this implicit close might close some issues prematurely. So I won't recommend it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org