[jira] [Commented] (GEODE-9781) changed all geode-for-redis system properties to use RedisProperties

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439370#comment-17439370 ] 

ASF subversion and git services commented on GEODE-9781:
--------------------------------------------------------

Commit eea10019d65f68b9ab1303762f568844e1755bbd in geode's branch refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eea1001 ]

GEODE-9781: clean up radish sys props (#7080)

* all geode-for-redis system property names are now defined in RedisProperties.
A check is now done that the property name has the required prefix.
Warnings are logged if the system property is set to a value that will not be used.

* AuthIntegrationTest was trying to test with a non-default region name by setting
the system property "REDIS_REGION_NAME_PROPERTY" in setupCacheWithRegionName.
But this actually did nothing and geode still used the default. The problem was that
the constant was not actually the name of the system property. It now is and this test
should now be using a non-default region name.

* if the bucket sys prop is greater than 16384 it will now log a warning and use the default number of buckets. It used to fail the redis server startup.

* RedisPropertiesTest now uses RestoreSystemProperties rule

> changed all geode-for-redis system properties to use RedisProperties
> --------------------------------------------------------------------
>
>                 Key: GEODE-9781
>                 URL: https://issues.apache.org/jira/browse/GEODE-9781
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> geode-for-redis has system properties in it (like "redis.region.buckets" on RegionProvider) that should all be changed to use RedisProperties.
> Also RedisProperties should use a private final static for the common prefix "geode-for-redis-".
> Also RedisProperties should log a warning if it decides to ignore a property and go with a default because the value of the property is not valid (for example when it can't be parsed as an integer).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)