You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by alex1226 <gi...@git.apache.org> on 2017/02/28 07:58:30 UTC
[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...
GitHub user alex1226 opened a pull request:
https://github.com/apache/incubator-weex/pull/4
modified: WXRenderErrorCode.java WXSDKInstance.java
\u589e\u52a0h5\u9875\u9762\u68c0\u6d4b\u56de\u8c03\uff0c\u5c01\u88c5\u540e\u53f0weex\u548ch5\u9875\u9762\u65e0\u7f1d\u5207\u6362\u673a\u5236\uff0c\u4e3aweex\u9875\u9762\u66ff\u6362\u539f\u6709h5\u9875\u9762\u63d0\u4f9b\u70ed\u5907\u5207\u6362\u652f\u6301\u3002
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alex1226/incubator-weex 0.11-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit a1c0c508fbd6f2a1249ee7daa50a7f65349461aa
Author: alex1226 <66...@qq.com>
Date: 2017-02-28T07:50:55Z
modified: WXRenderErrorCode.java
modified: WXSDKInstance.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #4: modified: WXRenderErrorCode.java WXSDKInstance.java
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/4
@alex1226 please read the review result and make sure whether need edit,thanks very much. You can close this pr [here](https://github.com/apache/incubator-weex/pull/4)
---
[GitHub] incubator-weex issue #4: modified: WXRenderErrorCode.java WXSDKInstance.java
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/4
hello @alex1226 ,please read the review result and make sure whether need edit,thanks very much.
HI, dear @asfbot ,my honored that I execute community rule of weex now. Look forward to communicate with you,^_^
---
[GitHub] incubator-weex issue #4: modified: WXRenderErrorCode.java WXSDKInstance.java
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/4
@gurisxie the bots do can do that with github's API. Weex's bot do the same thing too.
---
[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/4#discussion_r104080145
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -447,7 +447,7 @@ public void setIWXUserTrackAdapter(IWXUserTrackAdapter adapter) {
* weexversion Weex version(like 1.0.0)
* appversion App version(like 1.0.0)
* devid Device id(like Aqh9z8dRJNBhmS9drLG5BKCmXhecHUXIZoXOctKwFebH)
- * sysversion Device system version(like 5.4.4\u30017.0.4, should be used with os)
+ * sysversion Device system version(like 5.4.4\ufffd?.0.4, should be used with os)
--- End diff --
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #4: modified: WXRenderErrorCode.java WXSDKInstance.java
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/4
@gurisxie 'asfbot‘ is bot... don't talk to it.
---
[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/4
---
[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/4#discussion_r104080132
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -467,7 +467,7 @@ public void render(String template, Map<String, Object> options, String jsonInit
* weexversion Weex version(like 1.0.0)
* appversion App version(like 1.0.0)
* devid Device id(like Aqh9z8dRJNBhmS9drLG5BKCmXhecHUXIZoXOctKwFebH)
- * sysversion Device system version(like 5.4.4\u30017.0.4, should be used with os)
+ * sysversion Device system version(like 5.4.4\ufffd?.0.4, should be used with os)
--- End diff --
what's this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #4: modified: WXRenderErrorCode.java WXSDKInstance.java
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/4
@sospartan I seen he reply the notice...
---
[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/4#discussion_r104080119
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -490,7 +490,7 @@ public void render(String template, Map<String, Object> options, String jsonInit
* weexversion Weex version(like 1.0.0)
* appversion App version(like 1.0.0)
* devid Device id(like Aqh9z8dRJNBhmS9drLG5BKCmXhecHUXIZoXOctKwFebH)
- * sysversion Device system version(like 5.4.4\u30017.0.4, should be used with os)
+ * sysversion Device system version(like 5.4.4\ufffd?.0.4, should be used with os)
--- End diff --
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---