You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/04/25 03:09:19 UTC
Review Request: Fixes a bug when a coordinator tried to fill positions that
other replicas had already learned were truncated (note that the test added
failed before the rest of the patch got applied).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4867/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Summary
-------
See summary.
Diffs
-----
src/log/coordinator.hpp 16b15f0
src/log/coordinator.cpp 25127ee
src/log/log.hpp ebdb0b8
src/log/replica.cpp 8d03304
src/tests/log_tests.cpp 97712dd
Diff: https://reviews.apache.org/r/4867/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Fixes a bug when a coordinator tried to fill positions
that other replicas had already learned were truncated (note that the test
added failed before the rest of the patch got applied).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-04-25 03:31:35, John Sirois wrote:
> > The 2 key comments are very clear here. Thanks.
No worries, submitting.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4867/#review7207
-----------------------------------------------------------
On 2012-04-25 01:09:19, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4867/
> -----------------------------------------------------------
>
> (Updated 2012-04-25 01:09:19)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 16b15f0
> src/log/coordinator.cpp 25127ee
> src/log/log.hpp ebdb0b8
> src/log/replica.cpp 8d03304
> src/tests/log_tests.cpp 97712dd
>
> Diff: https://reviews.apache.org/r/4867/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes a bug when a coordinator tried to fill positions
that other replicas had already learned were truncated (note that the test
added failed before the rest of the patch got applied).
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4867/#review7207
-----------------------------------------------------------
Ship it!
The 2 key comments are very clear here. Thanks.
- John
On 2012-04-25 01:09:19, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4867/
> -----------------------------------------------------------
>
> (Updated 2012-04-25 01:09:19)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 16b15f0
> src/log/coordinator.cpp 25127ee
> src/log/log.hpp ebdb0b8
> src/log/replica.cpp 8d03304
> src/tests/log_tests.cpp 97712dd
>
> Diff: https://reviews.apache.org/r/4867/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>