You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2011/06/17 19:19:07 UTC
Re: svn commit: r1136946 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c
On Fri, Jun 17, 2011 at 1:15 PM, <ji...@apache.org> wrote:
> Author: jim
> Date: Fri Jun 17 17:15:54 2011
> New Revision: 1136946
>
> URL: http://svn.apache.org/viewvc?rev=1136946&view=rev
> Log:
> Revert "fix unexpected enum operation"
Why?
>
> This reverts commit d407a566ab24e576a3f143f5c27b2ccf90f5d8da.
That's useless. What is the svn revision?
> Modified:
> httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>
> Modified: httpd/httpd/trunk/modules/mappers/mod_rewrite.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrite.c?rev=1136946&r1=1136945&r2=1136946&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/mappers/mod_rewrite.c (original)
> +++ httpd/httpd/trunk/modules/mappers/mod_rewrite.c Fri Jun 17 17:15:54 2011
> @@ -3317,7 +3317,7 @@ static const char *cmd_rewritecond(cmd_p
> newcond->pskip = a2 - newcond->pattern;
> newcond->pattern += newcond->pskip;
>
> - if (newcond->ptype == CONDPAT_REGEX) {
> + if (!newcond->ptype) {
> regexp = ap_pregcomp(cmd->pool, a2,
> AP_REG_EXTENDED | ((newcond->flags & CONDFLAG_NOCASE)
> ? AP_REG_ICASE : 0));
>
>
>
--
Born in Roswell... married an alien...
Re: svn commit: r1136946 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Fri, Jun 17, 2011 at 2:15 PM, Jim Jagielski <ji...@jagunet.com> wrote:
> Sorry... something with git-svn did this.
way weird
I guessed it was git, but .... wow
>
> It's just been reversed.
>
> On Jun 17, 2011, at 1:19 PM, Jeff Trawick wrote:
>
>> On Fri, Jun 17, 2011 at 1:15 PM, <ji...@apache.org> wrote:
>>> Author: jim
>>> Date: Fri Jun 17 17:15:54 2011
>>> New Revision: 1136946
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1136946&view=rev
>>> Log:
>>> Revert "fix unexpected enum operation"
>>
>> Why?
>>
>>>
>>> This reverts commit d407a566ab24e576a3f143f5c27b2ccf90f5d8da.
>>
>> That's useless. What is the svn revision?
>>
>>
>>> Modified:
>>> httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>>>
>>> Modified: httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrite.c?rev=1136946&r1=1136945&r2=1136946&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/mappers/mod_rewrite.c (original)
>>> +++ httpd/httpd/trunk/modules/mappers/mod_rewrite.c Fri Jun 17 17:15:54 2011
>>> @@ -3317,7 +3317,7 @@ static const char *cmd_rewritecond(cmd_p
>>> newcond->pskip = a2 - newcond->pattern;
>>> newcond->pattern += newcond->pskip;
>>>
>>> - if (newcond->ptype == CONDPAT_REGEX) {
>>> + if (!newcond->ptype) {
>>> regexp = ap_pregcomp(cmd->pool, a2,
>>> AP_REG_EXTENDED | ((newcond->flags & CONDFLAG_NOCASE)
>>> ? AP_REG_ICASE : 0));
>>>
>>>
>>>
>>
>>
>>
>> --
>> Born in Roswell... married an alien...
>>
>
>
--
Born in Roswell... married an alien...
Re: svn commit: r1136946 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
Sorry... something with git-svn did this.
It's just been reversed.
On Jun 17, 2011, at 1:19 PM, Jeff Trawick wrote:
> On Fri, Jun 17, 2011 at 1:15 PM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Fri Jun 17 17:15:54 2011
>> New Revision: 1136946
>>
>> URL: http://svn.apache.org/viewvc?rev=1136946&view=rev
>> Log:
>> Revert "fix unexpected enum operation"
>
> Why?
>
>>
>> This reverts commit d407a566ab24e576a3f143f5c27b2ccf90f5d8da.
>
> That's useless. What is the svn revision?
>
>
>> Modified:
>> httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>>
>> Modified: httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrite.c?rev=1136946&r1=1136945&r2=1136946&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/mappers/mod_rewrite.c (original)
>> +++ httpd/httpd/trunk/modules/mappers/mod_rewrite.c Fri Jun 17 17:15:54 2011
>> @@ -3317,7 +3317,7 @@ static const char *cmd_rewritecond(cmd_p
>> newcond->pskip = a2 - newcond->pattern;
>> newcond->pattern += newcond->pskip;
>>
>> - if (newcond->ptype == CONDPAT_REGEX) {
>> + if (!newcond->ptype) {
>> regexp = ap_pregcomp(cmd->pool, a2,
>> AP_REG_EXTENDED | ((newcond->flags & CONDFLAG_NOCASE)
>> ? AP_REG_ICASE : 0));
>>
>>
>>
>
>
>
> --
> Born in Roswell... married an alien...
>