You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/12/18 01:54:00 UTC

[jira] Created: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Hadoop integration tests fail due to WHIRR-160 changes
------------------------------------------------------

                 Key: WHIRR-165
                 URL: https://issues.apache.org/jira/browse/WHIRR-165
             Project: Whirr
          Issue Type: Bug
          Components: service/hadoop
            Reporter: Tom White
            Assignee: Tom White
            Priority: Critical
             Fix For: 0.3.0


The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated WHIRR-165:
----------------------------

    Attachment: WHIRR-165.patch

This patch is the minimal fix so that the tests pass - the fuller fix for removing the dependency on the default keypair is covered by WHIRR-164.

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated WHIRR-165:
----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this.

I verified that with this patch the Hadoop integration test passes on the machine that it was failing on (the one with pickier SSH settings). The case where there is no default keypair is covered by WHIRR-164.

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972849#action_12972849 ] 

Andrei Savu commented on WHIRR-165:
-----------------------------------

I'm planning to provide a patch for WHIRR-164 as soon as possible. 

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972851#action_12972851 ] 

Andrei Savu commented on WHIRR-165:
-----------------------------------

{code}
    File identity;
    if (clusterSpec.getPrivateKey().getRawContent() instanceof File) {
      identity = File.class.cast(clusterSpec.getPrivateKey().getRawContent());
    } else {
      identity = File.createTempFile("hadoop", "key");
      identity.deleteOnExit();
      Files.write(ByteStreams.toByteArray(clusterSpec.getPrivateKey().getInput()), identity);
    }
{code}


HadoopProxy should not fail  if the key is not  stored as a FilePayload. It seems like it creates a temporary identity file when running ssh. 

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973482#action_12973482 ] 

Tom White commented on WHIRR-165:
---------------------------------

E.g. on one machine I get

{noformat}
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@         WARNING: UNPROTECTED PRIVATE KEY FILE!          @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
Permissions 0664 for '/tmp/hadoop2803372008213524011key' are too open.
It is recommended that your private key files are NOT accessible by others.
This private key will be ignored.
bad permissions: ignore key: /tmp/hadoop2803372008213524011key
Permission denied (publickey)
{noformat}

This fix is just to make sure that a pre-existing private key is used. The permissions can be fixed in WHIRR-164.

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972848#action_12972848 ] 

Andrei Savu commented on WHIRR-165:
-----------------------------------

I have been unable to replicate this issue. The Hadoop integration tests pass for me if I don't remove the key pair from ~/.ssh. If I remove the default key pair the integration tests fail with and without the patch.

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973409#action_12973409 ] 

Tom White commented on WHIRR-165:
---------------------------------

> HadoopProxy should not fail if the key is not stored as a FilePayload.

The problem is that the permissions on the generated private key file (and enclosing directory) are not strict enough for some SSH clients.

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-165) Hadoop integration tests fail due to WHIRR-160 changes

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated WHIRR-165:
----------------------------

    Status: Patch Available  (was: Open)

> Hadoop integration tests fail due to WHIRR-160 changes
> ------------------------------------------------------
>
>                 Key: WHIRR-165
>                 URL: https://issues.apache.org/jira/browse/WHIRR-165
>             Project: Whirr
>          Issue Type: Bug
>          Components: service/hadoop
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-165.patch
>
>
> The problem (described in WHIRR-164) is that keys are never stored as FilePayloads and the Hadoop proxy fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.