You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/28 18:09:35 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28630: Improve "other" test category selection
potiuk opened a new pull request, #28630:
URL: https://github.com/apache/airflow/pull/28630
The "Other" test category automatically selects all tests that are not included in any of the regular categories. That is to make sure that we do not forget to add any directory that has been added. However this led to a long directory selection for "Other" category including system tests that have been automatically added there. However those tests are always skipped in regular tests and collecting those tests during "Other" execution is not needed and slows it down.
Similarly System tests changes were treated as "Other change" for incoming PRs. This means that any change to system tests would trigger "all tests" rather than selective subset of those - the same as any core change.
However System tests are also part of the documentation, so any change in system tests should trigger docs
builds.
This change improves it in a few ways:
* Other tests now do not include "System Tests" - they are treated the same way as other test categories (but not included in test category selection for now - until we get a good way of breeze-integration for System Tests
* They are also excluded from treating them as "other" change when considering which tests to run. Changes to system tests will not trigger "all" tests, just those that accompanying changes would trigger.
* The changes to system tests only, however, triggers docs build because those are triggered by any source change.a
* The __pycache__ directories are removed from the list of "Other" packages to run.
* In order to make sure system tests are pytest-collectable, we perform pytest collection for all tests right after downloading the CI images and verifying them. This makes sure that the tests are collectible before we even attempt to run them - this way we avoid unnecessary machine spin-up and breze installation for the multiple jobs that run the tests. This slows down feedback time a litle, but should increase overall robustness of the test suite.
* an old, unused nosetest collection script doing the same in the past has been removed (it was discovered during implementation)
Noticed in: #28319
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28630: Improve "other" test category selection
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28630:
URL: https://github.com/apache/airflow/pull/28630#issuecomment-1366832706
The list of "other" folders now is far shorter:
Comparing to
https://github.com/apache/airflow/pull/28319#issuecomment-1349010577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28630: Improve "other" test category selection
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28630:
URL: https://github.com/apache/airflow/pull/28630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org