You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/25 05:37:27 UTC
[GitHub] [spark] TJX2014 opened a new pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
TJX2014 opened a new pull request #28926:
URL: https://github.com/apache/spark/pull/28926
### What changes were proposed in this pull request?
Add a unit test.
Bug fix in `org.apache.spark.sql.catalyst.expressions.Sequence.TemporalSequenceImpl`
Add `sequence step must be a day interval if start and end values are dates` constraint.
Follow: [https://github.com/apache/spark/pull/28856](url)
### Why are the changes needed?
Spark sequence doesn't handle date increments that cross DST
### Does this PR introduce _any_ user-facing change?
Before the PR, people will not get a correct result：
`set spark.sql.session.timeZone` to `Asia/Shanghai, America/Chicago, GMT`,
Before execute
`sql("select sequence(cast('2011-03-01' as date), cast('2011-05-01' as date), interval 1 month)").show(false)`, People will get `[2011-03-01, 2011-04-01, 2011-05-01]`, **`[2011-03-01, 2011-03-28, 2011-04-28]`**, `[2011-03-01, 2011-04-01, 2011-05-01]`.
After the PR, sequence date conversion is corrected：
We will get `[2011-03-01, 2011-04-01, 2011-05-01]` from the former three conditions.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649230871
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652963611
**[Test build #124896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124896/testReport)** for PR 28926 at commit [`fe6a32d`](https://github.com/apache/spark/commit/fe6a32daea5555bc287d1b0db5912fae716f4bbe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448035198
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -1854,4 +1854,18 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Literal(stringToInterval("interval 1 year"))),
Seq(Date.valueOf("2018-01-01")))
}
+
+ test("SPARK-32133: Sequence step must be a day interval " +
Review comment:
Thanks, I have moved the negative test to `Sequence of dates` and ` point to the JIRA number in the code comment.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449940558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
@dongjoon-hyun Sorry, the correct PR is [SPARK-31982](https://github.com/apache/spark/pull/28856), this PR is forbid step and the other is cross the timezone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655881031
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655210448
**[Test build #125242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125242/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160661
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653987074
> Thank you for update, @TJX2014 . Could you answer the following comment?
>
> * https://github.com/apache/spark/pull/28926/files#r449932227
@dongjoon-hyun Thank you for your attention, this seems a mistake reference:
[https://github.com/apache/spark/pull/28926/files#r449940558](url),
Besides, QA failed UT seems strange, it seems no reverent to this PR, could you please help me check test results ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655677079
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125358/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655881031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652294418
**[Test build #5049 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5049/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652619202
**[Test build #124791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124791/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653226005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656305934
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654900292
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655973217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654302524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r446909869
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
we can remove this branch now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655360645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447316906
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
Seems we need the `require` check in eval, and I remove `SPARK-32198` branch code from this PR, is it ok ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r445317708
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
Review comment:
Add scale constraint here to `DateType`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655677066
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653932336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654925279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125231/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655487015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448960031
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2674,11 +2679,24 @@ object Sequence {
|${genSequenceLengthCode(ctx, startMicros, stopMicros, intervalInMicros, arrLength)}
""".stripMargin
+ val check = if (scale == MICROS_PER_DAY) {
+ s"""
+ if ($stepMonths == 0 && $stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
nit: for generated code, we shall use the multiline string syntax:
```
s"""
|if ...
|""".stripMargin
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656271015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653954927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655486625
**[Test build #125358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125358/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656228068
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653932336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655211390
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125242/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656270197
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652620182
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124791/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654282769
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449940558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
@dongjoon-hyun Sorry, the correct PR is [https://github.com/apache/spark/pull/28856](), this PR is forbid step and the other is cross the timezone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656273756
**[Test build #125506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125506/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652439565
**[Test build #5049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5049/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655972022
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656749065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652469929
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655363819
**[Test build #125333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125333/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656184055
**[Test build #125487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125487/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652239139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654299782
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656949064
Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656749065
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450009133
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
I asked to throw an exception explicitly, to match the codegen code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653954793
**[Test build #124984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124984/testReport)** for PR 28926 at commit [`2bd2d0b`](https://github.com/apache/spark/commit/2bd2d0b1011fcc97e003ac4cd162255f608329ed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656182156
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655816211
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655817015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653987074
> Thank you for update, @TJX2014 . Could you answer the following comment?
>
> * https://github.com/apache/spark/pull/28926/files#r449932227
@dongjoon-hyun Thank you for your attention, this seems a mistake reference:
[https://github.com/apache/spark/pull/28926/files#r449940558](https://github.com/apache/spark/pull/28926/files#r449940558),
Besides, QA failed UT seems strange, it seems no reverent to this patch, could you please help me check test results ?
From QA commend:
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInBinarySuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 4 秒 | 1
-- | -- | --
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInHttpSuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 6 秒 | 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655211383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655027169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652269867
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449997164
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
@TJX2014 can we just use `require` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447317750
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2623,8 +2628,16 @@ object Sequence {
// about a month length in days and a day length in microseconds
val intervalStepInMicros =
stepMicros + stepMonths * microsPerMonth + stepDays * microsPerDay
- val startMicros: Long = num.toLong(start) * scale
- val stopMicros: Long = num.toLong(stop) * scale
+
+ // Date to timestamp is not equal from GMT and Chicago timezones
Review comment:
@cloud-fan Thanks, I have followed the suggestion and make a new jira ticket for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656749076
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125577/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655024226
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447466465
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -1854,4 +1854,16 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Literal(stringToInterval("interval 1 year"))),
Seq(Date.valueOf("2018-01-01")))
}
+
+ test("SPARK-32133: Sequence step must be a day interval " +
+ "if start and end values are dates") {
+ val e = intercept[Exception](
+ checkEvaluation(Sequence(
Review comment:
we should use `checkExceptionInExpression` for error tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649231790
https://github.com/apache/spark/pull/28856
cc @cloud-fan @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652620168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654006568
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654904812
**[Test build #125231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125231/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449932411
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
Also, I have the same question like @cloud-fan .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652254298
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655372202
**[Test build #125333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125333/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654141149
**[Test build #125059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125059/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450119402
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
+ "sequence step must be a day interval if start and end values are dates")
+ }
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655880534
**[Test build #125419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125419/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652964468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655360645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653987074
> Thank you for update, @TJX2014 . Could you answer the following comment?
>
> * https://github.com/apache/spark/pull/28926/files#r449932227
@dongjoon-hyun Thank you for your attention, this seems a mistake reference:
[https://github.com/apache/spark/pull/28926/files#r449940558](url),
Besides, QA failed UT seems strange, it seems no reverent to this patch, could you please help me check test results ?
From QA commend:
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInBinarySuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 4 秒 | 1
-- | -- | --
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInHttpSuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 6 秒 | 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654282769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656746305
**[Test build #125577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125577/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654006571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124943/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655211383
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652241835
**[Test build #124752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124752/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655972624
**[Test build #125454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125454/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654141703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655363819
**[Test build #125333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125333/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652473058
**[Test build #124791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124791/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649230871
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652254298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652620168
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653954927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654316624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652238618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655817015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652963611
**[Test build #124896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124896/testReport)** for PR 28926 at commit [`fe6a32d`](https://github.com/apache/spark/commit/fe6a32daea5555bc287d1b0db5912fae716f4bbe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654141149
**[Test build #125059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125059/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654302057
**[Test build #125097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125097/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656273756
**[Test build #125506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125506/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653200626
**[Test build #124896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124896/testReport)** for PR 28926 at commit [`fe6a32d`](https://github.com/apache/spark/commit/fe6a32daea5555bc287d1b0db5912fae716f4bbe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653954793
**[Test build #124984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124984/testReport)** for PR 28926 at commit [`2bd2d0b`](https://github.com/apache/spark/commit/2bd2d0b1011fcc97e003ac4cd162255f608329ed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656228095
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125487/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447536856
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -1854,4 +1854,18 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Literal(stringToInterval("interval 1 year"))),
Seq(Date.valueOf("2018-01-01")))
}
+
+ test("SPARK-32133: Sequence step must be a day interval " +
+ "if start and end values are dates") {
+ checkExceptionInExpression[IllegalArgumentException](Sequence(
+ Cast(Literal("2011-03-01"), DateType),
+ Cast(Literal("2011-04-01"), DateType),
+ Option(Literal(stringToInterval("interval 1 hour")))), null,
+ "sequence step must be a day interval if start and end values are dates")
+ checkEvaluation(Sequence(
+ Cast(Literal("2011-03-01"), DateType),
+ Cast(Literal("2011-03-02"), DateType),
+ Option(Literal(stringToInterval("interval 1 day")))),
+ Seq(Date.valueOf("2011-03-01"), Date.valueOf("2011-03-02")))
Review comment:
@cloud-fan Thank you for your suggestion, I have done. Besides, I add a positive test case, hope this could be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655372253
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125333/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653972903
**[Test build #124984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124984/testReport)** for PR 28926 at commit [`2bd2d0b`](https://github.com/apache/spark/commit/2bd2d0b1011fcc97e003ac4cd162255f608329ed).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654141703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655359555
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656271015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649231790
Follow: https://github.com/apache/spark/pull/28856
cc @cloud-fan @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656228068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655816718
**[Test build #125419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125419/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653987074
> Thank you for update, @TJX2014 . Could you answer the following comment?
>
> * https://github.com/apache/spark/pull/28926/files#r449932227
@dongjoon-hyun Thank you for your attention, this seems a mistake reference:
[https://github.com/apache/spark/pull/28926/files#r449940558](url),
Besides, QA failed UT seems strange, it seems no reverent to this patch, could you please help me check test results ?
`
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInBinarySuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 4 秒 | 1
-- | -- | --
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInHttpSuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 6 秒 | 1
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653954804
Thank you for update, @TJX2014 . Could you answer the following comment?
- https://github.com/apache/spark/pull/28926/files#r449932227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448695070
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if(scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
Review comment:
nit. `if(` -> `if (`?
Interesting. I thought we have a style checker for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447464759
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2679,6 +2682,11 @@ object Sequence {
|final int $stepDays = $step.days;
|final long $stepMicros = $step.microseconds;
|
+ |if (${scale}L == ${MICROS_PER_DAY}L && $stepMonths == 0 && $stepDays == 0) {
Review comment:
the `scale` is known before generating the code. We can do better
```
val check = if (scale == MICROS_PER_DAY) {
s"""
if ($stepMonths == 0 && $stepDays == 0) ...
"""
} else {
""
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655973217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652473848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29402/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448695070
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if(scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
Review comment:
nit. `if(` -> `if (`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655372242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160676
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125454/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652281316
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655675946
**[Test build #125358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125358/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656528391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656527829
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655881034
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125419/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654925265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656530852
**[Test build #125577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125577/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652272736
**[Test build #124759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124759/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450118579
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2618,9 +2618,11 @@ object Sequence {
}
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
+ // Adding pure days to date start/end
backedSequenceImpl.eval(start, stop, fromLong(stepDays))
} else if (stepMonths == 0 && stepDays == 0 && scale == 1) {
+ // Adding pure microseconds to timestamp start/end
Review comment:
@cloud-fan Thanks, I add more comments for pure days and months branch, the former exception check seems the exception content has enough informs, and the last branch seems has detail content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654925265
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654302057
**[Test build #125097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125097/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652964468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656184745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449456120
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2674,11 +2679,24 @@ object Sequence {
|${genSequenceLengthCode(ctx, startMicros, stopMicros, intervalInMicros, arrLength)}
""".stripMargin
+ val check = if (scale == MICROS_PER_DAY) {
+ s"""
+ |if ($stepMonths == 0 && $stepDays == 0) {
+ | throw new IllegalArgumentException(
+ | "sequence step must be a day interval if start and end values are dates");
+ |}
+ """.stripMargin
+ } else {
+ ""
+ }
+
s"""
|final int $stepMonths = $step.months;
|final int $stepDays = $step.days;
|final long $stepMicros = $step.microseconds;
|
+ | $check
Review comment:
nit: no need to add 2 space indentation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450009801
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
+ "sequence step must be a day interval if start and end values are dates")
+ }
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
We can probably add comments for each branch. For example, this branch is for adding days to date start/end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654282779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125059/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653973090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653973098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124984/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448960031
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2674,11 +2679,24 @@ object Sequence {
|${genSequenceLengthCode(ctx, startMicros, stopMicros, intervalInMicros, arrLength)}
""".stripMargin
+ val check = if (scale == MICROS_PER_DAY) {
+ s"""
+ if ($stepMonths == 0 && $stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
nit: for generated code, we shal use the multiline string syntax:
```
s"""
|if ...
|""".stripMargin
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649230613
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448695070
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if(scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
Review comment:
nit. `if(` -> `if (`?
- https://github.com/databricks/scala-style-guide/blame/master/README.md#L323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653226005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654905827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652281316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656184745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653931909
**[Test build #124943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124943/testReport)** for PR 28926 at commit [`b863eef`](https://github.com/apache/spark/commit/b863eef24abd448e517e22b1a7545d6660041e03).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656158035
**[Test build #125454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125454/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655972624
**[Test build #125454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125454/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655485263
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653226388
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652281284
**[Test build #124759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124759/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655026521
**[Test build #125242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125242/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655486625
**[Test build #125358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125358/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649231790
#https://github.com/apache/spark/pull/28856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655027169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652273371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652254306
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124752/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655372242
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654316638
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125097/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r448696068
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2674,11 +2679,24 @@ object Sequence {
|${genSequenceLengthCode(ctx, startMicros, stopMicros, intervalInMicros, arrLength)}
""".stripMargin
+ val check = if (scale == MICROS_PER_DAY) {
+ s"""
+ if ($stepMonths == 0 && $stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656530852
**[Test build #125577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125577/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652273371
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652473829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654006568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656305934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450010508
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,11 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ if (scale == MICROS_PER_DAY && stepMonths == 0 && stepDays == 0) {
+ throw new IllegalArgumentException(
Review comment:
I am both ok, thank you for your attention. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654302524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28926:
URL: https://github.com/apache/spark/pull/28926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649230613
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654316624
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655026521
**[Test build #125242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125242/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652254228
**[Test build #124752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124752/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449925822
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2674,11 +2679,24 @@ object Sequence {
|${genSequenceLengthCode(ctx, startMicros, stopMicros, intervalInMicros, arrLength)}
""".stripMargin
+ val check = if (scale == MICROS_PER_DAY) {
+ s"""
+ |if ($stepMonths == 0 && $stepDays == 0) {
+ | throw new IllegalArgumentException(
+ | "sequence step must be a day interval if start and end values are dates");
Review comment:
Sorry for nit-picking again. But line 2685 has 3 spaces instead of 2 spaces and line 2686 has 5 spaces instead of 4 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653226388
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656305597
**[Test build #125506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125506/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656305942
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125506/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653987074
> Thank you for update, @TJX2014 . Could you answer the following comment?
>
> * https://github.com/apache/spark/pull/28926/files#r449932227
@dongjoon-hyun Thank you for your attention, this seems a mistake reference:
[https://github.com/apache/spark/pull/28926/files#r449940558](url),
Besides, QA failed UT seems strange, it seems no reverent to this PR, could you please help me check test results ?
`
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInBinarySuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 4 秒 | 1
-- | -- | --
org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInHttpSuite.(It is not a test it is a sbt.testing.SuiteSelector) | 2 分 6 秒 | 1
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r447465413
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2612,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
Review comment:
let's use
```
if (...) throw new IllegalArgumentException
```
to be more consistent with the codegen version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654904812
**[Test build #125231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125231/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654280343
**[Test build #125059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125059/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r449932227
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2612,6 +2614,9 @@ object Sequence {
val stepDays = step.days
val stepMicros = step.microseconds
+ require(scale != MICROS_PER_DAY || stepMonths != 0 || stepDays != 0,
+ "sequence step must be a day interval if start and end values are dates")
+
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
Review comment:
@TJX2014 . What is SPARK-32198? It's not created yet.
> I remove SPARK-32198 branch code from this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 commented on a change in pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r450118579
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2618,9 +2618,11 @@ object Sequence {
}
if (stepMonths == 0 && stepMicros == 0 && scale == MICROS_PER_DAY) {
+ // Adding pure days to date start/end
backedSequenceImpl.eval(start, stop, fromLong(stepDays))
} else if (stepMonths == 0 && stepDays == 0 && scale == 1) {
+ // Adding pure microseconds to timestamp start/end
Review comment:
@cloud-fan Thanks, I add more comments for pure days and months branch, the former exception check seems the exception content has enough informs, and the last branch seems have detail content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655677066
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653973090
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652473058
**[Test build #124791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124791/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656528391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652272736
**[Test build #124759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124759/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28926:
URL: https://github.com/apache/spark/pull/28926#discussion_r446910368
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2623,8 +2628,16 @@ object Sequence {
// about a month length in days and a day length in microseconds
val intervalStepInMicros =
stepMicros + stepMonths * microsPerMonth + stepDays * microsPerDay
- val startMicros: Long = num.toLong(start) * scale
- val stopMicros: Long = num.toLong(stop) * scale
+
+ // Date to timestamp is not equal from GMT and Chicago timezones
Review comment:
can we exclude these changes and make this PR smaller to only focus on "forbid time field steps for date start/end"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TJX2014 edited a comment on pull request #28926: [SPARK-31982][SQL][FOLLOWUP]Function sequence doesn't handle date increments that cross DST
Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-649231790
https://github.com/apache/spark/pull/28856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654925181
**[Test build #125231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125231/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655487015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654905827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655816718
**[Test build #125419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125419/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-654316537
**[Test build #125097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125097/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.com/apache/spark/commit/8c4ffaa75552987d9303b2ee3186fdc8abf14c68).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652239139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-652241835
**[Test build #124752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124752/testReport)** for PR 28926 at commit [`24384c9`](https://github.com/apache/spark/commit/24384c9805aff717629a60060775322e6b153c71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-653427435
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org