[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9613: fix: broken IS NULL and IS NOT NULL operator

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #9613:
URL: https://github.com/apache/incubator-superset/pull/9613#discussion_r413002288



##########
File path: superset/connectors/sqla/models.py
##########
@@ -883,9 +883,9 @@ def get_sqla_query(  # sqla
                     elif op == utils.FilterOperationType.LIKE.value:
                         where_clause_and.append(col_obj.get_sqla_col().like(eq))
                     elif op == utils.FilterOperationType.IS_NULL.value:
-                        where_clause_and.append(col_obj.get_sqla_col() is None)
+                        where_clause_and.append(col_obj.get_sqla_col() == None)

Review comment:
       `is None` and `is not None` is preferred 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org