You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2016/01/09 00:38:08 UTC

[GitHub] storm pull request: [STORM-1206] Reduce logviewer memory usage thr...

GitHub user zhuoliu opened a pull request:

    https://github.com/apache/storm/pull/999

    [STORM-1206] Reduce logviewer memory usage through directory stream

    Using DirectoryStream to replace File.listFiles will save logviewer memory usage since it does not require loading all files' metadata into memory. This avoids potential memory usage problem in extreme case (e.g., you have millions of small files in your log directory).
    Also, a multi-phase PQ-based sorting and cleaning scheme is introduced in DirectoryCleaner for replacing the global in-memory sorting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhuoliu/storm 1206

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/999.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #999
    
----
commit 7cc1d05a6c4db0610baccbc7870544d9ea8258af
Author: zhuol <zh...@yahoo-inc.com>
Date:   2016-01-08T23:32:50Z

    [STORM-1206] Reduce logviewer memory usage through directory stream

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1206] Reduce logviewer memory usage thr...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/999#issuecomment-170581986
  
    These changes look rather large, but the tests pass and the code looks good.  I assume you have done some manual testing so I am +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1206] Reduce logviewer memory usage thr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/999


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---