You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Otis Gospodnetic <ot...@yahoo.com> on 2002/09/19 20:48:50 UTC
RE: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index F ieldsReader.java
To make this type of stuff clear in the future I think we should put a
note about it on the site somewhere (some "developers's corner" area).
In it we can say: follow Sun's Java style standards, except for blah,
blah blah.
Other Jakarta projects have the same thing.
Otis
--- Scott Ganyo <sc...@eTapestry.com> wrote:
> Ack. Well, that is Sun's idea of "standard Java style," which I
> rigorously
> disagree with. Also, given the amount of Java code that doesn't
> follow that
> style, I would disagree that it is at all "standard." Remember that
> package
> names beginning with all caps like "COM and EDU" used to be Sun's
> "standard"
> style, too, until they got the hint.
>
> Nevertheless, I'm willing to accept that you have defined it as
> "Lucene
> standard style" and I do abide by it when developing Lucene...
>
> Scott
>
> (P.S. Sorry, I realize this is holy-war territory, but I couldn't
> resist.)
>
> > -----Original Message-----
> > From: Doug Cutting [mailto:cutting@lucene.com]
> > Sent: Thursday, September 19, 2002 12:12 PM
> > To: Lucene Developers List
> > Subject: Re: cvs commit:
> > jakarta-lucene/src/java/org/apache/lucene/index
> > FieldsReader.java
> >
> >
> > Otis,
> >
> > I really appreciate all of the work you do on Lucene.
> > However sometimes
> > I have to disagree.
> >
> > otis@apache.org wrote:
> > > - Added FIXME/TODO tags about things to document.
> >
> > While documentation in a package private class is nice, it is not
> an
> > absolute requirement. So I don't think this warrants a FIXME
> comment.
> >
> > > -final class FieldsReader {
> > > +final class FieldsReader
> > > +{
> >
> > You also re-indented the code and your indentation style violates
> > standard Java style. In Java, opening braces go with the
> > previous line,
> > not on a line of their own:
> >
> >
> >
>
http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#15395
> >
> > Doug
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index F ieldsReader.java
Posted by Clemens Marschner <cm...@lanlab.de>.
I would favor again a configuration file for the JRefactory pretty printer
that contains those standards. That pp is available as a cmd line tool and
as an integration with a variety of IDEs, and it guarantees standard
conformance.
Clemens
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index F ieldsReader.java
Posted by Otis Gospodnetic <ot...@yahoo.com>.
Heh. I know, I have (not for Lucene). However, you still need
something firmer in order to be able to point people to, and say "see,
it's defined here, you read it, agred with it, so please follow it".
Anyhow, back to work.
Otis
--- petite_abeille <pe...@mac.com> wrote:
>
> On Thursday, Sep 19, 2002, at 20:48 Europe/Zurich, Otis Gospodnetic
> wrote:
>
> > Other Jakarta projects have the same thing.
>
> Don't waste your time with such triviality... Simply integrate
> checkstyle in your build process.
>
> http://checkstyle.sourceforge.net/
>
> "Checkstyle is a development tool to help programmers write Java code
>
> that adheres to a coding standard. It automates the process of
> checking
> Java code to spare humans of this boring (but important) task. This
> makes it ideal for projects that want to enforce a coding standard.
>
> By default it supports the Sun Code Conventions. However, Checkstyle
> is
> highly configurable."
>
> PA.
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index F ieldsReader.java
Posted by petite_abeille <pe...@mac.com>.
On Thursday, Sep 19, 2002, at 20:48 Europe/Zurich, Otis Gospodnetic
wrote:
> Other Jakarta projects have the same thing.
Don't waste your time with such triviality... Simply integrate
checkstyle in your build process.
http://checkstyle.sourceforge.net/
"Checkstyle is a development tool to help programmers write Java code
that adheres to a coding standard. It automates the process of checking
Java code to spare humans of this boring (but important) task. This
makes it ideal for projects that want to enforce a coding standard.
By default it supports the Sun Code Conventions. However, Checkstyle is
highly configurable."
PA.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>