You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/03 18:51:48 UTC
Re: Review Request 42755: Added documentation for labeled reserved
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 5:51 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117674
-----------------------------------------------------------
docs/reservation.md (line 65)
<https://reviews.apache.org/r/42755/#comment178953>
Should we highlight `labelfree reservation`? As it is not true for dynamic reservations in general anymore.
docs/reservation.md (line 80)
<https://reviews.apache.org/r/42755/#comment178952>
s/agent/slave.In the rest of this document we use slave. Alternatively we can change all others to agent, but should be consistent.
docs/reservation.md (line 81)
<https://reviews.apache.org/r/42755/#comment178951>
into a single reservation despite having the same role.
- Joerg Schad
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117729
-----------------------------------------------------------
Fix it, then Ship it!
docs/reservation.md (line 84)
<https://reviews.apache.org/r/42755/#comment179008>
Add newline.
- Michael Park
On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 10:40 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117723
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 10:40 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117973
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43239, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 2:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 2:18 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 10:40 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Address review comments from Joerg.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117652
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117675
-----------------------------------------------------------
Ship it!
After previous issues are resolved :-).
- Joerg Schad
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>