You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/21 11:40:04 UTC
[GitHub] [iotdb] Alima777 commented on a change in pull request #2513: [C++ Client] Add insertRecordsOfOneDevice() interface for C++ client
Alima777 commented on a change in pull request #2513:
URL: https://github.com/apache/iotdb/pull/2513#discussion_r561803414
##########
File path: client-cpp/src/main/Session.cpp
##########
@@ -408,12 +417,52 @@ void Session::sortIndexByTimestamp(int* index, int64_t* timestamps, int length)
}
}
-vector<string> Session::sortList(vector<string>& valueList, int* index, int indexLength) {
- vector<string> sortedValues(valueList.size());
- for (int i = 0; i < indexLength; i++) {
- sortedValues[i] = valueList[index[i]];
+void Session::putValuesIntoBuffer(vector<TSDataType::TSDataType>& types, vector<char*>& values, string buf) {
Review comment:
```suggestion
void Session::putValuesIntoBuffer(vector<TSDataType::TSDataType>& types, vector<char*>& values, string& buf) {
```
Is reference here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org