[GitHub] [jclouds] nacx commented on a change in pull request #64: JCLOUDS-1520 - Reuse SSLSocketFactory in JavaUrlHttpCommandExecutorSe…

[GitBox <gi...@apache.org>]

nacx commented on a change in pull request #64: JCLOUDS-1520 - Reuse SSLSocketFactory in JavaUrlHttpCommandExecutorSe…
URL: https://github.com/apache/jclouds/pull/64#discussion_r390259790
 
 

 ##########
 File path: core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
 ##########
 @@ -72,6 +74,7 @@
    protected Supplier<SSLContext> sslContextSupplier;
    protected final int outputSocketBufferSize;
    protected final String userAgent;
+   protected final AtomicReference<SSLSocketFactory> sslSocketFactoryReference;
 
 Review comment:
   I'm a bit unclear on this state on a singleton object. Could we just push back the decision on the SSL socket factory to use to the existing suppliers? If the suppliers are returning a singleton instance, as it is the case of the untrusted supplier, then we should be good here?
   Instead of introducing state here, I'd just delegate that to the suppliers, as that is something that can be tweaked by users bu configuring their own ones when creating the context, if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services