[jira] [Commented] (CALCITE-3351) SQLException when executing SQL containing Chinese

["Danny Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178822#comment-17178822 ] 

Danny Chen commented on CALCITE-3351:
-------------------------------------

Hi, [~julianhyde], do you remember the background why we drop the charset intentionally when do {{SqlImplementor#toSql}} for string literal ?

> SQLException when executing SQL containing Chinese
> --------------------------------------------------
>
>                 Key: CALCITE-3351
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3351
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.19.0
>         Environment: Happened on both Windows and MacOS.
>            Reporter: cui
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: e.condition.png, toSql Result.png
>
>   Original Estimate: 24h
>          Time Spent: 0.5h
>  Remaining Estimate: 23.5h
>
> Exception was thrown when connecting with mySQL to query Chinese. The following SQL was executed: 
> select * from \"test\".\"score_new\" where \"name\"= \'催\' limit 1
> ，if change "getDefaultCharset" in  "RelDataTypeFactoryImpl" to 
> return Charset.forName("UTF8");
> there will be also exception thrown as the following:
> java.sql.SQLException: Error while executing SQL "select * from "test"."score_new" where "name"= '催' limit 1": While executing SQL [SELECT *java.sql.SQLException: Error while executing SQL "select * from "test"."score_new" where "name"= '催' limit 1": While executing SQL [SELECT *FROM `score_new`WHERE `name` = u&'\50ac'LIMIT 1] on JDBC sub-schema at org.apache.calcite.avatica.Helper.createException(Helper.java:56) at org.apache.calcite.avatica.Helper.createException(Helper.java:41) at org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163) at org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227) at QueryMysql.main(QueryMysql.java:42)Caused by: java.lang.RuntimeException: While executing SQL [SELECT *FROM `score_new`WHERE `name` = u&'\50ac'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)