You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/08 16:54:10 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2429: Representation of frames in DebuggingView API.
entlicher opened a new pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429
`DebuggingView` extended with API for frames.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r501879133
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -401,6 +444,51 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
public DVThreadGroup[] getThreadGroups();
}
+ /**
+ * Representation of a stack frame in debugging view.
+ * Nodes representing a stack frame in debugging view model should implement this
+ * interface.
Review comment:
Missing `@since` tag.
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -326,6 +338,37 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
*/
public void makeCurrent();
+ /**
+ * Get frame count of this thread. The frame count is provided when the thread
+ * is suspended only.
+ * @return the frame count, <code>0</code> when the thread is running.
+ */
+ public default int getFrameCount() {
+ return 0;
+ }
+
+ /**
+ * Get the stack frames of this thread. Stack frames are provided when the thread
+ * is suspended only.
+ *
+ * @return a list of stack frames, it's empty when the thread is running.
+ */
+ public default List<DVFrame> getFrames() {
Review comment:
Recently I wrote a [philippic against using default methods](http://wiki.apidesign.org/wiki/BinaryCompatibleDefaultMethods), but given the [one to many proximity](http://wiki.apidesign.org/wiki/Proximity) - e.g. there is very likely just a single implementation of these interfaces in the debugger impl modules - I expect no clashes and `default` methods are the easiest way to extend the interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r502019822
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -401,6 +444,51 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
public DVThreadGroup[] getThreadGroups();
}
+ /**
+ * Representation of a stack frame in debugging view.
+ * Nodes representing a stack frame in debugging view model should implement this
+ * interface.
Review comment:
Thanks for the reminder of the apichanges, etc. Updated.
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -326,6 +338,37 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
*/
public void makeCurrent();
+ /**
+ * Get frame count of this thread. The frame count is provided when the thread
+ * is suspended only.
+ * @return the frame count, <code>0</code> when the thread is running.
+ */
+ public default int getFrameCount() {
+ return 0;
+ }
+
+ /**
+ * Get the stack frames of this thread. Stack frames are provided when the thread
+ * is suspended only.
+ *
+ * @return a list of stack frames, it's empty when the thread is running.
+ */
+ public default List<DVFrame> getFrames() {
Review comment:
Right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r502019822
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -401,6 +444,51 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
public DVThreadGroup[] getThreadGroups();
}
+ /**
+ * Representation of a stack frame in debugging view.
+ * Nodes representing a stack frame in debugging view model should implement this
+ * interface.
Review comment:
Thanks for the reminder of the apichanges, etc. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r502020435
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -326,6 +338,37 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
*/
public void makeCurrent();
+ /**
+ * Get frame count of this thread. The frame count is provided when the thread
+ * is suspended only.
+ * @return the frame count, <code>0</code> when the thread is running.
+ */
+ public default int getFrameCount() {
+ return 0;
+ }
+
+ /**
+ * Get the stack frames of this thread. Stack frames are provided when the thread
+ * is suspended only.
+ *
+ * @return a list of stack frames, it's empty when the thread is running.
+ */
+ public default List<DVFrame> getFrames() {
Review comment:
Right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2429: Representation of frames in DebuggingView API.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2429:
URL: https://github.com/apache/netbeans/pull/2429#discussion_r501879133
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -401,6 +444,51 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
public DVThreadGroup[] getThreadGroups();
}
+ /**
+ * Representation of a stack frame in debugging view.
+ * Nodes representing a stack frame in debugging view model should implement this
+ * interface.
Review comment:
Missing `@since` tag.
##########
File path: ide/spi.debugger.ui/src/org/netbeans/spi/debugger/ui/DebuggingView.java
##########
@@ -326,6 +338,37 @@ public final void removePropertyChangeListener(PropertyChangeListener pcl) {
*/
public void makeCurrent();
+ /**
+ * Get frame count of this thread. The frame count is provided when the thread
+ * is suspended only.
+ * @return the frame count, <code>0</code> when the thread is running.
+ */
+ public default int getFrameCount() {
+ return 0;
+ }
+
+ /**
+ * Get the stack frames of this thread. Stack frames are provided when the thread
+ * is suspended only.
+ *
+ * @return a list of stack frames, it's empty when the thread is running.
+ */
+ public default List<DVFrame> getFrames() {
Review comment:
Recently I wrote a [philippic against using default methods](http://wiki.apidesign.org/wiki/BinaryCompatibleDefaultMethods), but given the [one to many proximity](http://wiki.apidesign.org/wiki/Proximity) - e.g. there is very likely just a single implementation of these interfaces in the debugger impl modules - I expect no clashes and `default` methods are the easiest way to extend the interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists