[GitHub] piiswrong commented on a change in pull request #10306: fix crash when profiler not enabled

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10306: fix crash when profiler not enabled
URL: https://github.com/apache/incubator-mxnet/pull/10306#discussion_r177910904
 
 

 ##########
 File path: src/engine/threaded_engine.h
 ##########
 @@ -398,7 +398,8 @@ class ThreadedEngine : public Engine {
   }
 
   int bulk_size() const override {
-    return profiler::Profiler::Get()->AggregateRunning() ? 0 :  BulkStatusStore::Get()->bulk_size;
+    const profiler::Profiler *prof = profiler::Profiler::Get();
 
 Review comment:
   why would profiler::get return nullptr when it's not enabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services