You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/02 02:10:36 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

tqchen opened a new pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377


   cc @tmoreau89 @anijain2305 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#issuecomment-685277488


   Thanks @tqchen for the fix. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#discussion_r482254229



##########
File path: src/relay/transforms/fold_constant.cc
##########
@@ -230,7 +216,17 @@ class ConstantFolder : public ExprMutator {
     auto entry_func = Downcast<Function>(mod->Lookup("main"));
     expr = expr.as<FunctionNode>() == nullptr ? entry_func->body : entry_func;
 
-    FInterpreter executor = GetInterpreter(mod);
+    using tvm::transform::PassContext;

Review comment:
       Why inline this back in?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#issuecomment-685253293






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#discussion_r482255420



##########
File path: src/relay/transforms/fold_constant.cc
##########
@@ -230,7 +216,17 @@ class ConstantFolder : public ExprMutator {
     auto entry_func = Downcast<Function>(mod->Lookup("main"));
     expr = expr.as<FunctionNode>() == nullptr ? entry_func->body : entry_func;
 
-    FInterpreter executor = GetInterpreter(mod);
+    using tvm::transform::PassContext;

Review comment:
       We will need the make sure the context is set during the `executor(input)` call besides the creation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] anijain2305 edited a comment on pull request #6377: [RELAY] Fix the FoldConstant Regression for VTA

Posted by GitBox <gi...@apache.org>.
anijain2305 edited a comment on pull request #6377:
URL: https://github.com/apache/incubator-tvm/pull/6377#issuecomment-685277488


   Thanks @tqchen for the fix. Thanks @tmoreau89 for raising this.
   
   The fix ensures that the compilation time improvement is retained from the origin PR #6195 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org