You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "pylipp (via GitHub)" <gi...@apache.org> on 2023/02/18 17:15:00 UTC

[GitHub] [superset] pylipp opened a new pull request, #23115: Docs: Show clickable link instead of code-formatting

pylipp opened a new pull request, #23115:
URL: https://github.com/apache/superset/pull/23115

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #23115: docs: Show clickable link instead of code-formatting

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23115:
URL: https://github.com/apache/superset/pull/23115#issuecomment-1626348165

   Closing this since we haven't heard back and the copy of it has been merged. Thank you for the alleyoop!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #23115: docs: Show clickable link instead of code-formatting

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23115:
URL: https://github.com/apache/superset/pull/23115#issuecomment-1437102850

   @pylipp there was an issue on CI which has now been fixed. Are you able to rebase your PR? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas closed pull request #23115: docs: Show clickable link instead of code-formatting

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23115: docs: Show clickable link instead of code-formatting
URL: https://github.com/apache/superset/pull/23115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #23115: Docs: Show clickable link instead of code-formatting

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23115:
URL: https://github.com/apache/superset/pull/23115#issuecomment-1436717603

   > In the top part of the paragraph, mysqlclient is not formatted in backtics either, so I propose the same format is used for the part that I updated.
   
   Makes sense, will merge once CI passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #23115: docs: Show clickable link instead of code-formatting

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23115:
URL: https://github.com/apache/superset/pull/23115#issuecomment-1524530665

   Just opened a PR pulling in this commit - hopefully it's mergable, and @pylipp will still get the credit. Happy to close that one if you'd rather rebase this... if not, I'll close this one when the other merges. Thanks either way, and join us in #documentation on [Slack](http://bit.ly/join-superset-slack) if you want to contribute to more documentation touchups!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] pylipp commented on pull request #23115: Docs: Show clickable link instead of code-formatting

Posted by "pylipp (via GitHub)" <gi...@apache.org>.
pylipp commented on PR #23115:
URL: https://github.com/apache/superset/pull/23115#issuecomment-1436716176

   > LGTM, thanks for the fix! One thing worth considering is moving the backticks inside the link (probably the original intent). But this is a matter of taste.
   
   In the top part of the paragraph, mysqlclient is not formatted in backtics either, so I propose the same format is used for the part that I updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org