You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/07/17 15:13:29 UTC

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh edited a comment on pull request #12: SLING-10010 update to sling-bundle-parent 40

joerghoh edited a comment on pull request #12:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/12#issuecomment-881912890


   @kwin I think we should drop the dependency to sling-commons-testing, we should start to use the sling mocks instead (they are maintained and much more easier to use). For that reason I added the 2 relevant classes in here, which serve as a replacement for the ones of sling-commons-testing, but Oak-based.
   
   I also think that we should invest in some time and update some Junit3 tests to Junit4, which I haven't done yet to keep the scope of the patch as narrow as possible. Also we should update to the most recent of the parent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org