You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/18 13:47:31 UTC
[GitHub] [mynewt-nimble] kasjer opened a new pull request, #1324: nimble/transport: Add CDC transport
kasjer opened a new pull request, #1324:
URL: https://github.com/apache/mynewt-nimble/pull/1324
This adds implementation of TinyUSB CDC class that
that will transmit HCI protocol over USB/CDC class
This change requires https://github.com/apache/mynewt-core/pull/2863 to be merged first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] kasjer merged pull request #1324: nimble/transport: Add CDC transport
Posted by GitBox <gi...@apache.org>.
kasjer merged PR #1324:
URL: https://github.com/apache/mynewt-nimble/pull/1324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1324: nimble/transport: Add CDC transport
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1324:
URL: https://github.com/apache/mynewt-nimble/pull/1324#issuecomment-1220296840
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1324: nimble/transport: Add CDC transport
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1324:
URL: https://github.com/apache/mynewt-nimble/pull/1324#issuecomment-1219645281
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/transport/cdc/src/cdc_hci.c
<details>
```diff
@@ -135,8 +135,10 @@
int sr;
struct usb_in_packet *last_packet;
- TU_LOG(CDC_HCI_LOG_LEVEL, "send next in packet fifo available %d\n", (int)tud_cdc_n_available(cdc_hci_itf.cdc_num));
- TU_LOG(CDC_HCI_LOG_LEVEL, "current_in_packet %p sent so far %d of %d\n", current_in_packet, current_in_packet_offset,
+ TU_LOG(CDC_HCI_LOG_LEVEL, "send next in packet fifo available %d\n",
+ (int)tud_cdc_n_available(cdc_hci_itf.cdc_num));
+ TU_LOG(CDC_HCI_LOG_LEVEL, "current_in_packet %p sent so far %d of %d\n", current_in_packet,
+ current_in_packet_offset,
usb_in_packet_size(current_in_packet));
if (cdc_hci_itf.current_in_packet == NULL ||
cdc_hci_itf.current_in_packet_offset == usb_in_packet_size(cdc_hci_itf.current_in_packet)) {
@@ -152,7 +154,8 @@
}
if (cdc_hci_itf.current_in_packet != NULL &&
cdc_hci_itf.current_in_packet_offset < usb_in_packet_size(cdc_hci_itf.current_in_packet)) {
- cdc_hci_itf.current_in_packet_offset += usb_in_packet_write(cdc_hci_itf.current_in_packet, cdc_hci_itf.current_in_packet_offset);
+ cdc_hci_itf.current_in_packet_offset += usb_in_packet_write(cdc_hci_itf.current_in_packet,
+ cdc_hci_itf.current_in_packet_offset);
}
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org