You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/22 00:25:12 UTC

[GitHub] [hudi] xushiyan opened a new pull request #2195: [MINOR] Fix caller to SparkBulkInsertCommitActionExecutor

xushiyan opened a new pull request #2195:
URL: https://github.com/apache/hudi/pull/2195


   Fixed calling the wrong constructor
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar merged pull request #2195: [MINOR] Fix caller to SparkBulkInsertCommitActionExecutor

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #2195:
URL: https://github.com/apache/hudi/pull/2195


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a change in pull request #2195: [MINOR] Fix caller to SparkBulkInsertCommitActionExecutor

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #2195:
URL: https://github.com/apache/hudi/pull/2195#discussion_r509809771



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java
##########
@@ -284,7 +284,7 @@ protected void commit(Option<Map<String, String>> extraMetadata, HoodieWriteMeta
   protected BaseSparkCommitActionExecutor<T> getBulkInsertActionExecutor(JavaRDD<HoodieRecord> inputRecordsRDD) {
     return new SparkBulkInsertCommitActionExecutor((HoodieSparkEngineContext) context, new HoodieWriteConfig.Builder().withProps(config.getProps())
         .withSchema(bootstrapSchema).build(), table, HoodieTimeline.FULL_BOOTSTRAP_INSTANT_TS,
-        inputRecordsRDD, extraMetadata);
+        inputRecordsRDD, Option.empty(), extraMetadata);

Review comment:
       this results in error  "java.util.HashMap cannot be cast to org.apache.hudi.table.BulkInsertPartitioner"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org