You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/25 06:06:57 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #1300: libs: rv64: Fix _calc_imm() in arch_elf.c
masayuki2009 opened a new pull request #1300:
URL: https://github.com/apache/incubator-nuttx/pull/1300
## Summary
- I noticed that maix-bit:elf fails due to assertion
```
****************************************************************************
* Executing struct
****************************************************************************
up_assert: Assertion failed at file:machine/risc-v/rv64/arch_elf.c line: 163 task: init
```
- Finally, I found a bug in _calc_imm() which calculates immediate values when loading elf files.
## Impact
- This PR affects elf loading for RISCV-64.
## Testing
- I tested _calc_imm(long offset, ...) where the offset range is from -100000 to +100000.
- Also, I tested maix-bit:elf and maix-bit:posix_spawn with qemu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1300: libs: rv64: Fix _calc_imm() in arch_elf.c
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1300:
URL: https://github.com/apache/incubator-nuttx/pull/1300#issuecomment-649309140
> @masayuki2009 is this something that we should backport to 9.1 since we are already taking in a few other fixes?
@btashton
Yes, please merge this commit to nuttx-9.1.x branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1300: libs: rv64: Fix _calc_imm() in arch_elf.c
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1300:
URL: https://github.com/apache/incubator-nuttx/pull/1300#issuecomment-649315807
Added the label. I'll take care of it tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1300: libs: rv64: Fix _calc_imm() in arch_elf.c
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1300:
URL: https://github.com/apache/incubator-nuttx/pull/1300#issuecomment-649304048
@masayuki2009 is this something that we should backport to 9.1 since we are already taking in a few other fixes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1300: libs: rv64: Fix _calc_imm() in arch_elf.c
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1300:
URL: https://github.com/apache/incubator-nuttx/pull/1300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org