You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by ji...@apache.org on 2023/05/31 18:06:56 UTC

[daffodil] branch main updated: Remove sbteclipse-plugin

This is an automated email from the ASF dual-hosted git repository.

jinterrante pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/daffodil.git


The following commit(s) were added to refs/heads/main by this push:
     new 33b9f4734 Remove sbteclipse-plugin
33b9f4734 is described below

commit 33b9f4734a858a21f444a0ad84c6f3caae231f7e
Author: Scala Steward <sc...@virtuslab.com>
AuthorDate: Wed May 31 09:22:41 2023 -0400

    Remove sbteclipse-plugin
---
 build.sbt           | 30 ------------------------------
 project/plugins.sbt |  2 --
 2 files changed, 32 deletions(-)

diff --git a/build.sbt b/build.sbt
index 61958fa32..90f60e83d 100644
--- a/build.sbt
+++ b/build.sbt
@@ -19,16 +19,6 @@ import scala.collection.immutable.ListSet
 
 import sbtcc._
 
-// Silence an errant sbt linter warning about unused sbt settings. For some
-// reason, the sbt linter thinks the below settings are set but not used, which
-// leads to a bunch of noisy warnings. But they clearly are used. Seems to be a
-// bug in the linter where it cannot detect that some keys are used. The
-// following is the sbt recommended way to silence these linter warnings on a
-// per setting basis rather thand disabling the linter completely.
-Global / excludeLintKeys ++= Set(
-  EclipseKeys.classpathTransformerFactories,
-)
-
 lazy val genManaged = taskKey[Seq[File]]("Generate managed sources and resources")
 lazy val genProps = taskKey[Seq[File]]("Generate properties scala source")
 lazy val genSchemas = taskKey[Seq[File]]("Generate DFDL schemas")
@@ -333,26 +323,6 @@ lazy val usesMacros = Seq(
   Compile / packageBin / mappings ++= (macroLib / Compile / packageBin / mappings).value
     .filter { case (f, _) => f.isDirectory || f.getPath.endsWith(".class") },
   Compile / packageSrc / mappings ++= (macroLib / Compile / packageSrc / mappings).value,
-
-  // The .classpath files that the sbt eclipse plugin creates need minor
-  // modifications. Fortunately, the plugin allows us to provide "transformers"
-  // to make such modifications. Note that because this is part of the
-  // "usesMacro" setting, the following transformations are only applied to
-  // .classpath files in projects that use macros and add this setting.
-  EclipseKeys.classpathTransformerFactories ++= Seq(
-    // The macroLib project needs to be a "compile-internal" dependency to
-    // projects that add this "usesMacros" setting. But the sbt eclipse plugin
-    // only looks at "compile" dependencies when building .classpath files.
-    // This means that eclipse projects that use macros don't have a dependency
-    // to macroLib and so fail to compile. This transformation looks for
-    // "classpath" nodes, and appends a new "classpathentry" node as a child
-    // referencing the macroLib project. This causes Eclipse to treat macroLib
-    // just like any other dependency to allow compilation to work.
-    transformNode(
-      "classpath",
-      DefaultTransforms.Append(EclipseClasspathEntry.Project(macroLib.base.toString)),
-    ),
-  ),
 )
 
 lazy val libManagedSettings = Seq(
diff --git a/project/plugins.sbt b/project/plugins.sbt
index 84b6d2548..e4a38cf27 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -25,6 +25,4 @@ addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.0.7")
 
 addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
 
-addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "5.2.4")
-
 addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.0")