[GitHub] [spark] ulysses-you commented on a change in pull request #32184: [SPARK-35083][CORE] Support remote scheduler pool file using hadoop api

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #32184:
URL: https://github.com/apache/spark/pull/32184#discussion_r614534549



##########
File path: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala
##########
@@ -332,12 +337,36 @@ class PoolSuite extends SparkFunSuite with LocalSparkContext {
     sc = new SparkContext(LOCAL, APP_NAME, conf)
 
     val rootPool = new Pool("", SchedulingMode.FAIR, 0, 0)
-    val schedulableBuilder = new FairSchedulableBuilder(rootPool, sc.conf)
+    val schedulableBuilder = new FairSchedulableBuilder(rootPool, sc)
     intercept[FileNotFoundException] {
       schedulableBuilder.buildPools()
     }
   }
 
+  test("SPARK-35083: Support remote scheduler pool file") {
+    val hadoopVersion = VersionInfo.getVersion.split("\\.")
+    // HttpFileSystem supported since hadoop 2.9
+    assume(hadoopVersion.head.toInt >= 3 ||
+      (hadoopVersion.head.toInt == 2 && hadoopVersion(1).toInt >= 9))

Review comment:
       This check is to avoid `java.io.IOException: No FileSystem for scheme: http` if we use hadoop 2.7 which Spark still supports.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org