You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/23 16:54:00 UTC
[jira] [Commented] (GEODE-8522) Locators log full stack traces of
exceptions at info level during normal startup
[ https://issues.apache.org/jira/browse/GEODE-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200957#comment-17200957 ]
ASF GitHub Bot commented on GEODE-8522:
---------------------------------------
upthewaterspout opened a new pull request #5545:
URL: https://github.com/apache/geode/pull/5545
This log message happens during the course of normal startup of multiple
locators. We should not be logging a full stack trace during normal startup.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Locators log full stack traces of exceptions at info level during normal startup
> --------------------------------------------------------------------------------
>
> Key: GEODE-8522
> URL: https://issues.apache.org/jira/browse/GEODE-8522
> Project: Geode
> Issue Type: Bug
> Reporter: Dan Smith
> Assignee: Dan Smith
> Priority: Major
>
> It's normal to configure multiple locators that all refer to each other's addresses. When starting up, the first locator that starts up will always log an exception failing to talk to other locators.
> {noformat}
> [info 2020/09/22 21:16:16.582 GMT <main> tid=0x1] Exception thrown when contacting a locator
> java.net.NoRouteToHostException: No route to host (Host unreachable)
> at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
> at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:399)
> at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:242)
> at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:224)
> at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:403)
> at java.base/java.net.Socket.connect(Socket.java:609)
> at org.apache.geode.distributed.internal.tcpserver.AdvancedSocketCreatorImpl.connect(AdvancedSocketCreatorImpl.java:102)
> at org.apache.geode.internal.net.SCAdvancedSocketCreator.connect(SCAdvancedSocketCreator.java:51)
> at org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.connect(ClusterSocketCreatorImpl.java:96)
> at org.apache.geode.distributed.internal.tcpserver.TcpClient.getServerVersion(TcpClient.java:262)
> at org.apache.geode.distributed.internal.tcpserver.TcpClient.requestToServer(TcpClient.java:153)
> at org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.findCoordinator(GMSJoinLeave.java:1156)
> at org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.join(GMSJoinLeave.java:342)
> at org.apache.geode.distributed.internal.membership.gms.GMSMembership.join(GMSMembership.java:568)
> at org.apache.geode.distributed.internal.membership.gms.GMSMembership.access$1300(GMSMembership.java:72)
> at org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.joinDistributedSystem(GMSMembership.java:1974)
> at org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:242)
> at org.apache.geode.distributed.internal.membership.gms.GMSMembership.start(GMSMembership.java:1853)
> at org.apache.geode.distributed.internal.DistributionImpl.start(DistributionImpl.java:171)
> at org.apache.geode.distributed.internal.DistributionImpl.createDistribution(DistributionImpl.java:222)
> at org.apache.geode.distributed.internal.ClusterDistributionManager.<init>(ClusterDistributionManager.java:464)
> at org.apache.geode.distributed.internal.ClusterDistributionManager.<init>(ClusterDistributionManager.java:497)
> at org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:326)
> at org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:779)
> at org.apache.geode.distributed.internal.InternalDistributedSystem.access$200(InternalDistributedSystem.java:135)
> at org.apache.geode.distributed.internal.InternalDistributedSystem$Builder.build(InternalDistributedSystem.java:3034)
> at org.apache.geode.distributed.internal.InternalDistributedSystem.connectInternal(InternalDistributedSystem.java:290)
> at org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:743)
> at org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:388)
> at org.apache.geode.distributed.LocatorLauncher.start(LocatorLauncher.java:716)
> at org.apache.geode.distributed.LocatorLauncher.run(LocatorLauncher.java:623)
> at org.apache.geode.distributed.LocatorLauncher.main(LocatorLauncher.java:217)
> {noformat}
> We shouldn't log full stack trace exceptions for something that is normal part of the startup process, because it makes it harder to search for errors.
> This is coming from this line in the code, which was switch from debug to info in the last year:
> https://github.com/apache/geode/blob/52018fcf1da513c888092775295a121992abcec2/geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java#L1200
--
This message was sent by Atlassian Jira
(v8.3.4#803005)