You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/05 12:23:45 UTC

[GitHub] [flink] godfreyhe opened a new pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

godfreyhe opened a new pull request #14562:
URL: https://github.com/apache/flink/pull/14562


   ## What is the purpose of the change
   
   *Separate the implementation of batch group aggregate nodes, including BatchExecHashAggregate, BatchExecLocalHashAggregate, BatchExecSortAggregate, BatchExecLocalSortAggregate, BatchExecPythonGroupAggregate*
   
   
   ## Brief change log
   
     - *Rename BatchExecGroupAggregateBase to BatchPhysicalGroupAggregateBase and do some refactoring*
     - *Introduce BatchPhysicalHashAggregate, and make BatchExecHashAggregate only extended from ExecNode*
     - *Introduce BatchPhysicalLocalHashAggregate, and make BatchPhysicalLocalHashAggregate only extended from FlinkPhysicalRel*
     - *Introduce BatchPhysicalSortAggregate, and make BatchExecSortAggregate only extended from ExecNode*
     - *Introduce BatchPhysicalLocalSortAggregate, and make BatchPhysicalLocalSortAggregate only extended from FlinkPhysicalRel*
     - *Introduce BatchPhysicalPythonGroupAggregate, and make BatchExecPythonGroupAggregate only extended from ExecNode*
   
   ## Verifying this change
   
   This change is a refactoring rework covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wenlong88 commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r552391242



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdModifiedMonotonicity.scala
##########
@@ -352,7 +352,7 @@ class FlinkRelMdModifiedMonotonicity private extends MetadataHandler[ModifiedMon
 
     // if group by an update field or group by a field mono is null, just return null
     if (inputMonotonicity == null ||
-        grouping.exists(e => inputMonotonicity.fieldMonotonicities(e) != CONSTANT)) {
+      grouping.exists(e => inputMonotonicity.fieldMonotonicities(e) != CONSTANT)) {

Review comment:
       the old format is better

##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdModifiedMonotonicity.scala
##########
@@ -373,7 +373,7 @@ class FlinkRelMdModifiedMonotonicity private extends MetadataHandler[ModifiedMon
 
     // if group by a update field or group by a field mono is null, just return null
     if (inputMonotonicity == null ||
-        grouping.exists(e => inputMonotonicity.fieldMonotonicities(e) != CONSTANT)) {
+      grouping.exists(e => inputMonotonicity.fieldMonotonicities(e) != CONSTANT)) {

Review comment:
       ditto

##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdModifiedMonotonicity.scala
##########
@@ -398,7 +398,7 @@ class FlinkRelMdModifiedMonotonicity private extends MetadataHandler[ModifiedMon
           val childMono = inputMonotonicity.fieldMonotonicities(aggCall.getArgList.head)
           val currentMono = fieldMonotonicities(index)
           if (childMono != currentMono &&
-              !aggCall.getAggregation.isInstanceOf[SqlCountAggFunction]) {
+            !aggCall.getAggregation.isInstanceOf[SqlCountAggFunction]) {

Review comment:
       ditto

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       ConfigOption supports type of MemorySize, can we just use it?,ref:FRAMEWORK_HEAP_MEMORY




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b882bd349ec547b34835ea347cd95febd645053f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11731",
       "triggerID" : "b882bd349ec547b34835ea347cd95febd645053f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699) 
   * b882bd349ec547b34835ea347cd95febd645053f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11731) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   * 662db1d7856357ad03423c035ab92a85d32ec0b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678) 
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   * 662db1d7856357ad03423c035ab92a85d32ec0b7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 662db1d7856357ad03423c035ab92a85d32ec0b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678) 
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r552627854



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       It will broke the current API, because the compile error will occur when user's before code is `configuration.set(
         ExecutionConfigOptions.TABLE_EXEC_RESOURCE_HASH_AGG_MEMORY, "128 mb")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b882bd349ec547b34835ea347cd95febd645053f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11731",
       "triggerID" : "b882bd349ec547b34835ea347cd95febd645053f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b882bd349ec547b34835ea347cd95febd645053f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11731) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683) 
   * 34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b882bd349ec547b34835ea347cd95febd645053f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b882bd349ec547b34835ea347cd95febd645053f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699) 
   * b882bd349ec547b34835ea347cd95febd645053f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   * 662db1d7856357ad03423c035ab92a85d32ec0b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754604915


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9391a2d892fdf4b58367db84e33a9ac10f1d5825 (Tue Jan 05 12:26:15 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r552627854



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       It will broke the current API, because the compile error will occur when user's code is `configuration.set(
         ExecutionConfigOptions.TABLE_EXEC_RESOURCE_HASH_AGG_MEMORY, "128 mb")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r553178299



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       I create an issue to do the improvement, see https://issues.apache.org/jira/browse/FLINK-20879




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   * 662db1d7856357ad03423c035ab92a85d32ec0b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678) 
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754604915


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b882bd349ec547b34835ea347cd95febd645053f (Fri May 28 07:02:00 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     }, {
       "hash" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11678",
       "triggerID" : "662db1d7856357ad03423c035ab92a85d32ec0b7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683",
       "triggerID" : "f08790bc16b0a323309ac3e59de85db3c9d60f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699",
       "triggerID" : "34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f08790bc16b0a323309ac3e59de85db3c9d60f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11683) 
   * 34812b769f5ae8dc91df3af4dc2f671cb8f5d8e3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11699) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14562:
URL: https://github.com/apache/flink/pull/14562#discussion_r552627854



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -35,6 +38,11 @@
 /** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
 public class ExecNodeUtil {
 
+    /** Return bytes size for given option in {@link TableConfig}. */
+    public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
+        return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();

Review comment:
       It will broken current API, because the compile error will occur when user's code is `configuration.set(
         ExecutionConfigOptions.TABLE_EXEC_RESOURCE_HASH_AGG_MEMORY, "128 mb")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe closed pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14562:
URL: https://github.com/apache/flink/pull/14562


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14562: [FLINK-20738][table-planner-blink] Separate the implementation of batch group aggregate nodes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14562:
URL: https://github.com/apache/flink/pull/14562#issuecomment-754609174


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655",
       "triggerID" : "9391a2d892fdf4b58367db84e33a9ac10f1d5825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9391a2d892fdf4b58367db84e33a9ac10f1d5825 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11655) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org