You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2026/05/19 08:51:56 UTC
[PR] fix: close the file writers properly in fail cases [hudi]
danny0405 opened a new pull request, #18776:
URL: https://github.com/apache/hudi/pull/18776
```markdown
### Describe the issue this Pull Request addresses
Several Hudi file-writing paths can allocate output streams or file writers before all initialization/write steps complete. If a later constructor step, write operation, flush, or close-time metadata operation throws before the normal close path is reached, the underlying writer or stream may remain open.
This PR tightens cleanup for Parquet, HFile, binary-copy, Spark/Flink row writers, bootstrap index writers, and write handles so writer-owned resources are closed when failures occur. There are no storage format, public API, or config changes.
### Summary and Changelog
This change makes file-writer cleanup more exception-safe across production write paths and adds focused coverage for the binary-copy and create-handle failure cases.
#### Working tree: close file writers on failure paths
- Close raw output streams if Parquet writer construction fails in `HoodieParquetStreamWriter`, `HoodieSparkParquetStreamWriter`, and `HoodieRowDataParquetOutputStreamWriter`.
- Close `HoodieAvroHFileWriter` output stream only when writer construction does not take ownership.
- Harden `HFileBootstrapIndexWriter.begin()` and `close()` so partially initialized HFile writers are closed and close failures are preserved.
- Ensure `ParquetUtils.serializeRecordsToLogBlock` closes the `HoodieFileWriter` with try-with-resources.
- Ensure `SparkHelpers` closes `HoodieAvroParquetWriter` in a `finally` block.
- Harden `HoodieParquetBinaryCopyBase` by closing the Parquet writer when `start()` fails, clearing writer state after close, and closing column writers in `maskColumn` / `addNullColumn` when flush/write fails.
- Add compatibility handling for `ParquetFileWriter.close()` via reflective method lookup only when the runtime class exposes `close()`.
#### Working tree: close write-handle owned writers on failure paths
- `BaseCreateHandle` now closes and clears `fileWriter` when record writing fails and write failures are not ignored.
- `HoodieAppendHandle` now closes the log writer when record write, compaction write, or close-time append/flush fails.
- `HoodieWriteMergeHandle` now closes and clears `fileWriter` when `writeIncomingRecords()` or close-time operations fail.
- `HoodieSortedMergeHandle` now routes pending insert writes through `writeIncomingRecords()` so the base merge-handle close protection applies.
- `HoodieBinaryCopyHandle` now closes the binary copier if `binaryCopy()` fails before the normal close path.
#### Working tree: tests
- Added `TestHoodieParquetBinaryCopyBaseSchemaEvolution` coverage for:
- missing `ParquetFileWriter.close()` compatibility behavior,
- invoking `close()` when present,
- clearing the writer when `end()` fails.
- Added `TestHoodieCreateHandle#testFileWriterClosedWhenDoWriteFails` to verify `fileWriter` is cleared after write failure.
### Impact
No public API, config, or storage format changes. The impact is limited to safer resource cleanup in failure paths for file-writing and write-handle code. Successful write behavior should remain unchanged.
Affected paths include Hudi create/append/merge/binary-copy handles, Parquet stream writers, HFile writers, bootstrap index writers, and Spark/Flink writer integrations.
### Risk Level
medium
This touches core write-path cleanup logic across multiple modules, including append, merge, create, binary-copy, Parquet, and HFile paths. The behavioral intent is narrow: close resources on exception paths and preserve original failures by adding close failures as suppressed where applicable.
Validation performed:
- `git diff --check` passes.
- `mvn -pl hudi-hadoop-common -DskipITs -Dcheckstyle.skip -Dspotbugs.skip -Dtest=TestHoodieParquetBinaryCopyBaseSchemaEvolution test` passed with 11 tests.
- `mvn -pl hudi-hadoop-common,hudi-common -DskipTests -DskipITs -Dcheckstyle.skip -Dspotbugs.skip compile` passed.
- `mvn -pl hudi-client/hudi-client-common -DskipITs -Dcheckstyle.skip -Dspotbugs.skip -Dtest=TestHoodieCreateHandle#testFileWriterClosedWhenDoWriteFails test` was attempted but blocked during compile by an unrelated existing error in `StreamingOffsetValidator.java:170` for missing `ValidationContext#getTotalWriteErrors()`.
### Documentation Update
none
This PR does not add or change user-facing configs, APIs, file formats, or documented behavior. It only improves cleanup behavior on internal failure paths.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487007635
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.13%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.13% -0.03%
- Complexity 29149 29230 +81
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96613 +272
- Misses 37079 37230 +151
- Partials 7933 7956 +23
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <38.38%> (-0.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <41.70%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495271411
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.53659%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.87%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 17.39% | [18 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 53.87% -14.28%
+ Complexity 29149 12472 -16677
=============================================
Files 2521 1435 -1086
Lines 141353 72439 -68914
Branches 17549 8299 -9250
=============================================
- Hits 96341 39028 -57313
+ Misses 37079 29886 -7193
+ Partials 7933 3525 -4408
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `73.26% <0.00%> (-17.83%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `63.58% <30.76%> (-14.29%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | `69.74% <48.48%> (-10.67%)` | :arrow_down: |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1858 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5329070800
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 400 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5334699814
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 400 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #18776: fix: close the file writers properly in fail cases
URL: https://github.com/apache/hudi/pull/18776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060564348
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/BaseCreateHandle.java:
##########
@@ -128,6 +129,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record {}", record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeFileWriterQuietly(t);
Review Comment:
**minor:** With Flink's default `write.ignore.failed=false`, this marks the handle closed, so `FlinkCreateHandle.closeGracefully` now gets a normal return from `close()` and never reaches `storage.deleteFile(path)` (the HUDI-1895 #2938 cleanup). The partial file, now with a valid footer, stays until markers or the retry-time `deleteInvalidDataFile` remove it. Not blocking, but could `closeGracefully` delete `path` when the handle was closed by a write failure, with a Flink test for a failed write followed by `closeGracefully`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486973078
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.38889%` with `105 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.19% -0.96%
+ Complexity 29149 28821 -328
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 95284 -1057
- Misses 37079 38549 +1470
- Partials 7933 7966 +33
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.66% <25.11%> (-4.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <41.70%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [180 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486879265
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.69%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|4|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.69% -7.47%
+ Complexity 29149 26013 -3136
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 86065 -10276
- Misses 37079 48153 +11074
+ Partials 7933 7581 -352
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.24% <8.05%> (-16.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.48%> (-12.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495293566
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.10%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 30 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 46.10% -22.05%
+ Complexity 29149 15554 -13595
=============================================
Files 2521 1989 -532
Lines 141353 110391 -30962
Branches 17549 13665 -3884
=============================================
- Hits 96341 50901 -45440
- Misses 37079 54012 +16933
+ Partials 7933 5478 -2455
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <18.57%> (-11.98%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `74.25% <0.00%> (-16.84%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `67.93% <30.76%> (-9.94%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1657 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495357552
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.23256%` with `107 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.52%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|5|
>|spark-scala-tests|12|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.52% -7.64%
+ Complexity 29149 25932 -3217
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 85907 -10434
- Misses 37079 48543 +11464
+ Partials 7933 7489 -444
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <8.09%> (-17.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <18.57%> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495373556
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.23256%` with `107 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.78%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|6|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.78% -7.38%
+ Complexity 29149 26096 -3053
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 86274 -10067
- Misses 37079 48080 +11001
+ Partials 7933 7585 -348
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.40% <8.09%> (-17.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.57%> (-12.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495433067
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `52.55814%` with `102 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.12%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.12% -1.03%
+ Complexity 29149 28847 -302
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 95281 -1060
- Misses 37079 38689 +1610
- Partials 7933 7969 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <26.19%> (-4.54%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <42.85%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `60.86% <100.00%> (-2.18%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [215 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4061657382
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -506,10 +500,32 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
}
}
+ private void closeFileWriter() throws IOException {
+ try {
+ if (fileWriter != null) {
+ fileWriter.close();
+ }
+ } finally {
+ fileWriter = null;
+ }
+ }
+
+ private void closeFileWriterQuietly(Throwable failure) {
Review Comment:
Fixed in f0708d42dc51. `FileGroupReaderBasedMergeHandle.doMerge()` now catches `Exception` in its existing reader/write block and calls the shared `closeFileWriterQuietly` helper before throwing `HoodieUpsertException` with the original cause. The helper closes and clears the writer and suppresses any cleanup failure. `testFileGroupMergeWriteFailureClosesWriter` covers a failed record write with ignore.failed=false, reader/iterator closure, and a failing writer close. All 11 tests in `TestSortedAndChangeLogMergeHandles` pass.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -506,10 +500,32 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
Review Comment:
Fixed in f0708d42dc51. If `super.close()` throws, `HoodieMergeHandleWithChangeLog.close()` now closes `cdcLogger` with `CloseableUtils.closeSuppressing` and rethrows the original exception. The successful close path is unchanged. `testMergeCloseFailureClosesCDCWriter` verifies both writers are closed and a CDC cleanup failure is suppressed onto the original merge-close exception.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/BaseCreateHandle.java:
##########
@@ -128,6 +129,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record {}", record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeFileWriterQuietly(t);
Review Comment:
I am keeping `FlinkCreateHandle.closeGracefully()` unchanged in this PR. During task shutdown/client close, the failed-write path has already released the writer. Leaving the finalized partial file for the existing marker/retry cleanup is acceptable for this resource-release patch; finalization also leaves the file readable for cleanup before commit. This PR does not add immediate deletion for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5761227450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
}, {
"hash" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17223",
"triggerID" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0708d42dc518830a6d0470470e15b919467e1ca Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17223)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #18776:
URL: https://github.com/apache/hudi/pull/18776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487075755
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.17% +0.01%
- Complexity 29149 29254 +105
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96669 +328
- Misses 37079 37168 +89
- Partials 7933 7962 +29
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <38.38%> (-0.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <41.70%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486855964
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.05%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|4|
>|spark-scala-tests|12|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 61.05% -7.11%
+ Complexity 29149 25615 -3534
============================================
Files 2521 2505 -16
Lines 141353 139234 -2119
Branches 17549 17056 -493
============================================
- Hits 96341 85011 -11330
- Misses 37079 46952 +9873
+ Partials 7933 7271 -662
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.24% <8.05%> (-16.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <18.48%> (-12.04%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487020241
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.16% +0.01%
- Complexity 29149 29253 +104
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96664 +323
- Misses 37079 37173 +94
- Partials 7933 7962 +29
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <38.38%> (-0.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <41.70%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487031469
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.17% +0.01%
- Complexity 29149 29254 +105
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96667 +326
- Misses 37079 37170 +91
- Partials 7933 7962 +29
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.74% <38.38%> (-0.19%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <41.70%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495444291
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.07%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.07% -0.09%
- Complexity 29149 29257 +108
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96618 +277
- Misses 37079 37368 +289
- Partials 7933 7953 +20
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <39.52%> (-0.43%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.71% <42.85%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `60.86% <100.00%> (-2.18%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [73 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495471655
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.12%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.12% -0.03%
- Complexity 29149 29284 +135
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96702 +361
- Misses 37079 37276 +197
- Partials 7933 7961 +28
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <39.52%> (-0.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <42.85%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495329360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.85%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|3|
>|spark-scala-tests|12|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 53.85% -14.31%
+ Complexity 29149 18728 -10421
=============================================
Files 2521 2037 -484
Lines 141353 115532 -25821
Branches 17549 14838 -2711
=============================================
- Hits 96341 62217 -34124
- Misses 37079 46749 +9670
+ Partials 7933 6566 -1367
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <8.09%> (-16.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `69.38% <0.00%> (-17.85%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `81.18% <0.00%> (-9.91%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `69.83% <30.76%> (-8.04%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1444 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486780551
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.37864%` with `129 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.91%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 16.00% | [20 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 53.91% -14.25%
+ Complexity 29149 12466 -16683
=============================================
Files 2521 1435 -1086
Lines 141353 72359 -68994
Branches 17549 8269 -9280
=============================================
- Hits 96341 39009 -57332
+ Misses 37079 29838 -7241
+ Partials 7933 3512 -4421
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `73.26% <0.00%> (-17.83%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `63.58% <30.76%> (-14.29%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | `68.59% <43.75%> (-11.82%)` | :arrow_down: |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1859 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5757216842
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37141ee273de412f09eb0bf11d7563cdf71ab00 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219)
* f8affff7793984a7a323988ac54598155842364f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486120853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f4784f2c99e6fdda274f8ed2a7f68e39c360310 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486968435
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.38889%` with `105 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.15%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.15% -1.00%
+ Complexity 29149 28806 -343
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 95230 -1111
- Misses 37079 38608 +1529
- Partials 7933 7961 +28
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.66% <25.11%> (-4.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.66% <41.70%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [191 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487191134
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.17% +0.01%
- Complexity 29149 29256 +107
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96671 +330
- Misses 37079 37168 +89
- Partials 7933 7960 +27
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <38.38%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <41.70%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487247810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7da5bc4d5d2637d3747297a649d3343acf24003 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059111321
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -137,7 +138,13 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
ParquetFileWriter.Mode writerMode = ParquetFileWriter.Mode.CREATE;
writer = new ParquetFileWriter(HadoopOutputFile.fromPath(outPutFile, conf), schema, writerMode, DEFAULT_BLOCK_SIZE, MAX_PADDING_SIZE_DEFAULT, DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH,
DEFAULT_STATISTICS_TRUNCATE_LENGTH, ParquetProperties.DEFAULT_PAGE_WRITE_CHECKSUM_ENABLED);
- writer.start();
+ try {
+ writer.start();
+ } catch (Exception e) {
+ closeParquetFileWriterQuietly(writer);
Review Comment:
Done: `closeParquetFileWriterQuietly` captures the current writer and immediately clears the field before attempting cleanup. The close tests assert that the field is cleared even when finalization or cleanup fails.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -505,32 +541,66 @@ private void addNullColumn(ColumnDescriptor descriptor, long totalChunkValues, E
new ColumnChunkPageWriteStore(compressor, newSchema, props.getAllocator(), props.getColumnIndexTruncateLength(), props.getPageWriteChecksumEnabled(), null, numBlocksRewritten);
ColumnWriteStore cStore = props.newColumnWriteStore(newSchema, cPageStore);
ColumnWriter cWriter = cStore.getColumnWriter(descriptor);
- int dMax = descriptor.getMaxDefinitionLevel();
-
- for (int i = 0; i < totalChunkValues; i++) {
- int rlvl = 0;
- int dlvl = 0;
- if (dlvl == dMax) {
- // since we checked ether optional or repeated, dlvl should be > 0
- if (dlvl == 0) {
- throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
- }
- // we just write one null for the whole list at the top level,
- // instead of nullify the elements in the list one by one
- if (rlvl == 0) {
- cWriter.writeNull(rlvl, dlvl - 1);
+ Throwable failure = null;
+ try {
+ int dMax = descriptor.getMaxDefinitionLevel();
+
+ for (int i = 0; i < totalChunkValues; i++) {
+ int rlvl = 0;
+ int dlvl = 0;
+ if (dlvl == dMax) {
+ // since we checked ether optional or repeated, dlvl should be > 0
+ if (dlvl == 0) {
+ throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
+ }
+ // we just write one null for the whole list at the top level,
+ // instead of nullify the elements in the list one by one
+ if (rlvl == 0) {
+ cWriter.writeNull(rlvl, dlvl - 1);
+ }
+ } else {
+ cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
Review Comment:
Replaced it with an English comment explaining the zero repetition and definition levels.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -505,32 +541,66 @@ private void addNullColumn(ColumnDescriptor descriptor, long totalChunkValues, E
new ColumnChunkPageWriteStore(compressor, newSchema, props.getAllocator(), props.getColumnIndexTruncateLength(), props.getPageWriteChecksumEnabled(), null, numBlocksRewritten);
ColumnWriteStore cStore = props.newColumnWriteStore(newSchema, cPageStore);
ColumnWriter cWriter = cStore.getColumnWriter(descriptor);
- int dMax = descriptor.getMaxDefinitionLevel();
-
- for (int i = 0; i < totalChunkValues; i++) {
- int rlvl = 0;
- int dlvl = 0;
- if (dlvl == dMax) {
- // since we checked ether optional or repeated, dlvl should be > 0
- if (dlvl == 0) {
- throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
- }
- // we just write one null for the whole list at the top level,
- // instead of nullify the elements in the list one by one
- if (rlvl == 0) {
- cWriter.writeNull(rlvl, dlvl - 1);
+ Throwable failure = null;
+ try {
+ int dMax = descriptor.getMaxDefinitionLevel();
+
+ for (int i = 0; i < totalChunkValues; i++) {
+ int rlvl = 0;
+ int dlvl = 0;
+ if (dlvl == dMax) {
+ // since we checked ether optional or repeated, dlvl should be > 0
+ if (dlvl == 0) {
+ throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
+ }
+ // we just write one null for the whole list at the top level,
+ // instead of nullify the elements in the list one by one
+ if (rlvl == 0) {
+ cWriter.writeNull(rlvl, dlvl - 1);
+ }
+ } else {
+ cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
}
- } else {
- cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
+ cStore.endRecord();
}
- cStore.endRecord();
- }
- cStore.flush();
- cPageStore.flushToFileWriter(writer);
+ cStore.flush();
+ cPageStore.flushToFileWriter(writer);
+ } catch (IOException | RuntimeException e) {
+ failure = e;
+ throw e;
+ } finally {
+ closeColumnWriters(cStore, cWriter, failure);
+ }
+ }
- cStore.close();
- cWriter.close();
+ private void closeColumnWriters(ColumnWriteStore cStore, ColumnWriter cWriter, Throwable failure) {
+ RuntimeException closeException = null;
+ try {
+ if (cStore != null) {
+ cStore.close();
+ }
+ } catch (RuntimeException re) {
+ closeException = re;
+ }
+ try {
+ if (cWriter != null) {
+ cWriter.close();
+ }
+ } catch (RuntimeException re) {
+ if (closeException == null) {
+ closeException = re;
+ } else {
+ closeException.addSuppressed(re);
+ }
+ }
+ if (closeException != null) {
+ if (failure != null) {
+ failure.addSuppressed(closeException);
+ } else {
+ throw closeException;
+ }
+ }
Review Comment:
`cWriter` is a method-local variable, so clearing it would not change the caller's state. I simplified this path to try-with-resources using close-method adapters for the column store and writer. Java now handles cleanup and suppressed exceptions, and the custom `closeColumnWriters` helper has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5758592701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f8affff7793984a7a323988ac54598155842364f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060361891
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
In this case, let's track this in a separate issue if your intention is to fix separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5760073842
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
}, {
"hash" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17223",
"triggerID" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f8affff7793984a7a323988ac54598155842364f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222)
* f0708d42dc518830a6d0470470e15b919467e1ca Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17223)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4542939951
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 33 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5332648468
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 400 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486805621
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `42.65403%` with `121 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.59%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 24.00% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 31 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 46.59% -21.56%
+ Complexity 29149 15334 -13815
=============================================
Files 2521 1972 -549
Lines 141353 107844 -33509
Branches 17549 13099 -4450
=============================================
- Hits 96341 50253 -46088
- Misses 37079 52308 +15229
+ Partials 7933 5283 -2650
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <18.48%> (-11.82%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `74.25% <0.00%> (-16.84%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `67.93% <30.76%> (-9.94%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1666 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486998487
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.09%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.09% -0.07%
- Complexity 29149 29200 +51
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96556 +215
- Misses 37079 37298 +219
- Partials 7933 7945 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <38.38%> (-0.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <41.70%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [38 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495315213
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.72%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|2|
>|spark-scala-tests|12|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 47.72% -20.44%
+ Complexity 29149 16766 -12383
=============================================
Files 2521 2037 -484
Lines 141353 115532 -25821
Branches 17549 14838 -2711
=============================================
- Hits 96341 55133 -41208
- Misses 37079 54441 +17362
+ Partials 7933 5958 -1975
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <8.09%> (-16.40%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `69.38% <0.00%> (-17.85%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `81.18% <0.00%> (-9.91%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `69.83% <30.76%> (-8.04%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1577 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495443084
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.07%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.07% -0.09%
- Complexity 29149 29257 +108
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96618 +277
- Misses 37079 37368 +289
- Partials 7933 7953 +20
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <39.52%> (-0.43%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.71% <42.85%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `60.86% <100.00%> (-2.18%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [73 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495470198
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.11%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.11% -0.04%
- Complexity 29149 29278 +129
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96684 +343
- Misses 37079 37297 +218
- Partials 7933 7958 +25
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <39.52%> (-0.19%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <42.85%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [58 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r3272595614
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroHFileWriter.java:
##########
@@ -105,8 +106,14 @@ public HoodieAvroHFileWriter(String instantTime, StoragePath file, HoodieHFileCo
.build();
StorageConfiguration<Configuration> storageConf = new HadoopStorageConfiguration(conf);
StoragePath filePath = new StoragePath(this.file.toUri());
- OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
- this.writer = new HFileWriterImpl(context, outputStream);
+ OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
+ try {
+ this.writer = new HFileWriterImpl(context, outputStream);
+ } finally {
+ if (this.writer == null) {
+ closeQuietly(outputStream);
Review Comment:
🤖 The `try { ... } finally { if (this.writer == null) closeQuietly(outputStream); }` only protects the `HFileWriterImpl` constructor. If `writer.appendFileInfo(...)` on line 116-117 throws (or any later constructor line), `this.writer` is non-null but the constructor exits, leaving the writer (and its underlying output stream) leaked since the caller never gets a reference. Could the try region cover the rest of the constructor, or close `this.writer` itself on failure?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
+ this.writer.close();
Review Comment:
🤖 This only catches `IOException` — if `writer.close()` throws a `RuntimeException`, it propagates out of `closeWriterAfterFailure` and replaces the original failure passed in via `failure`. Could we route this through `AutoCloseableUtils.closeQuietlyWithSuppressed(writer, failure)` for consistency with the other handles?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
Review Comment:
🤖 nit: this handle re-implements the same close-and-suppress logic instead of reusing the new `AutoCloseableUtils.closeQuietlyWithSuppressed` that the other handles in this PR adopted — could you switch to the shared util for consistency?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
🤖 Closing `writer` here makes the handle inconsistent: `recordList` may still hold buffered records from earlier successful writes, and if a caller (or finally-block) later invokes `close()`, `appendDataAndDeleteBlocks` will hit `writer.appendBlocks(blocks)` with a null writer, then the catch block at line 519 will dereference `writer.getLogFile().getPath()` and throw a second NPE that replaces the original exception. Could we either skip closing the writer here, or also clear/flush `recordList` so the subsequent `close()` no-ops?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -147,17 +154,42 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
@Override
public void close() throws IOException {
+ if (writer == null) {
+ return;
+ }
Map<String, String> extraMetaData = finalizeMetadata();
extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
extraMetaData.remove("parquet.avro.schema");
extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ try {
+ writer.end(extraMetaData);
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(ParquetFileWriter parquetFileWriter) {
+ if (parquetFileWriter == null) {
+ return;
+ }
+ Method closeMethod;
+ try {
+ // ParquetFileWriter does not implement Closeable in all versions, so attempt close() reflectively.
+ closeMethod = parquetFileWriter.getClass().getMethod("close");
+ } catch (NoSuchMethodException e) {
+ return;
Review Comment:
🤖 nit: the comment explains *what* the reflection does but not *why* — could you call out which Parquet versions are missing `close()` here? Otherwise a future reader is likely to delete the reflection thinking it's gratuitous.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -485,10 +483,30 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
Review Comment:
🤖 nit: `keyToNewRecords` / `writtenRecordKeys` are already nulled inside the try-block on the success path — duplicating the assignment in `finally` is harmless but a bit noisy. Could the finally just rely on the try-block, or alternatively drop the success-path assignment and keep only the finally?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059139627
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterQuietly(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting {}. Using {} mills", this.path, timer.endTimer());
}
+ private void closeWriterQuietly(Throwable failure) {
+ markClosed();
+ CloseableUtils.closeSuppressing(writer::close, failure);
Review Comment:
🤖 This now drives `HoodieParquetFileBinaryCopier.close()` on the failure path, where `super.close()` → `writer.end()` runs *before* `prefetchExecutor.shutdownNow()`. If `end()` throws on the half-written file (fairly likely after a mid-row-group failure), the non-daemon single-thread executor and any in-flight prefetch stream are never shut down. Could the copier's `close()` shut down the executor in a `finally` (or before `super.close()`) so this cleanup path doesn't leak the thread?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -532,13 +532,14 @@ public Pair<ByteArrayOutputStream, Object> serializeRecordsToLogBlock(HoodieStor
HoodieFileWriter parquetWriter = HoodieFileWriterFactory.getFileWriter(
HoodieFileFormat.PARQUET, outputStream, storage, config, writerSchema, recordType);
- while (recordItr.hasNext()) {
- HoodieRecord record = recordItr.next();
- String recordKey = record.getRecordKey(readerSchema, keyFieldName);
- parquetWriter.write(recordKey, record, writerSchema);
+ try (HoodieFileWriter writerToClose = parquetWriter) {
+ while (recordItr.hasNext()) {
+ HoodieRecord record = recordItr.next();
Review Comment:
🤖 nit: `writerToClose` and `parquetWriter` refer to the same object inside the try block — using two names for one variable is a bit confusing. Consider just declaring `try (HoodieFileWriter parquetWriter = HoodieFileWriterFactory.getFileWriter(...))` directly instead of introducing the extra alias.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -506,10 +502,32 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
Review Comment:
🤖 If `writeIncomingRecords()` or `closeFileWriter()` throws, the `((Closeable) keyToNewRecords).close()` line above is skipped, and this `finally` then drops the reference — so an `ExternalSpillableMap`'s on-disk spill files are never cleaned up. Since `closeFileWriterQuietly` already handles the file writer on failure, could it also `closeSuppressing` `keyToNewRecords` when it's `Closeable`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroHFileWriter.java:
##########
@@ -106,11 +107,17 @@ public HoodieAvroHFileWriter(String instantTime, StoragePath file, HoodieHFileCo
.build();
StorageConfiguration<Configuration> storageConf = new HadoopStorageConfiguration(conf);
StoragePath filePath = new StoragePath(this.file.toUri());
- OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
- this.writer = new HFileWriterImpl(context, outputStream);
- this.prevRecordKey = "";
- writer.appendFileInfo(
- HoodieAvroHFileReaderImplBase.SCHEMA_KEY, getUTF8Bytes(schema.toString()));
+ OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
+ try {
+ this.writer = new HFileWriterImpl(context, outputStream);
+ this.prevRecordKey = "";
+ writer.appendFileInfo(
+ HoodieAvroHFileReaderImplBase.SCHEMA_KEY, getUTF8Bytes(schema.toString()));
+ } catch (RuntimeException e) {
Review Comment:
🤖 nit: the ternary `writer != null ? writer : outputStream` to decide what to close is a little subtle — worth a one-line comment explaining that `writer` may not have been assigned yet if the `HFileWriterImpl` constructor itself threw, so we fall back to closing the raw stream.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5755158823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ee5fbfc27b817000680fd48b891f2898a5d3244 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146)
* d37141ee273de412f09eb0bf11d7563cdf71ab00 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5757153502
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37141ee273de412f09eb0bf11d7563cdf71ab00 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219)
* f8affff7793984a7a323988ac54598155842364f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4494991782
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7da5bc4d5d2637d3747297a649d3343acf24003 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102)
* 1ee5fbfc27b817000680fd48b891f2898a5d3244 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486826570
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.58%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|2|
>|spark-scala-tests|12|3|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 58.58% -9.58%
+ Complexity 29149 24640 -4509
============================================
Files 2521 2505 -16
Lines 141353 139234 -2119
Branches 17549 17056 -493
============================================
- Hits 96341 81572 -14769
- Misses 37079 50518 +13439
+ Partials 7933 7144 -789
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <8.05%> (-16.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <18.48%> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [695 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495372311
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.23256%` with `107 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.78%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|6|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.78% -7.38%
+ Complexity 29149 26096 -3053
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 86274 -10067
- Misses 37079 48080 +11001
+ Partials 7933 7585 -348
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.40% <8.09%> (-17.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.57%> (-12.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495573610
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495447296
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.10%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.10% -0.06%
- Complexity 29149 29270 +121
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96668 +327
- Misses 37079 37316 +237
- Partials 7933 7955 +22
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <39.52%> (-0.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <42.85%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [59 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5339424599
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 405 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r3285477807
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/BaseCreateHandle.java:
##########
@@ -168,6 +170,11 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T> record, HoodieSchema sc
return record.prependMetaFields(schema, targetSchema, metadataValues, prop);
}
+ private void closeFileWriterQuietly(Throwable failure) {
Review Comment:
did you intentionally not call `markClosed()` here or its an oversight.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoCloseableUtils.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoCloseableUtils {
+
+ private static final Logger LOG = LoggerFactory.getLogger(AutoCloseableUtils.class);
+
+ private AutoCloseableUtils() {
+ }
+
+ public static void closeWithSuppressed(AutoCloseable closeable, Throwable failure) throws IOException {
+ if (closeable == null) {
+ return;
+ }
+ try {
+ closeable.close();
+ } catch (IOException ioe) {
+ if (failure != null) {
+ failure.addSuppressed(ioe);
+ } else {
+ throw ioe;
+ }
+ } catch (RuntimeException re) {
+ if (failure != null) {
+ failure.addSuppressed(re);
+ } else {
+ throw re;
+ }
+ } catch (Exception e) {
+ if (failure != null) {
+ failure.addSuppressed(e);
+ } else {
+ throw new IOException("Failed to close resource", e);
+ }
+ }
+ }
+
+ public static void closeQuietlyWithSuppressed(AutoCloseable closeable, Throwable failure) {
+ try {
+ closeWithSuppressed(closeable, failure);
+ } catch (IOException | RuntimeException e) {
Review Comment:
should we also add `Exception` here.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetStreamWriter.java:
##########
@@ -35,23 +35,30 @@
import java.io.IOException;
+import static org.apache.hudi.io.util.FileIOUtils.closeQuietly;
+
public class HoodieSparkParquetStreamWriter implements HoodieSparkFileWriter, AutoCloseable {
private final ParquetWriter<InternalRow> writer;
private final HoodieRowParquetWriteSupport writeSupport;
public HoodieSparkParquetStreamWriter(FSDataOutputStream outputStream,
HoodieRowParquetConfig parquetConfig) throws IOException {
this.writeSupport = parquetConfig.getWriteSupport();
- this.writer = new Builder<>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
- .withWriteMode(ParquetFileWriter.Mode.CREATE)
- .withCompressionCodec(parquetConfig.getCompressionCodecName())
- .withRowGroupSize(parquetConfig.getBlockSize())
- .withPageSize(parquetConfig.getPageSize())
- .withDictionaryPageSize(parquetConfig.getPageSize())
- .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
- .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
- .withConf(parquetConfig.getHadoopConf())
- .build();
+ try {
+ this.writer = new Builder<>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
+ .withWriteMode(ParquetFileWriter.Mode.CREATE)
+ .withCompressionCodec(parquetConfig.getCompressionCodecName())
+ .withRowGroupSize(parquetConfig.getBlockSize())
+ .withPageSize(parquetConfig.getPageSize())
+ .withDictionaryPageSize(parquetConfig.getPageSize())
+ .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
+ .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
+ .withConf(parquetConfig.getHadoopConf())
+ .build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
same here
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
Review Comment:
how about `closeWriterQuietly` to be in line w/ other naming in this patch
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieParquetStreamWriter.java:
##########
@@ -49,16 +51,21 @@ public class HoodieParquetStreamWriter implements HoodieAvroFileWriter, AutoClos
public HoodieParquetStreamWriter(FSDataOutputStream outputStream,
HoodieParquetConfig<HoodieAvroWriteSupport> parquetConfig) throws IOException {
this.writeSupport = parquetConfig.getWriteSupport();
- this.writer = new Builder<IndexedRecord>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
- .withWriteMode(ParquetFileWriter.Mode.CREATE)
- .withCompressionCodec(parquetConfig.getCompressionCodecName())
- .withRowGroupSize(parquetConfig.getBlockSize())
- .withPageSize(parquetConfig.getPageSize())
- .withDictionaryPageSize(parquetConfig.getPageSize())
- .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
- .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
- .withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class))
- .build();
+ try {
+ this.writer = new Builder<IndexedRecord>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
+ .withWriteMode(ParquetFileWriter.Mode.CREATE)
+ .withCompressionCodec(parquetConfig.getCompressionCodecName())
+ .withRowGroupSize(parquetConfig.getBlockSize())
+ .withPageSize(parquetConfig.getPageSize())
+ .withDictionaryPageSize(parquetConfig.getPageSize())
+ .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
+ .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
+ .withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class))
+ .build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
lets standardize all naming.
`closeOutputStreamQuietly`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoCloseableUtils.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoCloseableUtils {
Review Comment:
do we have UTs for this class?
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetOutputStreamWriter.java:
##########
@@ -67,7 +69,12 @@ protected WriteSupport getWriteSupport(Configuration conf) {
parquetWriterbuilder.withDictionaryEncoding(parquetConfig.isDictionaryEnabled());
parquetWriterbuilder.withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION);
parquetWriterbuilder.withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class));
- this.writer = parquetWriterbuilder.build();
+ try {
+ this.writer = parquetWriterbuilder.build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
lets get the naming consistent across all writers.
`closeFileOutputStreamQuietly`
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -137,7 +138,13 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
ParquetFileWriter.Mode writerMode = ParquetFileWriter.Mode.CREATE;
writer = new ParquetFileWriter(HadoopOutputFile.fromPath(outPutFile, conf), schema, writerMode, DEFAULT_BLOCK_SIZE, MAX_PADDING_SIZE_DEFAULT, DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH,
DEFAULT_STATISTICS_TRUNCATE_LENGTH, ParquetProperties.DEFAULT_PAGE_WRITE_CHECKSUM_ENABLED);
- writer.start();
+ try {
+ writer.start();
+ } catch (Exception e) {
+ closeParquetFileWriterQuietly(writer);
Review Comment:
shouldn't we set the `writer = null` w/n closeParquetFileWriterQuietly
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroHFileWriter.java:
##########
@@ -105,8 +106,14 @@ public HoodieAvroHFileWriter(String instantTime, StoragePath file, HoodieHFileCo
.build();
StorageConfiguration<Configuration> storageConf = new HadoopStorageConfiguration(conf);
StoragePath filePath = new StoragePath(this.file.toUri());
- OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
- this.writer = new HFileWriterImpl(context, outputStream);
+ OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
+ try {
+ this.writer = new HFileWriterImpl(context, outputStream);
+ } finally {
+ if (this.writer == null) {
+ closeQuietly(outputStream);
Review Comment:
+1
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
+ this.writer.close();
Review Comment:
+1
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
Review Comment:
+1
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -505,32 +541,66 @@ private void addNullColumn(ColumnDescriptor descriptor, long totalChunkValues, E
new ColumnChunkPageWriteStore(compressor, newSchema, props.getAllocator(), props.getColumnIndexTruncateLength(), props.getPageWriteChecksumEnabled(), null, numBlocksRewritten);
ColumnWriteStore cStore = props.newColumnWriteStore(newSchema, cPageStore);
ColumnWriter cWriter = cStore.getColumnWriter(descriptor);
- int dMax = descriptor.getMaxDefinitionLevel();
-
- for (int i = 0; i < totalChunkValues; i++) {
- int rlvl = 0;
- int dlvl = 0;
- if (dlvl == dMax) {
- // since we checked ether optional or repeated, dlvl should be > 0
- if (dlvl == 0) {
- throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
- }
- // we just write one null for the whole list at the top level,
- // instead of nullify the elements in the list one by one
- if (rlvl == 0) {
- cWriter.writeNull(rlvl, dlvl - 1);
+ Throwable failure = null;
+ try {
+ int dMax = descriptor.getMaxDefinitionLevel();
+
+ for (int i = 0; i < totalChunkValues; i++) {
+ int rlvl = 0;
+ int dlvl = 0;
+ if (dlvl == dMax) {
+ // since we checked ether optional or repeated, dlvl should be > 0
+ if (dlvl == 0) {
+ throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
+ }
+ // we just write one null for the whole list at the top level,
+ // instead of nullify the elements in the list one by one
+ if (rlvl == 0) {
+ cWriter.writeNull(rlvl, dlvl - 1);
+ }
+ } else {
+ cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
Review Comment:
sorry. can we avoid comments in non english language. I understand it was not from this patch.
but lets fix it.
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -175,27 +176,65 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeWriter(indexByPartitionWriter, null);
+ failure = closeWriter(indexByFileIdWriter, failure);
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
}
}
@Override
public void begin() {
try {
HFileContext context = HFileContext.builder().build();
- OutputStream outputStreamForPartitionWriter = metaClient.getStorage().create(indexByPartitionPath);
- this.indexByPartitionWriter = new HFileWriterImpl(context, outputStreamForPartitionWriter);
- OutputStream outputStreamForFileIdWriter = metaClient.getStorage().create(indexByFileIdPath);
- this.indexByFileIdWriter = new HFileWriterImpl(context, outputStreamForFileIdWriter);
+ this.indexByPartitionWriter = createHFileWriter(indexByPartitionPath, context);
+ this.indexByFileIdWriter = createHFileWriter(indexByFileIdPath, context);
} catch (IOException ioe) {
+ closeAfterFailedBegin(ioe);
throw new HoodieIOException(ioe.getMessage(), ioe);
+ } catch (RuntimeException re) {
+ closeAfterFailedBegin(re);
+ throw re;
+ }
+ }
+
+ private HFileWriter createHFileWriter(StoragePath path, HFileContext context) throws IOException {
+ OutputStream outputStream = metaClient.getStorage().create(path);
+ HFileWriter writer = null;
+ try {
+ writer = new HFileWriterImpl(context, outputStream);
+ return writer;
+ } finally {
+ if (writer == null) {
+ closeQuietly(outputStream);
+ }
+ }
+ }
+
+ private Exception closeWriter(HFileWriter writer, Exception failure) {
Review Comment:
`closeHfileWriter`
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -175,27 +176,65 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeWriter(indexByPartitionWriter, null);
+ failure = closeWriter(indexByFileIdWriter, failure);
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
}
}
@Override
public void begin() {
try {
HFileContext context = HFileContext.builder().build();
- OutputStream outputStreamForPartitionWriter = metaClient.getStorage().create(indexByPartitionPath);
- this.indexByPartitionWriter = new HFileWriterImpl(context, outputStreamForPartitionWriter);
- OutputStream outputStreamForFileIdWriter = metaClient.getStorage().create(indexByFileIdPath);
- this.indexByFileIdWriter = new HFileWriterImpl(context, outputStreamForFileIdWriter);
+ this.indexByPartitionWriter = createHFileWriter(indexByPartitionPath, context);
+ this.indexByFileIdWriter = createHFileWriter(indexByFileIdPath, context);
} catch (IOException ioe) {
+ closeAfterFailedBegin(ioe);
throw new HoodieIOException(ioe.getMessage(), ioe);
+ } catch (RuntimeException re) {
+ closeAfterFailedBegin(re);
+ throw re;
+ }
+ }
+
+ private HFileWriter createHFileWriter(StoragePath path, HFileContext context) throws IOException {
+ OutputStream outputStream = metaClient.getStorage().create(path);
+ HFileWriter writer = null;
+ try {
+ writer = new HFileWriterImpl(context, outputStream);
+ return writer;
+ } finally {
+ if (writer == null) {
+ closeQuietly(outputStream);
+ }
+ }
+ }
+
+ private Exception closeWriter(HFileWriter writer, Exception failure) {
+ if (writer == null) {
+ return failure;
+ }
+ try {
+ writer.close();
+ } catch (IOException | RuntimeException e) {
+ if (failure == null) {
+ return e;
+ }
+ failure.addSuppressed(e);
+ }
+ return failure;
Review Comment:
shouldn't we set the `writer = null` at the end of the method
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -505,32 +541,66 @@ private void addNullColumn(ColumnDescriptor descriptor, long totalChunkValues, E
new ColumnChunkPageWriteStore(compressor, newSchema, props.getAllocator(), props.getColumnIndexTruncateLength(), props.getPageWriteChecksumEnabled(), null, numBlocksRewritten);
ColumnWriteStore cStore = props.newColumnWriteStore(newSchema, cPageStore);
ColumnWriter cWriter = cStore.getColumnWriter(descriptor);
- int dMax = descriptor.getMaxDefinitionLevel();
-
- for (int i = 0; i < totalChunkValues; i++) {
- int rlvl = 0;
- int dlvl = 0;
- if (dlvl == dMax) {
- // since we checked ether optional or repeated, dlvl should be > 0
- if (dlvl == 0) {
- throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
- }
- // we just write one null for the whole list at the top level,
- // instead of nullify the elements in the list one by one
- if (rlvl == 0) {
- cWriter.writeNull(rlvl, dlvl - 1);
+ Throwable failure = null;
+ try {
+ int dMax = descriptor.getMaxDefinitionLevel();
+
+ for (int i = 0; i < totalChunkValues; i++) {
+ int rlvl = 0;
+ int dlvl = 0;
+ if (dlvl == dMax) {
+ // since we checked ether optional or repeated, dlvl should be > 0
+ if (dlvl == 0) {
+ throw new IOException("definition level is detected to be 0 for column " + Arrays.stream(descriptor.getPath()).collect(Collectors.joining(".")) + " to be nullified");
+ }
+ // we just write one null for the whole list at the top level,
+ // instead of nullify the elements in the list one by one
+ if (rlvl == 0) {
+ cWriter.writeNull(rlvl, dlvl - 1);
+ }
+ } else {
+ cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
}
- } else {
- cWriter.writeNull(rlvl, dlvl); // 因为repeatition level没有重复所以后面都是以0在第一层,definition level是字段path的第0层
+ cStore.endRecord();
}
- cStore.endRecord();
- }
- cStore.flush();
- cPageStore.flushToFileWriter(writer);
+ cStore.flush();
+ cPageStore.flushToFileWriter(writer);
+ } catch (IOException | RuntimeException e) {
+ failure = e;
+ throw e;
+ } finally {
+ closeColumnWriters(cStore, cWriter, failure);
+ }
+ }
- cStore.close();
- cWriter.close();
+ private void closeColumnWriters(ColumnWriteStore cStore, ColumnWriter cWriter, Throwable failure) {
+ RuntimeException closeException = null;
+ try {
+ if (cStore != null) {
+ cStore.close();
+ }
+ } catch (RuntimeException re) {
+ closeException = re;
+ }
+ try {
+ if (cWriter != null) {
+ cWriter.close();
+ }
+ } catch (RuntimeException re) {
+ if (closeException == null) {
+ closeException = re;
+ } else {
+ closeException.addSuppressed(re);
+ }
+ }
+ if (closeException != null) {
+ if (failure != null) {
+ failure.addSuppressed(closeException);
+ } else {
+ throw closeException;
+ }
+ }
Review Comment:
should we set `cWriter = null` in the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5755998370
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37141ee273de412f09eb0bf11d7563cdf71ab00 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4061547993
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
Review Comment:
Regular cleaner is not a guaranteed cleanup path: it filters committed slices and retains the latest slice of each file group, so an orphan with a fresh file ID may be retained. Listing-based rollback can remove files for a rolled-back instant, but a successful task retry need not roll back that instant. Tracked in #20017, including the cleaner/rollback caveats and the end-to-end validation still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4061545815
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
Tracked in #20016, including propagating stored Disruptor consumer failures at the executor boundary and preserving the original exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060375253
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
Review Comment:
Is the orphan-output cleanup handled when cleaner runs? If not, it'll be good if we can call it out in a issue to track this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486331173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f4784f2c99e6fdda274f8ed2a7f68e39c360310 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101)
* a7da5bc4d5d2637d3747297a649d3343acf24003 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486983590
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.06%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.06% -0.10%
- Complexity 29149 29189 +40
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96516 +175
- Misses 37079 37352 +273
+ Partials 7933 7931 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <38.38%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <41.70%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [44 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r3267048836
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -147,17 +154,41 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
@Override
public void close() throws IOException {
+ if (writer == null) {
+ return;
+ }
Map<String, String> extraMetaData = finalizeMetadata();
extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
extraMetaData.remove("parquet.avro.schema");
extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ try {
+ writer.end(extraMetaData);
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(ParquetFileWriter parquetFileWriter) {
+ if (parquetFileWriter == null) {
+ return;
+ }
+ Method closeMethod;
Review Comment:
🤖 nit: the reflection here is non-obvious — it might be worth adding a one-line comment like `// ParquetFileWriter doesn't implement Closeable in all versions, so we attempt close() reflectively` so future readers understand why a direct cast to AutoCloseable wasn't used.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoClosableUtils.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoClosableUtils {
+
+ private static final Logger LOG = LoggerFactory.getLogger(AutoClosableUtils.class);
+
+ private AutoClosableUtils() {
+ }
+
+ public static void closeWithSuppressed(AutoCloseable closeable, Throwable failure) throws IOException {
+ if (closeable == null) {
+ return;
+ }
+ try {
+ closeable.close();
+ } catch (IOException ioe) {
+ if (failure != null) {
+ failure.addSuppressed(ioe);
+ } else {
+ throw ioe;
+ }
+ } catch (RuntimeException re) {
+ if (failure != null) {
+ failure.addSuppressed(re);
+ } else {
+ throw re;
+ }
+ } catch (Exception e) {
+ if (failure != null) {
+ failure.addSuppressed(e);
+ } else {
+ throw new IOException("Failed to close resource", e);
+ }
+ }
+ }
+
+ public static void closeQuietlyWithSuppressed(AutoCloseable closeable, Throwable failure) {
+ try {
+ closeWithSuppressed(closeable, failure);
+ } catch (IOException | RuntimeException e) {
+ if (failure != null) {
Review Comment:
🤖 Minor: this `if (failure != null)` branch looks unreachable — `closeWithSuppressed` only throws when `failure == null` (when failure is non-null it always routes exceptions to `failure.addSuppressed`). The catch block here is only entered when failure is null, so the LOG.warn branch is the only reachable one. Could simplify to just `LOG.warn(...)`.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495358339
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.23256%` with `107 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.52%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|5|
>|spark-scala-tests|12|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.52% -7.64%
+ Complexity 29149 25932 -3217
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 85907 -10434
- Misses 37079 48543 +11464
+ Partials 7933 7489 -444
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <8.09%> (-17.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <18.57%> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495342659
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.88%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|5|
>|spark-scala-tests|12|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 53.88% -14.28%
+ Complexity 29149 18738 -10411
=============================================
Files 2521 2037 -484
Lines 141353 115532 -25821
Branches 17549 14838 -2711
=============================================
- Hits 96341 62251 -34090
- Misses 37079 46720 +9641
+ Partials 7933 6561 -1372
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <8.09%> (-17.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `69.38% <0.00%> (-17.85%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `81.18% <0.00%> (-9.91%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `69.83% <30.76%> (-8.04%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1444 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495473828
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.13%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 68.13% -0.03%
- Complexity 29149 29284 +135
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96704 +363
- Misses 37079 37275 +196
- Partials 7933 7960 +27
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <39.52%> (-0.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <42.85%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [54 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5347220936
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 405 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059110740
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
Review Comment:
Renamed to `closeWriterQuietly` and switched its cleanup to the shared `CloseableUtils.closeSuppressing` helper.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoCloseableUtils.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoCloseableUtils {
Review Comment:
Yes. After rebasing, I replaced this duplicate utility with the existing `CloseableUtils` in hudi-common and extended `TestCloseableUtils`. It covers null/successful close, checked and runtime exceptions, errors, and self-suppression. All 60 selected tests passed, including the create/append cleanup and Parquet binary-copy tests.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoCloseableUtils.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoCloseableUtils {
+
+ private static final Logger LOG = LoggerFactory.getLogger(AutoCloseableUtils.class);
+
+ private AutoCloseableUtils() {
+ }
+
+ public static void closeWithSuppressed(AutoCloseable closeable, Throwable failure) throws IOException {
+ if (closeable == null) {
+ return;
+ }
+ try {
+ closeable.close();
+ } catch (IOException ioe) {
+ if (failure != null) {
+ failure.addSuppressed(ioe);
+ } else {
+ throw ioe;
+ }
+ } catch (RuntimeException re) {
+ if (failure != null) {
+ failure.addSuppressed(re);
+ } else {
+ throw re;
+ }
+ } catch (Exception e) {
+ if (failure != null) {
+ failure.addSuppressed(e);
+ } else {
+ throw new IOException("Failed to close resource", e);
+ }
+ }
+ }
+
+ public static void closeQuietlyWithSuppressed(AutoCloseable closeable, Throwable failure) {
+ try {
+ closeWithSuppressed(closeable, failure);
+ } catch (IOException | RuntimeException e) {
Review Comment:
The duplicate utility has now been removed. These call sites use the existing `CloseableUtils.closeSuppressing`, which catches `Throwable` and attaches close failures to the original exception, so checked `Exception` is covered as well. `TestCloseableUtils` explicitly tests checked exceptions, runtime exceptions, and errors.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetOutputStreamWriter.java:
##########
@@ -67,7 +69,12 @@ protected WriteSupport getWriteSupport(Configuration conf) {
parquetWriterbuilder.withDictionaryEncoding(parquetConfig.isDictionaryEnabled());
parquetWriterbuilder.withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION);
parquetWriterbuilder.withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class));
- this.writer = parquetWriterbuilder.build();
+ try {
+ this.writer = parquetWriterbuilder.build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
The Flink, Spark, and Hadoop stream writers all use the same existing `FileIOUtils.closeQuietly(outputStream)` helper. I retained that shared name so the three call sites stay consistent without adding a separate stream-specific wrapper to each class.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetStreamWriter.java:
##########
@@ -35,23 +35,30 @@
import java.io.IOException;
+import static org.apache.hudi.io.util.FileIOUtils.closeQuietly;
+
public class HoodieSparkParquetStreamWriter implements HoodieSparkFileWriter, AutoCloseable {
private final ParquetWriter<InternalRow> writer;
private final HoodieRowParquetWriteSupport writeSupport;
public HoodieSparkParquetStreamWriter(FSDataOutputStream outputStream,
HoodieRowParquetConfig parquetConfig) throws IOException {
this.writeSupport = parquetConfig.getWriteSupport();
- this.writer = new Builder<>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
- .withWriteMode(ParquetFileWriter.Mode.CREATE)
- .withCompressionCodec(parquetConfig.getCompressionCodecName())
- .withRowGroupSize(parquetConfig.getBlockSize())
- .withPageSize(parquetConfig.getPageSize())
- .withDictionaryPageSize(parquetConfig.getPageSize())
- .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
- .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
- .withConf(parquetConfig.getHadoopConf())
- .build();
+ try {
+ this.writer = new Builder<>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
+ .withWriteMode(ParquetFileWriter.Mode.CREATE)
+ .withCompressionCodec(parquetConfig.getCompressionCodecName())
+ .withRowGroupSize(parquetConfig.getBlockSize())
+ .withPageSize(parquetConfig.getPageSize())
+ .withDictionaryPageSize(parquetConfig.getPageSize())
+ .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
+ .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
+ .withConf(parquetConfig.getHadoopConf())
+ .build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
This uses the same `FileIOUtils.closeQuietly(outputStream)` helper as the Flink and Hadoop stream writers. I retained the common helper name consistently across all three.
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -175,27 +176,65 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeWriter(indexByPartitionWriter, null);
+ failure = closeWriter(indexByFileIdWriter, failure);
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
}
}
@Override
public void begin() {
try {
HFileContext context = HFileContext.builder().build();
- OutputStream outputStreamForPartitionWriter = metaClient.getStorage().create(indexByPartitionPath);
- this.indexByPartitionWriter = new HFileWriterImpl(context, outputStreamForPartitionWriter);
- OutputStream outputStreamForFileIdWriter = metaClient.getStorage().create(indexByFileIdPath);
- this.indexByFileIdWriter = new HFileWriterImpl(context, outputStreamForFileIdWriter);
+ this.indexByPartitionWriter = createHFileWriter(indexByPartitionPath, context);
+ this.indexByFileIdWriter = createHFileWriter(indexByFileIdPath, context);
} catch (IOException ioe) {
+ closeAfterFailedBegin(ioe);
throw new HoodieIOException(ioe.getMessage(), ioe);
+ } catch (RuntimeException re) {
+ closeAfterFailedBegin(re);
+ throw re;
+ }
+ }
+
+ private HFileWriter createHFileWriter(StoragePath path, HFileContext context) throws IOException {
+ OutputStream outputStream = metaClient.getStorage().create(path);
+ HFileWriter writer = null;
+ try {
+ writer = new HFileWriterImpl(context, outputStream);
+ return writer;
+ } finally {
+ if (writer == null) {
+ closeQuietly(outputStream);
+ }
+ }
+ }
+
+ private Exception closeWriter(HFileWriter writer, Exception failure) {
Review Comment:
Renamed to `closeHFileWriter`, matching the `HFileWriter` type's spelling.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieParquetStreamWriter.java:
##########
@@ -49,16 +51,21 @@ public class HoodieParquetStreamWriter implements HoodieAvroFileWriter, AutoClos
public HoodieParquetStreamWriter(FSDataOutputStream outputStream,
HoodieParquetConfig<HoodieAvroWriteSupport> parquetConfig) throws IOException {
this.writeSupport = parquetConfig.getWriteSupport();
- this.writer = new Builder<IndexedRecord>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
- .withWriteMode(ParquetFileWriter.Mode.CREATE)
- .withCompressionCodec(parquetConfig.getCompressionCodecName())
- .withRowGroupSize(parquetConfig.getBlockSize())
- .withPageSize(parquetConfig.getPageSize())
- .withDictionaryPageSize(parquetConfig.getPageSize())
- .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
- .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
- .withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class))
- .build();
+ try {
+ this.writer = new Builder<IndexedRecord>(new OutputStreamBackedOutputFile(outputStream), writeSupport)
+ .withWriteMode(ParquetFileWriter.Mode.CREATE)
+ .withCompressionCodec(parquetConfig.getCompressionCodecName())
+ .withRowGroupSize(parquetConfig.getBlockSize())
+ .withPageSize(parquetConfig.getPageSize())
+ .withDictionaryPageSize(parquetConfig.getPageSize())
+ .withDictionaryEncoding(parquetConfig.isDictionaryEnabled())
+ .withWriterVersion(ParquetWriter.DEFAULT_WRITER_VERSION)
+ .withConf(parquetConfig.getStorageConf().unwrapAs(Configuration.class))
+ .build();
+ } catch (IOException | RuntimeException e) {
+ closeQuietly(outputStream);
Review Comment:
All three stream writers use the existing `FileIOUtils.closeQuietly(outputStream)` helper. I retained that common name across Hadoop, Spark, and Flink; there are no separate per-writer close wrappers to keep in sync.
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -175,27 +176,65 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeWriter(indexByPartitionWriter, null);
+ failure = closeWriter(indexByFileIdWriter, failure);
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
}
}
@Override
public void begin() {
try {
HFileContext context = HFileContext.builder().build();
- OutputStream outputStreamForPartitionWriter = metaClient.getStorage().create(indexByPartitionPath);
- this.indexByPartitionWriter = new HFileWriterImpl(context, outputStreamForPartitionWriter);
- OutputStream outputStreamForFileIdWriter = metaClient.getStorage().create(indexByFileIdPath);
- this.indexByFileIdWriter = new HFileWriterImpl(context, outputStreamForFileIdWriter);
+ this.indexByPartitionWriter = createHFileWriter(indexByPartitionPath, context);
+ this.indexByFileIdWriter = createHFileWriter(indexByFileIdPath, context);
} catch (IOException ioe) {
+ closeAfterFailedBegin(ioe);
throw new HoodieIOException(ioe.getMessage(), ioe);
+ } catch (RuntimeException re) {
+ closeAfterFailedBegin(re);
+ throw re;
+ }
+ }
+
+ private HFileWriter createHFileWriter(StoragePath path, HFileContext context) throws IOException {
+ OutputStream outputStream = metaClient.getStorage().create(path);
+ HFileWriter writer = null;
+ try {
+ writer = new HFileWriterImpl(context, outputStream);
+ return writer;
+ } finally {
+ if (writer == null) {
+ closeQuietly(outputStream);
+ }
+ }
+ }
+
+ private Exception closeWriter(HFileWriter writer, Exception failure) {
+ if (writer == null) {
+ return failure;
+ }
+ try {
+ writer.close();
+ } catch (IOException | RuntimeException e) {
+ if (failure == null) {
+ return e;
+ }
+ failure.addSuppressed(e);
+ }
+ return failure;
Review Comment:
The owning `close()` now clears both `indexByPartitionWriter` and `indexByFileIdWriter` after attempting both closes. Assigning null to the helper's `writer` parameter would only clear the local parameter, so the assignments are made on the actual fields instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060384508
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -159,24 +160,44 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
writer.start();
log.info("init writer ");
} catch (Exception e) {
+ closeParquetFileWriterQuietly(e);
log.error("failed to init parquet writer", e);
throw new HoodieException(e);
}
}
@Override
public void close() throws IOException {
- Map<String, String> extraMetaData = finalizeMetadata();
- extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
- extraMetaData.remove("parquet.avro.schema");
- extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ if (writer == null) {
+ return;
+ }
+ try {
+ Map<String, String> extraMetaData = finalizeMetadata();
+ extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
+ extraMetaData.remove("parquet.avro.schema");
+ extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
+ writer.end(extraMetaData);
+ } catch (IOException | RuntimeException e) {
+ closeParquetFileWriterQuietly(e);
+ throw e;
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(Throwable failure) {
+ // Parquet 1.12.x/1.13.x have no close(); newer versions implement AutoCloseable.
+ ParquetFileWriter parquetFileWriter = writer;
+ writer = null;
+ if (parquetFileWriter instanceof AutoCloseable) {
Review Comment:
Fair enough, the updated comment makes the 1.12/1.13 gap explicit. Resolving.
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -174,28 +176,60 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeHFileWriter(indexByPartitionWriter, null);
+ failure = closeHFileWriter(indexByFileIdWriter, failure);
+ indexByPartitionWriter = null;
+ indexByFileIdWriter = null;
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
Review Comment:
OK, no caller depends on the subtype and the cause is kept. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495324342
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.75%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|3|
>|spark-scala-tests|12|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 47.75% -20.40%
+ Complexity 29149 16776 -12373
=============================================
Files 2521 2037 -484
Lines 141353 115532 -25821
Branches 17549 14838 -2711
=============================================
- Hits 96341 55174 -41167
- Misses 37079 54410 +17331
+ Partials 7933 5948 -1985
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <8.09%> (-16.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `69.38% <0.00%> (-17.85%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `81.18% <0.00%> (-9.91%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `69.83% <30.76%> (-8.04%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1577 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486624879
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f4784f2c99e6fdda274f8ed2a7f68e39c360310 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101)
* a7da5bc4d5d2637d3747297a649d3343acf24003 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486945801
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.80%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|7|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 62.80% -5.35%
+ Complexity 29149 26885 -2264
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 89059 -7282
- Misses 37079 45202 +8123
+ Partials 7933 7538 -395
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.70% <25.11%> (-7.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.48%> (-12.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `89.10% <100.00%> (-1.99%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [423 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486085986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f4784f2c99e6fdda274f8ed2a7f68e39c360310 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486888992
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.73%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|5|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.73% -7.43%
+ Complexity 29149 26031 -3118
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 86120 -10221
- Misses 37079 48104 +11025
+ Partials 7933 7575 -358
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.85% <8.05%> (-17.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.48%> (-12.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [561 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5755197646
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ee5fbfc27b817000680fd48b891f2898a5d3244 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146)
* d37141ee273de412f09eb0bf11d7563cdf71ab00 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059224987
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieNativeLogAppendHandle.java:
##########
@@ -163,8 +163,11 @@ protected void flushAppend() {
@Override
protected void closeLogWriter() {
- if (writer != null) {
- writer.close();
+ try {
+ if (writer != null) {
+ writer.close();
+ }
+ } finally {
writer = null;
Review Comment:
**minor:** The native handle is the default log writer from table version 10 on, but the new failure test only drives `HoodieInlineLogAppendHandle` on table version SIX with `flushAppend` mocked. This `closeLogWriter` change, the `writeRecord` failure branch (`HoodieAppendHandle:401`) and `write(Map)` are not reached by any test. Not blocking, but could `TestHoodieNativeLogAppendHandle` (it already has a `createWriter` harness) get a case where `writer.close()` throws, asserting `isClosed()`, a null `writer` and a single close?
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/SparkHelpers.scala:
##########
@@ -72,14 +72,17 @@ object SparkHelpers {
conf.unwrap().setClassLoader(Thread.currentThread.getContextClassLoader)
val writer = new HoodieAvroParquetWriter(destinationFile, parquetConfig, instantTime, new SparkTaskContextSupplier(), true)
- for (rec <- sourceRecords) {
- val key: String = rec.get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString
- if (!keysToSkip.contains(key)) {
+ try {
+ for (rec <- sourceRecords) {
+ val key: String = rec.get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString
+ if (!keysToSkip.contains(key)) {
- writer.writeAvro(key, rec)
+ writer.writeAvro(key, rec)
+ }
}
+ } finally {
+ writer.close()
Review Comment:
**minor:** A Scala `finally { writer.close() }` replaces the original write exception with any exception from `close()`, which is likely on a writer that just failed. The Java handles in this PR use `CloseableUtils.closeSuppressing` for exactly this. Not blocking, but could this be `catch { case t: Throwable => CloseableUtils.closeSuppressing(writer, t); throw t }` with `writer.close()` on the success path?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterQuietly(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting {}. Using {} mills", this.path, timer.endTimer());
}
+ private void closeWriterQuietly(Throwable failure) {
+ markClosed();
+ CloseableUtils.closeSuppressing(writer::close, failure);
Review Comment:
**minor:** `HoodieParquetFileBinaryCopier.close()` (lines 250-257) calls `super.close()` before `prefetchExecutor.shutdownNow()` with no `finally`, so when `end()` throws here the non-daemon executor thread (created at line 202) and the current input `reader` leak once per failed handle. This path now reaches that `close()`. Not blocking, but could the executor shutdown and reader close move into a `finally` around `super.close()`?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
Review Comment:
**major:** This failure path calls `copier.close()`, which is the success finalizer (`finalizeMetadata()` + `writer.end()`). If the failure happens between row groups (e.g. the prefetch `IOException` in `HoodieParquetFileBinaryCopier.initNextReader`), `end()` succeeds and leaves a partial file with a valid footer. This handle creates no write marker, and `SparkBinaryCopyClusteringExecutionStrategy:136` gives a retry a new fileId, so nothing reconciles the orphan; before this change it was at least unreadable. Could the failure path abort instead, releasing the stream and deleting `path` without calling `end()`?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieCreateHandle.java:
##########
@@ -392,6 +393,40 @@ protected HoodieFileWriter initializeFileWriter() throws IOException {
assertDoesNotThrow(createHandle::close);
}
+ @Test
+ void testFileWriterClosedWhenDoWriteFails() throws Exception {
+ HoodieWriteConfig failOnWriteConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteIgnoreFailed(false)
+ .build();
+ HoodieTable failOnWriteTable = new TestBaseHoodieTable(failOnWriteConfig, getEngineContext(), metaClient);
+ CreateHandleWithFileWriterWriteFailure createHandle = new CreateHandleWithFileWriterWriteFailure(
+ failOnWriteConfig, TEST_INSTANT_TIME, failOnWriteTable, TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier);
+ HoodieRecord testRecord = dataGen.generateInserts(TEST_INSTANT_TIME, 1).get(0);
+
+ HoodieException exception = assertThrows(HoodieException.class, () ->
+ createHandle.doWrite(testRecord, TEST_SCHEMA, new TypedProperties()));
+
+ assertEquals("Simulated file writer write failure", exception.getMessage());
+ assertNull(createHandle.fileWriter);
Review Comment:
**minor:** This test still passes if the `CloseableUtils.closeSuppressing(fileWriter, failure)` line in `BaseCreateHandle` is deleted: it only checks that the field is null and the handle is marked closed. Not blocking, but could it capture `HoodieFileWriter fileWriter = createHandle.fileWriter;` before the `assertThrows` and then `assertFalse(fileWriter.canWrite())` (`TestFileWriter.canWrite()` returns `!closed`)?
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -174,28 +176,60 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeHFileWriter(indexByPartitionWriter, null);
+ failure = closeHFileWriter(indexByFileIdWriter, failure);
+ indexByPartitionWriter = null;
+ indexByFileIdWriter = null;
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
Review Comment:
**nit:** `close()` used to throw `HoodieIOException` for an `IOException` and now throws `HoodieException`, including on the success path through `finish()`. No in-repo caller depends on it, so feel free to ignore, but could this keep `HoodieIOException` when `failure` is an `IOException`?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieAppendHandle.java:
##########
@@ -87,6 +100,38 @@ private void mockMethodsNeededByConstructor() {
when(mockHoodieTable.getMetaClient()).thenReturn(metaClient);
}
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ void testFailedFlushClosesWriterAndPreventsAnotherFlush(boolean closeFails) throws IOException {
+ writeConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteTableVersion(HoodieTableVersion.SIX.versionCode())
+ .build();
+ when(mockHoodieTable.getStorage()).thenReturn(metaClient.getStorage());
+ HoodieInlineLogAppendHandle<Object, Object, Object, Object> handle = spy(
+ new HoodieInlineLogAppendHandle<>(writeConfig, TEST_INSTANT_TIME, mockHoodieTable,
+ TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier));
+ HoodieLogFormat.Writer writer = mock(HoodieLogFormat.Writer.class);
+ handle.writer = writer;
+ handle.recordItr = Collections.emptyIterator();
+ handle.recordList.add(mock(HoodieRecord.class));
Review Comment:
**nit:** This setup line is dead: `flushAppend()` is stubbed to throw and the later `close()` returns early on `isClosed()`, so the buffered record is never touched. Feel free to ignore.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/parquet/io/TestHoodieParquetBinaryCopyBaseSchemaEvolution.java:
##########
@@ -290,6 +299,62 @@ public void testSchemaEvolutionEnabled_AllowsLegacyConversion() throws Exception
assertEquals(true, legacyConversionAttempted, "Legacy conversion should be attempted when schema evolution is enabled");
}
+ @Test
+ public void testCloseParquetFileWriterQuietlyIgnoresWriterWithoutCloseMethod() {
Review Comment:
**nit:** These two reflection tests of the private `closeParquetFileWriterQuietly` are already covered by the public `close()` tests below (`testCloseClearsWriterWhenEndFails` uses a non-Closeable mock, `testCloseReleasesWriterWhenMetadataFails` a Closeable one). On spark4.x a plain `mock(ParquetFileWriter.class)` is `AutoCloseable`, so this test's name no longer holds there. Feel free to ignore, but could we drop these two plus the `getDeclaredMethod`/`Field` helpers in favor of a package-private `@VisibleForTesting` accessor, maybe with the close tests in their own class?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieCreateHandle.java:
##########
@@ -392,6 +393,40 @@ protected HoodieFileWriter initializeFileWriter() throws IOException {
assertDoesNotThrow(createHandle::close);
}
+ @Test
+ void testFileWriterClosedWhenDoWriteFails() throws Exception {
+ HoodieWriteConfig failOnWriteConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteIgnoreFailed(false)
+ .build();
+ HoodieTable failOnWriteTable = new TestBaseHoodieTable(failOnWriteConfig, getEngineContext(), metaClient);
+ CreateHandleWithFileWriterWriteFailure createHandle = new CreateHandleWithFileWriterWriteFailure(
+ failOnWriteConfig, TEST_INSTANT_TIME, failOnWriteTable, TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier);
+ HoodieRecord testRecord = dataGen.generateInserts(TEST_INSTANT_TIME, 1).get(0);
+
+ HoodieException exception = assertThrows(HoodieException.class, () ->
+ createHandle.doWrite(testRecord, TEST_SCHEMA, new TypedProperties()));
+
+ assertEquals("Simulated file writer write failure", exception.getMessage());
+ assertNull(createHandle.fileWriter);
+ assertTrue(createHandle.isClosed());
+ assertDoesNotThrow(createHandle::close);
+ }
+
+ private static class CreateHandleWithFileWriterWriteFailure extends HoodieCreateHandle<Object, Object, Object, Object> {
Review Comment:
**nit:** This member class duplicates the same-named local class inside `testMarkerFileCreatedWhenFileWriterWriteFails` (line 347), which shadows it. Feel free to ignore, but could we drop the local class so both tests use this one?
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -159,24 +160,44 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
writer.start();
log.info("init writer ");
} catch (Exception e) {
+ closeParquetFileWriterQuietly(e);
log.error("failed to init parquet writer", e);
throw new HoodieException(e);
}
}
@Override
public void close() throws IOException {
- Map<String, String> extraMetaData = finalizeMetadata();
- extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
- extraMetaData.remove("parquet.avro.schema");
- extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ if (writer == null) {
+ return;
+ }
+ try {
+ Map<String, String> extraMetaData = finalizeMetadata();
+ extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
+ extraMetaData.remove("parquet.avro.schema");
+ extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
+ writer.end(extraMetaData);
+ } catch (IOException | RuntimeException e) {
+ closeParquetFileWriterQuietly(e);
+ throw e;
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(Throwable failure) {
+ // Parquet 1.12.x/1.13.x have no close(); newer versions implement AutoCloseable.
+ ParquetFileWriter parquetFileWriter = writer;
+ writer = null;
+ if (parquetFileWriter instanceof AutoCloseable) {
Review Comment:
**minor:** On the default build this branch never fires: `ParquetFileWriter` implements `AutoCloseable` only from parquet 1.14, while the default `parquet.version` is 1.13.1 and spark3.3/3.4 use 1.12.x (only the spark4.x and flink2.x profiles are on 1.14+). The PR description already notes this. The tests reach the branch only via `extraInterfaces(Closeable.class)` mocks. Not blocking, but could `initFileWriter` wrap the `OutputFile` to keep the `PositionOutputStream` it creates, so this can close the stream directly on every parquet version?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
**blocker:** With `hoodie.write.executor.type=DISRUPTOR`, marking the handle closed on failure turns one lost record into the rest of the handle lost, and the write still succeeds. `DisruptorMessageQueue.setHandlers` swallows the consumer exception (`markAsFailed`), `BaseHoodieQueueBasedExecutor.execute()` still calls `finish()`, and `close()` returns a `writeStatus` that never went through its setup. Same shape in `BaseCreateHandle:132`. Could `close()` on a handle closed by a failure rethrow that failure instead of returning a status?
<details><summary>Trace (code read, not executed)</summary>
1. `CopyOnWriteInsertHandler.consume` > `BaseCreateHandle.doWrite` fails; the catch at :132 marks the handle closed, closes and nulls `fileWriter`, and throws.
2. `DisruptorMessageQueue.setHandlers` catches it, calls `markAsFailed`, and keeps consuming.
3. Each later record: `CopyOnWriteInsertHandler:105` calls `handle.canWrite` > `BaseCreateHandle:96` NPEs on the null `fileWriter`, swallowed the same way.
4. `execute()` completes normally > `finish()` > `closeOpenHandles()` > `close()` takes the `isClosed()` early return with `writeStatus` never passed through `setupWriteStatus`.
On master the handle kept writing, so only the failing record was lost. The append path behaves the same for `HoodieEarlyConflictDetectionException`, which throws even with ignore.failed=true, and its `statuses` skip the log-offset size fix-up.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060056526
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieCreateHandle.java:
##########
@@ -392,6 +393,40 @@ protected HoodieFileWriter initializeFileWriter() throws IOException {
assertDoesNotThrow(createHandle::close);
}
+ @Test
+ void testFileWriterClosedWhenDoWriteFails() throws Exception {
+ HoodieWriteConfig failOnWriteConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteIgnoreFailed(false)
+ .build();
+ HoodieTable failOnWriteTable = new TestBaseHoodieTable(failOnWriteConfig, getEngineContext(), metaClient);
+ CreateHandleWithFileWriterWriteFailure createHandle = new CreateHandleWithFileWriterWriteFailure(
+ failOnWriteConfig, TEST_INSTANT_TIME, failOnWriteTable, TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier);
+ HoodieRecord testRecord = dataGen.generateInserts(TEST_INSTANT_TIME, 1).get(0);
+
+ HoodieException exception = assertThrows(HoodieException.class, () ->
+ createHandle.doWrite(testRecord, TEST_SCHEMA, new TypedProperties()));
+
+ assertEquals("Simulated file writer write failure", exception.getMessage());
+ assertNull(createHandle.fileWriter);
+ assertTrue(createHandle.isClosed());
+ assertDoesNotThrow(createHandle::close);
+ }
+
+ private static class CreateHandleWithFileWriterWriteFailure extends HoodieCreateHandle<Object, Object, Object, Object> {
Review Comment:
Removed the duplicate local class. Both tests now use the shared `CreateHandleWithFileWriterWriteFailure` member class.
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -174,28 +176,60 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
- try {
- if (!closed) {
- indexByPartitionWriter.close();
- indexByFileIdWriter.close();
- closed = true;
- }
- } catch (IOException ioe) {
- throw new HoodieIOException(ioe.getMessage(), ioe);
+ if (closed) {
+ return;
+ }
+ Exception failure = closeHFileWriter(indexByPartitionWriter, null);
+ failure = closeHFileWriter(indexByFileIdWriter, failure);
+ indexByPartitionWriter = null;
+ indexByFileIdWriter = null;
+ closed = true;
+ if (failure != null) {
+ throw new HoodieException(failure.getMessage(), failure);
Review Comment:
Keeping the general `HoodieException` here for simplicity. I checked the in-repository bootstrap writer callers and found no handling that depends on the specific `HoodieIOException` subtype; the operation still fails with the original exception retained as its cause.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/parquet/io/TestHoodieParquetBinaryCopyBaseSchemaEvolution.java:
##########
@@ -290,6 +299,62 @@ public void testSchemaEvolutionEnabled_AllowsLegacyConversion() throws Exception
assertEquals(true, legacyConversionAttempted, "Legacy conversion should be attempted when schema evolution is enabled");
}
+ @Test
+ public void testCloseParquetFileWriterQuietlyIgnoresWriterWithoutCloseMethod() {
Review Comment:
Removed the private-method reflection tests and the Method/Field helpers. Close-lifecycle coverage now lives in `TestHoodieParquetBinaryCopyLifecycle`, using package-private `@VisibleForTesting` accessors and the public `close()` path. The tests account for whether the actual Parquet version implements `AutoCloseable`.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieAppendHandle.java:
##########
@@ -87,6 +100,38 @@ private void mockMethodsNeededByConstructor() {
when(mockHoodieTable.getMetaClient()).thenReturn(metaClient);
}
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ void testFailedFlushClosesWriterAndPreventsAnotherFlush(boolean closeFails) throws IOException {
+ writeConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteTableVersion(HoodieTableVersion.SIX.versionCode())
+ .build();
+ when(mockHoodieTable.getStorage()).thenReturn(metaClient.getStorage());
+ HoodieInlineLogAppendHandle<Object, Object, Object, Object> handle = spy(
+ new HoodieInlineLogAppendHandle<>(writeConfig, TEST_INSTANT_TIME, mockHoodieTable,
+ TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier));
+ HoodieLogFormat.Writer writer = mock(HoodieLogFormat.Writer.class);
+ handle.writer = writer;
+ handle.recordItr = Collections.emptyIterator();
+ handle.recordList.add(mock(HoodieRecord.class));
Review Comment:
Removed the unused buffered-record setup and its now-unused import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060619198
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -506,10 +500,32 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
}
}
+ private void closeFileWriter() throws IOException {
+ try {
+ if (fileWriter != null) {
+ fileWriter.close();
+ }
+ } finally {
+ fileWriter = null;
+ }
+ }
+
+ private void closeFileWriterQuietly(Throwable failure) {
Review Comment:
**major:** This cleanup only runs from `close()`, and the default merge handle never gets there on a write failure. `FileGroupReaderBasedMergeHandle` is the default for upsert and compaction (`HoodieWriteConfig:977`, `:992`), but `MergeUtils.runMerge:120-128` and `HoodieCompactor:172-173` only call `close()` after `doMerge()` succeeds, so with ignore.failed=false (Flink's default) a failed record leaves `fileWriter` open. `HoodieMergeHelper:160-171` has the same gap for this handle under the SIMPLE executor. Could `doMerge()` close the writer quietly on failure, or `runMerge` / `compact` close the handle in a `finally`? If that is out of scope, could the PR description say the default merge handle is not covered?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -506,10 +500,32 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
Review Comment:
**minor:** When this rethrows, `HoodieMergeHandleWithChangeLog.close()` (:114-125) skips `cdcLogger.close()`, since it calls `super.close()` with no `finally`; the CDC log writer plus its `ExternalSpillableMap` (`HoodieCDCLogger:239-250`) stay open. Not blocking, but could the override close `cdcLogger` with `closeSuppressing` onto the `super.close()` failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059110069
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
Fixed by marking the append handle closed on failure before releasing the writer. A later `close()` returns without flushing the buffered records again. `testFailedFlushClosesWriterAndPreventsAnotherFlush` covers this with buffered records and with both successful and failing writer cleanup.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
+ this.writer.close();
Review Comment:
Updated to `CloseableUtils.closeSuppressing(writer::close, failure)`, using the existing common utility after the rebase. It preserves the original failure and suppresses close failures, including `RuntimeException`. The method reference is needed because `HoodieFileBinaryCopier` itself does not implement `AutoCloseable`.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroHFileWriter.java:
##########
@@ -105,8 +106,14 @@ public HoodieAvroHFileWriter(String instantTime, StoragePath file, HoodieHFileCo
.build();
StorageConfiguration<Configuration> storageConf = new HadoopStorageConfiguration(conf);
StoragePath filePath = new StoragePath(this.file.toUri());
- OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
- this.writer = new HFileWriterImpl(context, outputStream);
+ OutputStream outputStream = HoodieStorageUtils.getStorage(filePath, storageConf).create(filePath);
+ try {
+ this.writer = new HFileWriterImpl(context, outputStream);
+ } finally {
+ if (this.writer == null) {
+ closeQuietly(outputStream);
Review Comment:
Fixed: the protected constructor region now includes `appendFileInfo`. On failure it closes the initialized writer, or the output stream if writer construction did not complete, and suppresses any cleanup failure onto the original exception. Added `testConstructorClosesWriterWhenFileInfoFails`, covering both successful cleanup and a failing close.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -118,14 +118,26 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterAfterFailure(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterAfterFailure(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting " + this.path + ". Using " + timer.endTimer() + " mills");
}
+ private void closeWriterAfterFailure(Throwable failure) {
+ try {
Review Comment:
Done. Binary-copy cleanup now shares `CloseableUtils.closeSuppressing` with the other handles. The duplicate `AutoCloseableUtils` class has been removed in favor of the utility already present on upstream master.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -147,17 +154,42 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
@Override
public void close() throws IOException {
+ if (writer == null) {
+ return;
+ }
Map<String, String> extraMetaData = finalizeMetadata();
extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
extraMetaData.remove("parquet.avro.schema");
extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ try {
+ writer.end(extraMetaData);
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(ParquetFileWriter parquetFileWriter) {
+ if (parquetFileWriter == null) {
+ return;
+ }
+ Method closeMethod;
+ try {
+ // ParquetFileWriter does not implement Closeable in all versions, so attempt close() reflectively.
+ closeMethod = parquetFileWriter.getClass().getMethod("close");
+ } catch (NoSuchMethodException e) {
+ return;
Review Comment:
Simplified this to an `instanceof AutoCloseable` check and removed reflection. The comment now identifies Parquet 1.12.x/1.13.x as lacking `close()`; newer versions implement `AutoCloseable`. The older-version failure-cleanup limitation is also called out in the PR description: fully fixing it requires direct output-stream ownership.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -485,10 +483,30 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
Review Comment:
Done: removed the success-path assignments and kept `keyToNewRecords = null` and `writtenRecordKeys = null` in `finally`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/BaseCreateHandle.java:
##########
@@ -168,6 +170,11 @@ protected HoodieRecord<T> updateFileName(HoodieRecord<T> record, HoodieSchema sc
return record.prependMetaFields(schema, targetSchema, metadataValues, prop);
}
+ private void closeFileWriterQuietly(Throwable failure) {
Review Comment:
This was an oversight. Failure cleanup now calls `markClosed()` before closing the file writer. The create-handle regression test also checks `isClosed()` and verifies that a subsequent `close()` succeeds without attempting finalization again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495299061
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.69%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 29 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 45.69% -22.47%
+ Complexity 29149 15763 -13386
=============================================
Files 2521 2007 -514
Lines 141353 112793 -28560
Branches 17549 14179 -3370
=============================================
- Hits 96341 51542 -44799
- Misses 37079 55588 +18509
+ Partials 7933 5663 -2270
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `74.25% <0.00%> (-16.84%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `67.93% <30.76%> (-9.94%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1645 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495569244
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495559364
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <39.52%> (-0.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495495173
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96817 +476
- Misses 37079 37146 +67
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <39.52%> (-0.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [39 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495429985
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `52.55814%` with `102 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.12%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.12% -1.03%
+ Complexity 29149 28847 -302
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 95281 -1060
- Misses 37079 38689 +1610
- Partials 7933 7969 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <26.19%> (-4.54%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.63% <42.85%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `60.86% <100.00%> (-2.18%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [215 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486260652
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f4784f2c99e6fdda274f8ed2a7f68e39c360310 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101)
* a7da5bc4d5d2637d3747297a649d3343acf24003 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486861056
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.05%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|4|
>|spark-scala-tests|12|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 61.05% -7.11%
+ Complexity 29149 25615 -3534
============================================
Files 2521 2505 -16
Lines 141353 139234 -2119
Branches 17549 17056 -493
============================================
- Hits 96341 85011 -11330
- Misses 37079 46952 +9873
+ Partials 7933 7271 -662
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.24% <8.05%> (-16.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <18.48%> (-12.04%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486905760
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.75%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|6|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.75% -7.40%
+ Complexity 29149 26041 -3108
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 86154 -10187
- Misses 37079 48075 +10996
+ Partials 7933 7570 -363
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.47% <8.05%> (-17.47%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.48%> (-12.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `68.66% <41.66%> (-12.41%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [561 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486978931
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.38889%` with `105 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.27%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.27% -0.89%
+ Complexity 29149 28859 -290
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 95390 -951
- Misses 37079 38439 +1360
- Partials 7933 7970 +37
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.93% <25.11%> (-4.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <41.70%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [169 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4487091675
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.16667%` with `99 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.17% +0.01%
- Complexity 29149 29254 +105
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
+ Hits 96341 96669 +328
- Misses 37079 37168 +89
- Partials 7933 7962 +29
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <38.38%> (-0.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <41.70%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "HuangZhenQiu (via GitHub)" <gi...@apache.org>.
HuangZhenQiu commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5755287714
Thanks. It is needed for fixing a memory leakage issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4059225736
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -485,10 +483,30 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
Review Comment:
**minor:** On the failure path `keyToNewRecords` is set to null here without being closed, so an `ExternalSpillableMap`'s spill files stay until the JVM shutdown hook (`DiskMap`). The new close-failure branches also have no test; `TestSortedAndChangeLogMergeHandles` only covers the happy path (:83, :225). Not blocking, but could the failure branch `closeSuppressing` the map, with a test there where `fileWriter.close()` throws asserting the original exception, a single writer close, and a no-op second `close()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5759776936
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
}, {
"hash" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17219",
"triggerID" : "d37141ee273de412f09eb0bf11d7563cdf71ab00",
"triggerType" : "PUSH"
}, {
"hash" : "f8affff7793984a7a323988ac54598155842364f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222",
"triggerID" : "f8affff7793984a7a323988ac54598155842364f",
"triggerType" : "PUSH"
}, {
"hash" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0708d42dc518830a6d0470470e15b919467e1ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f8affff7793984a7a323988ac54598155842364f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17222)
* f0708d42dc518830a6d0470470e15b919467e1ca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486962336
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.38889%` with `105 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.08%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 67.08% -1.08%
+ Complexity 29149 28769 -380
============================================
Files 2521 2526 +5
Lines 141353 141799 +446
Branches 17549 17602 +53
============================================
- Hits 96341 95127 -1214
- Misses 37079 38709 +1630
- Partials 7933 7963 +30
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.66% <25.11%> (-4.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.49% <41.70%> (-0.35%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <25.11%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `60.86% <100.00%> (-2.18%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [217 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r3267048829
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/AutoClosableUtils.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * Utility methods for closing {@link AutoCloseable} resources.
+ */
+public final class AutoClosableUtils {
Review Comment:
🤖 nit: the class name `AutoClosableUtils` drops the 'e' from `AutoCloseable` (the Java interface it wraps). Could you rename it to `AutoCloseableUtils` to match the interface spelling? As-is, someone searching for "AutoCloseable" utils won't naturally land here.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -175,27 +176,67 @@ private void commit() {
* Close Writer Handles.
*/
public void close() {
+ if (closed) {
+ return;
+ }
+ IOException failure = null;
try {
- if (!closed) {
+ if (indexByPartitionWriter != null) {
indexByPartitionWriter.close();
+ }
+ } catch (IOException ioe) {
Review Comment:
🤖 Both this `catch (IOException ioe)` and the one at line 194 only handle `IOException`. If `indexByPartitionWriter.close()` throws a `RuntimeException`, we skip closing `indexByFileIdWriter`, never set `closed = true`, and the original failure passed to `closeAfterFailedBegin` is shadowed (since that method at line 238 also only catches `HoodieIOException`). Could you widen these to `Throwable` (or at least also catch `RuntimeException`) so the second writer is always attempted and the original failure isn't lost?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495066364
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `13.61257%` with `165 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.86%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 0.00% | [70 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 17.39% | [18 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 33 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 44.86% -23.29%
+ Complexity 29149 8576 -20573
=============================================
Files 2521 1203 -1318
Lines 141353 63056 -78297
Branches 17549 6858 -10691
=============================================
- Hits 96341 28293 -68048
+ Misses 37079 31633 -5446
+ Partials 7933 3130 -4803
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `69.62% <50.00%> (-21.29%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `49.76% <41.66%> (-31.30%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `62.87% <0.00%> (-28.22%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `62.50% <30.76%> (-15.38%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | `17.39% <17.39%> (ø)` | |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | `0.00% <0.00%> (-80.42%)` | :arrow_down: |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2111 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495019958
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7da5bc4d5d2637d3747297a649d3343acf24003 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102)
* 1ee5fbfc27b817000680fd48b891f2898a5d3244 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495382875
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.23256%` with `107 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.04%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|7|
>|spark-scala-tests|12|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 63.04% -5.12%
+ Complexity 29149 27082 -2067
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
- Hits 96341 89485 -6856
- Misses 37079 44904 +7825
+ Partials 7933 7550 -383
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <26.19%> (-4.54%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <18.57%> (-12.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `89.10% <100.00%> (-1.99%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `73.73% <41.66%> (-7.34%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [406 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495309304
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.80952%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.68%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 26.08% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (1ee5fbf). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (1ee5fbf) |
>|------|------|------|
>|spark-java-tests|18|1|
>|spark-scala-tests|12|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 47.68% -20.48%
+ Complexity 29149 16755 -12394
=============================================
Files 2521 2037 -484
Lines 141353 115532 -25821
Branches 17549 14830 -2719
=============================================
- Hits 96341 55089 -41252
- Misses 37079 54481 +17402
+ Partials 7933 5962 -1971
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <8.09%> (-16.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <18.57%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `69.38% <0.00%> (-17.85%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `81.18% <0.00%> (-9.91%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `69.83% <30.76%> (-8.04%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1578 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4495480845
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.17% +0.01%
- Complexity 29149 29309 +160
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96767 +426
- Misses 37079 37203 +124
- Partials 7933 7969 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <39.52%> (-0.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <42.85%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [42 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4496094007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14101",
"triggerID" : "0f4784f2c99e6fdda274f8ed2a7f68e39c360310",
"triggerType" : "PUSH"
}, {
"hash" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14102",
"triggerID" : "a7da5bc4d5d2637d3747297a649d3343acf24003",
"triggerType" : "PUSH"
}, {
"hash" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146",
"triggerID" : "1ee5fbfc27b817000680fd48b891f2898a5d3244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ee5fbfc27b817000680fd48b891f2898a5d3244 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14146)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486642495
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `13.54167%` with `166 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.90%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 0.00% | [70 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 16.00% | [20 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 33 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|18|0|
>|spark-scala-tests|12|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
=============================================
- Coverage 68.15% 44.90% -23.25%
+ Complexity 29149 8574 -20575
=============================================
Files 2521 1203 -1318
Lines 141353 62976 -78377
Branches 17549 6828 -10721
=============================================
- Hits 96341 28281 -68060
+ Misses 37079 31576 -5503
+ Partials 7933 3119 -4814
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `69.62% <50.00%> (-21.29%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `67.34% <0.00%> (-19.89%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `49.76% <41.66%> (-31.30%)` | :arrow_down: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `62.87% <0.00%> (-28.22%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `62.50% <30.76%> (-15.38%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (-81.97%)` | :arrow_down: |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | `16.00% <16.00%> (ø)` | |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | `0.00% <0.00%> (-80.42%)` | :arrow_down: |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-4486816487
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `49.07407%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.01%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a7da5bc`](https://app.codecov.io/gh/apache/hudi/commit/a7da5bc4d5d2637d3747297a649d3343acf24003?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 43.75% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/util/AutoClosableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoClosableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NhYmxlVXRpbHMuamF2YQ==) | 36.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | 41.66% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cd2c8b8) and HEAD (a7da5bc). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cd2c8b8) | HEAD (a7da5bc) |
>|------|------|------|
>|spark-java-tests|18|1|
>|spark-scala-tests|12|2|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
- Coverage 68.15% 60.01% -8.14%
+ Complexity 29149 24324 -4825
============================================
Files 2521 2456 -65
Lines 141353 134131 -7222
Branches 17549 15966 -1583
============================================
- Hits 96341 80505 -15836
- Misses 37079 46767 +9688
+ Partials 7933 6859 -1074
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <20.83%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <13.54%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.24% <37.37%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <8.05%> (-15.98%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <18.48%> (-11.97%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `88.61% <100.00%> (-2.48%)` | :arrow_down: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `83.54% <50.00%> (-7.37%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `0.00% <0.00%> (-63.05%)` | :arrow_down: |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `66.82% <41.66%> (-14.25%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `72.01% <30.76%> (-5.87%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [720 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18776:
URL: https://github.com/apache/hudi/pull/18776#issuecomment-5331693904
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.34884%` with `96 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`cd2c8b8`](https://app.codecov.io/gh/apache/hudi/commit/cd2c8b831c8b7c8f46b1f175bdb323329f60c8ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ee5fbf`](https://app.codecov.io/gh/apache/hudi/commit/1ee5fbfc27b817000680fd48b891f2898a5d3244?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 400 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/hudi/parquet/io/HoodieParquetBinaryCopyBase.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fparquet%2Fio%2FHoodieParquetBinaryCopyBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3BhcnF1ZXQvaW8vSG9vZGllUGFycXVldEJpbmFyeUNvcHlCYXNlLmphdmE=) | 52.85% | [27 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 48.48% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/util/AutoCloseableUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAutoCloseableUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3V0aWwvQXV0b0Nsb3NlYWJsZVV0aWxzLmphdmE=) | 39.13% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | 30.76% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/hudi/io/HoodieBinaryCopyHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieBinaryCopyHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUJpbmFyeUNvcHlIYW5kbGUuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | 78.57% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18776 +/- ##
============================================
+ Coverage 68.15% 68.21% +0.05%
- Complexity 29149 29332 +183
============================================
Files 2521 2528 +7
Lines 141353 141939 +586
Branches 17549 17633 +84
============================================
+ Hits 96341 96819 +478
- Misses 37079 37144 +65
- Partials 7933 7976 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <21.86%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <13.61%> (-0.12%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <38.53%> (-0.10%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <39.52%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <42.85%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18776/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.45% <26.19%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18776?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/hudi/io/BaseCreateHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FBaseCreateHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0Jhc2VDcmVhdGVIYW5kbGUuamF2YQ==) | `89.79% <100.00%> (+2.56%)` | :arrow_up: |
| [...java/org/apache/hudi/common/util/ParquetUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FParquetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi91dGlsL1BhcnF1ZXRVdGlscy5qYXZh) | `91.08% <100.00%> (ø)` | |
| [...scala/org/apache/spark/sql/hudi/SparkHelpers.scala](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fhudi%2FSparkHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvaHVkaS9TcGFya0hlbHBlcnMuc2NhbGE=) | `63.04% <100.00%> (ø)` | |
| [...ava/org/apache/hudi/io/HoodieWriteMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieWriteMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVdyaXRlTWVyZ2VIYW5kbGUuamF2YQ==) | `81.56% <91.66%> (+0.49%)` | :arrow_up: |
| [...va/org/apache/hudi/io/HoodieSortedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieSortedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZVNvcnRlZE1lcmdlSGFuZGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../hudi/io/storage/hadoop/HoodieAvroHFileWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieAvroHFileWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZUF2cm9IRmlsZVdyaXRlci5qYXZh) | `88.60% <50.00%> (-2.31%)` | :arrow_down: |
| [...ge/row/HoodieRowDataParquetOutputStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowDataParquetOutputStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93RGF0YVBhcnF1ZXRPdXRwdXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `75.75% <40.00%> (-7.01%)` | :arrow_down: |
| [...udi/io/storage/HoodieSparkParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya1BhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...i/io/storage/hadoop/HoodieParquetStreamWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Fhadoop%2FHoodieParquetStreamWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL3N0b3JhZ2UvaGFkb29wL0hvb2RpZVBhcnF1ZXRTdHJlYW1Xcml0ZXIuamF2YQ==) | `72.72% <78.57%> (-6.59%)` | :arrow_down: |
| [...in/java/org/apache/hudi/io/HoodieAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FHoodieAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0hvb2RpZUFwcGVuZEhhbmRsZS5qYXZh) | `76.08% <30.76%> (-1.79%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/hudi/pull/18776?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [37 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: close the file writers properly in fail cases [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060055211
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -531,6 +532,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record " + record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeLogWriterQuietly(t);
Review Comment:
@voonhous I agree that Disruptor must propagate its stored consumer failure. The handle already throws from write when `getIgnoreWriteFailed()` is false, but `setHandlers()` catches it and the executor only checks the stored failure inside its own catch block. I'm keeping this PR focused on releasing resources and deferring that executor propagation issue to a separate fix, rather than adding failure state or rethrow checks to the handles. This concern remains unaddressed here.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -485,10 +483,30 @@ public List<WriteStatus> close() {
return Collections.singletonList(writeStatus);
} catch (IOException e) {
+ closeFileWriterQuietly(e);
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
+ } catch (RuntimeException e) {
+ closeFileWriterQuietly(e);
+ throw e;
+ } finally {
+ keyToNewRecords = null;
+ writtenRecordKeys = null;
Review Comment:
@voonhous Fixed with try-with-resources around `writeIncomingRecords()`, so the spill map closes even if writing pending records throws. This also preserves the original exception if map cleanup fails, without a separate map-cleanup branch. Added tests for the pending-record failure and for `fileWriter.close()` throwing; they verify cleanup, the original cause, a single writer close, and a no-op second handle close.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
Review Comment:
I'm retaining the existing `close()` finalization path to keep this PR limited to resource release. It can leave an incomplete copy with a valid footer, as you describe; aborting and deleting that output would need a separate lifecycle change. This PR does not address orphan-output cleanup. The added regression test checks that a copy failure still closes the copier and preserves the original exception if close also fails.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieBinaryCopyHandle.java:
##########
@@ -120,18 +121,31 @@ public void write() {
log.info("Schema evolution enabled for binary copy: {}", schemaEvolutionEnabled);
records = this.writer.binaryCopy(inputFiles, Collections.singletonList(path), writeScheMessageType, schemaEvolutionEnabled);
} catch (IOException e) {
+ closeWriterQuietly(e);
throw new HoodieIOException(e.getMessage(), e);
+ } catch (RuntimeException e) {
+ closeWriterQuietly(e);
+ throw e;
} finally {
this.recordsWritten = records;
this.insertRecordsWritten = records;
}
log.info("Finish rewriting {}. Using {} mills", this.path, timer.endTimer());
}
+ private void closeWriterQuietly(Throwable failure) {
+ markClosed();
+ CloseableUtils.closeSuppressing(writer::close, failure);
Review Comment:
Fixed: `close()` now uses try-with-resources for the current reader and a `finally` block for executor shutdown and buffer release. Both run when `super.close()` throws. The lifecycle regression test covers simultaneous finalization and reader-close failures, preserves the original exception, and checks that the executor terminates.
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/SparkHelpers.scala:
##########
@@ -72,14 +72,17 @@ object SparkHelpers {
conf.unwrap().setClassLoader(Thread.currentThread.getContextClassLoader)
val writer = new HoodieAvroParquetWriter(destinationFile, parquetConfig, instantTime, new SparkTaskContextSupplier(), true)
- for (rec <- sourceRecords) {
- val key: String = rec.get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString
- if (!keysToSkip.contains(key)) {
+ try {
+ for (rec <- sourceRecords) {
+ val key: String = rec.get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString
+ if (!keysToSkip.contains(key)) {
- writer.writeAvro(key, rec)
+ writer.writeAvro(key, rec)
+ }
}
+ } finally {
+ writer.close()
Review Comment:
Updated as suggested: the catch calls `CloseableUtils.closeSuppressing(writer, t)` and rethrows the original write exception, while the success path calls `writer.close()` directly. The Spark reactor compiles successfully.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieNativeLogAppendHandle.java:
##########
@@ -163,8 +163,11 @@ protected void flushAppend() {
@Override
protected void closeLogWriter() {
- if (writer != null) {
- writer.close();
+ try {
+ if (writer != null) {
+ writer.close();
+ }
+ } finally {
writer = null;
Review Comment:
Added native-writer coverage for both `writeRecord` and `write(Map)` failures, including a cleanup exception, plus a direct writer-close failure. The tests verify that the handle is closed, the writer reference is null, subsequent handle close is harmless, and the writer is closed only once.
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:
##########
@@ -159,24 +160,44 @@ protected void initFileWriter(Path outPutFile, CompressionCodecName newCodecName
writer.start();
log.info("init writer ");
} catch (Exception e) {
+ closeParquetFileWriterQuietly(e);
log.error("failed to init parquet writer", e);
throw new HoodieException(e);
}
}
@Override
public void close() throws IOException {
- Map<String, String> extraMetaData = finalizeMetadata();
- extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
- extraMetaData.remove("parquet.avro.schema");
- extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
- writer.end(extraMetaData);
- // Release the buffer
- reusableBlockBuffer = null;
+ if (writer == null) {
+ return;
+ }
+ try {
+ Map<String, String> extraMetaData = finalizeMetadata();
+ extraMetaData = extraMetaData == null ? new HashMap<>() : extraMetaData;
+ extraMetaData.remove("parquet.avro.schema");
+ extraMetaData.remove("org.apache.spark.sql.parquet.row.metadata");
+ writer.end(extraMetaData);
+ } catch (IOException | RuntimeException e) {
+ closeParquetFileWriterQuietly(e);
+ throw e;
+ } finally {
+ writer = null;
+ // Release the buffer
+ reusableBlockBuffer = null;
+ }
}
protected abstract Map<String, String> finalizeMetadata();
+ private void closeParquetFileWriterQuietly(Throwable failure) {
+ // Parquet 1.12.x/1.13.x have no close(); newer versions implement AutoCloseable.
+ ParquetFileWriter parquetFileWriter = writer;
+ writer = null;
+ if (parquetFileWriter instanceof AutoCloseable) {
Review Comment:
Keeping the Parquet 1.12/1.13 limitation explicit rather than introducing output-stream tracking in this patch. The cleanup comment now states that those versions expose no close API and a failed start/end can leave the stream open. Newer versions still use `AutoCloseable`. The revised lifecycle tests use the actual version's writer interface rather than adding `Closeable` through mock extra interfaces.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieCreateHandle.java:
##########
@@ -392,6 +393,40 @@ protected HoodieFileWriter initializeFileWriter() throws IOException {
assertDoesNotThrow(createHandle::close);
}
+ @Test
+ void testFileWriterClosedWhenDoWriteFails() throws Exception {
+ HoodieWriteConfig failOnWriteConfig = HoodieWriteConfig.newBuilder()
+ .withProps(writeConfig.getProps())
+ .withWriteIgnoreFailed(false)
+ .build();
+ HoodieTable failOnWriteTable = new TestBaseHoodieTable(failOnWriteConfig, getEngineContext(), metaClient);
+ CreateHandleWithFileWriterWriteFailure createHandle = new CreateHandleWithFileWriterWriteFailure(
+ failOnWriteConfig, TEST_INSTANT_TIME, failOnWriteTable, TEST_PARTITION_PATH, TEST_FILE_ID, taskContextSupplier);
+ HoodieRecord testRecord = dataGen.generateInserts(TEST_INSTANT_TIME, 1).get(0);
+
+ HoodieException exception = assertThrows(HoodieException.class, () ->
+ createHandle.doWrite(testRecord, TEST_SCHEMA, new TypedProperties()));
+
+ assertEquals("Simulated file writer write failure", exception.getMessage());
+ assertNull(createHandle.fileWriter);
Review Comment:
Done: the test captures the file writer before the failing write and asserts `assertFalse(fileWriter.canWrite())` afterward, so it verifies actual writer closure as well as the cleared handle reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org