You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "itschrispeck (via GitHub)" <gi...@apache.org> on 2023/07/26 20:10:48 UTC
[GitHub] [pinot] itschrispeck opened a new pull request, #11186: bugfix: safely multiply integers to prevent overflow
itschrispeck opened a new pull request, #11186:
URL: https://github.com/apache/pinot/pull/11186
We've observed this exception, blocking ingestion:
```
j.l.IllegalArgumentException: Illegal memory allocation -2116790016 for segment <table>__0__50__20230724T1340Z column <table>__0__50__20230724T1340Z:message_encodedVars.mv.raw.fwd
at c.g.common.base.Preconditions.checkArgument(Preconditions.java:135)
at o.a.p.s.l.i.r.RealtimeIndexOffHeapMemoryManager.allocate(RealtimeIndexOffHeapMemoryManager.java:83)
at o.a.p.s.l.r.i.f.FixedByteMVMutableForwardIndex.addDataBuffer(FixedByteMVMutableForwardIndex.java:169)
... 21 common frames omitted
Wrapped by: java.lang.RuntimeException: Error while expanding the capacity by allocating additional buffer with capacity:272272160
at o.a.p.s.l.r.i.f.FixedByteMVMutableForwardIndex.addDataBuffer(FixedByteMVMutableForwardIndex.java:176)
at o.a.p.s.l.r.i.f.FixedByteMVMutableForwardIndex.<init>(FixedByteMVMutableForwardIndex.java:142)
at o.a.p.s.l.s.i.f.ForwardIndexType.createMutableIndex(ForwardIndexType.java:300)
at o.a.p.s.l.s.i.f.ForwardIndexType.createMutableIn...
```
The negative size comes from an int overflow from unsafe multiplication of two ints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11186: bugfix: safely multiply integers to prevent overflow
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11186:
URL: https://github.com/apache/pinot/pull/11186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11186: bugfix: safely multiply integers to prevent overflow
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11186:
URL: https://github.com/apache/pinot/pull/11186#issuecomment-1652492457
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11186?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11186](https://app.codecov.io/gh/apache/pinot/pull/11186?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (54f72c3) into [master](https://app.codecov.io/gh/apache/pinot/commit/a86ba9c42fa94703988a477620966eb5f31f6d89?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a86ba9c) will **increase** coverage by `0.00%`.
> Report is 1 commits behind head on master.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11186 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2218 2163 -55
Lines 119138 116583 -2555
Branches 18022 17710 -312
=========================================
Hits 137 137
+ Misses 118981 116426 -2555
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <0.00%> (ø)` | |
| unittests2temurin20 | `0.11% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/impl/forward/FixedByteMVMutableForwardIndex.java](https://app.codecov.io/gh/apache/pinot/pull/11186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9yZWFsdGltZS9pbXBsL2ZvcndhcmQvRml4ZWRCeXRlTVZNdXRhYmxlRm9yd2FyZEluZGV4LmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [57 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org