Re: Review Request: HBASE-1511: Pseudo distributed mode for HBase

[st...@duboce.net]

> On 2010-07-16 13:39:10, stack wrote:
> > trunk/bin/local-master-backup.sh, line 1
> > <http://review.cloudera.org/r/328/diff/1/?file=2844#file2844line1>
> >
> >     Why is it called local-master-backup?  Should be a more descriptive name?  Its the 'backup' that throws me off.  'local-masters'?
> >
> 
> Nicolas wrote:
>     This JIRA also needs an associated wiki article change.  So, the workflow would be:
>     
>     ./bin/start-hbase.sh
>     ./bin/local-master-backup start 1
>     
>     I don't think you would want to use this file to start the original master, use start-hbase.sh for that.  You primarily want to use this script to test master failover conditions.

Don't write a wiki article.  Add an article under src/site, under xdoc or apt (not yet in place).  This can be done in a separate issue.  Meantime, on commit I can add the above  on how its used (w/o it, I was a little baffled but just those few lines above explain it all -- for me at least).


> On 2010-07-16 13:39:10, stack wrote:
> > trunk/bin/local-master-backup.sh, line 10
> > <http://review.cloudera.org/r/328/diff/1/?file=2844#file2844line10>
> >
> >     Explain 'offset' in this usage output?  (Seems to be port offset from default?)
> 
> Nicolas wrote:
>     offset is not only the port offset, but also an identifier for the logs.  The log for "./bin/local-master-backup.sh start 1" would be located at logs/hbase-<user>-1-master-<server>.log
>     
>     In an internal review, Kannan asked why you couldn't use "start 0", I thought offset would help explain that issue.  opinions?

Hmm... maybe you do need an article on how this stuff works.   Smile.  Offset is fine (Is Kannan saying that a 'start 0' should be rejected?).  If you put together a paragraph or two, I'll take care of sticking it into proper format.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/328/#review414
-----------------------------------------------------------


On 2010-07-15 22:42:55, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/328/
> -----------------------------------------------------------
> 
> (Updated 2010-07-15 22:42:55)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Pseudo-distributed mode for HBase
> 
> * separate processes for Master & RS
> * script to add more RS in a psuedo-distributed cluster
> * script to add backup masters in a psudo-distributed cluster
> * config file that
>   a. explains basic psuedo-distributed mode settings
>   b. shows the extra options to add for running on top of pseudo-distributed HDFS
> 
> Note that I needed to add a GNU Parsing utility to the master + regionserver so I could override certain config values on the fly instead of making seperate config files.
> 
> 
> This addresses bug HBASE-1511.
>     http://issues.apache.org/jira/browse/HBASE-1511
> 
> 
> Diffs
> -----
> 
>   trunk/bin/local-master-backup.sh PRE-CREATION 
>   trunk/bin/local-regionservers.sh PRE-CREATION 
>   trunk/conf/hbase-site.xml.psuedo-distributed PRE-CREATION 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 964686 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 964686 
> 
> Diff: http://review.cloudera.org/r/328/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>