You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by alberskib <gi...@git.apache.org> on 2015/12/04 20:56:14 UTC
[GitHub] spark pull request: SPARK-12038 Add support for pickle protocol to...
GitHub user alberskib opened a pull request:
https://github.com/apache/spark/pull/10148
SPARK-12038 Add support for pickle protocol to graphite sink
Code change introduce support for pickle protocol which prior to http://graphite.readthedocs.org/en/latest/feeding-carbon.html
> ... is a much more efficient take on the plaintext protocol, and supports sending batches of metrics to Carbon in one go.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alberskib/spark feature/SPARK-12038
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10148
----
commit cb19b8438b0a632aa90130274c2e92c1206d9ebd
Author: Bartlomiej Alberski <al...@gmail.com>
Date: 2015-12-04T19:49:35Z
SPARK-12038 Add support for pickle protocol to graphite sink
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #10148: SPARK-12038 Add support for pickle protocol to graphite ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/10148
Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #10148: SPARK-12038 Add support for pickle protocol to gr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-12038 Add support for pickle protocol to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10148#issuecomment-162066761
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org