You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/15 23:40:07 UTC
Re: Review Request 57666: Added the '--authenticate_http_executors'
agent flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57666/
-----------------------------------------------------------
(Updated March 15, 2017, 11:40 p.m.)
Review request for mesos, Jan Schlicht and Vinod Kone.
Summary (updated)
-----------------
Added the '--authenticate_http_executors' agent flag.
Bugs: MESOS-6998
https://issues.apache.org/jira/browse/MESOS-6998
Repository: mesos
Description
-------
This patch adds a new agent flag, `--authenticate_http_executors`,
which requires authentication on the V1 executor API and loads the
default JWT authenticator.
Diffs
-----
docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b
src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
Diff: https://reviews.apache.org/r/57666/diff/3/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 57666: Added the '--authenticate_http_executors'
agent flag.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57666/
-----------------------------------------------------------
(Updated March 16, 2017, 7:03 p.m.)
Review request for mesos, Jan Schlicht and Vinod Kone.
Bugs: MESOS-6998
https://issues.apache.org/jira/browse/MESOS-6998
Repository: mesos
Description
-------
This patch adds a new agent flag, `--authenticate_http_executors`,
which requires authentication on the V1 executor API and loads the
default JWT authenticator.
Diffs (updated)
-----
docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b
src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
Diff: https://reviews.apache.org/r/57666/diff/4/
Changes: https://reviews.apache.org/r/57666/diff/3-4/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 57666: Added the '--authenticate_http_executors'
agent flag.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57666/#review169139
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 15, 2017, 11:40 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57666/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 11:40 p.m.)
>
>
> Review request for mesos, Jan Schlicht and Vinod Kone.
>
>
> Bugs: MESOS-6998
> https://issues.apache.org/jira/browse/MESOS-6998
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new agent flag, `--authenticate_http_executors`,
> which requires authentication on the V1 executor API and loads the
> default JWT authenticator.
>
>
> Diffs
> -----
>
> docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
>
>
> Diff: https://reviews.apache.org/r/57666/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57666: Added the '--authenticate_http_executors'
agent flag.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57666/#review169143
-----------------------------------------------------------
src/slave/flags.cpp
Line 881 (original), 881 (patched)
<https://reviews.apache.org/r/57666/#comment241473>
remove this line?
- Vinod Kone
On March 15, 2017, 11:40 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57666/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 11:40 p.m.)
>
>
> Review request for mesos, Jan Schlicht and Vinod Kone.
>
>
> Bugs: MESOS-6998
> https://issues.apache.org/jira/browse/MESOS-6998
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new agent flag, `--authenticate_http_executors`,
> which requires authentication on the V1 executor API and loads the
> default JWT authenticator.
>
>
> Diffs
> -----
>
> docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
>
>
> Diff: https://reviews.apache.org/r/57666/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>